mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-07-17 14:15:13 +00:00
feat(backup)!: opt-in hard restart and mandatory backups-dir
Rename --docker-compose-hard-restart-required to --hard-compose-restart and change its default from ["mailu"] to [] (nargs="*"): the compose down/up is now opt-in, so compose hosts pass "mailu" while swarm hosts, where the dir is a stack whose overlay network collides with compose up, pass nothing. Make --backups-dir mandatory (no /var/lib/backup/ default) so a run can never silently target the wrong backup root. BREAKING CHANGE: the old flag name is removed, the implicit mailu default is gone, and --backups-dir must be passed explicitly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -247,8 +247,6 @@ def main() -> int:
|
||||
print("Finished volume backups.", flush=True)
|
||||
|
||||
print("Handling Docker Compose services...", flush=True)
|
||||
handle_docker_compose_services(
|
||||
args.compose_dir, args.docker_compose_hard_restart_required
|
||||
)
|
||||
handle_docker_compose_services(args.compose_dir, args.hard_compose_restart)
|
||||
|
||||
return 0
|
||||
|
||||
@@ -17,10 +17,10 @@ def parse_args() -> argparse.Namespace:
|
||||
help="Path to the parent directory containing docker-compose setups",
|
||||
)
|
||||
p.add_argument(
|
||||
"--docker-compose-hard-restart-required",
|
||||
nargs="+",
|
||||
default=["mailu"],
|
||||
help="Compose dir names that require 'docker-compose down && up -d' (default: mailu)",
|
||||
"--hard-compose-restart",
|
||||
nargs="*",
|
||||
default=[],
|
||||
help="Compose dir names that require 'docker-compose down && up -d' (default: none; pass e.g. 'mailu' under compose where the DB cannot be backed up hot)",
|
||||
)
|
||||
|
||||
p.add_argument(
|
||||
@@ -35,8 +35,8 @@ def parse_args() -> argparse.Namespace:
|
||||
)
|
||||
p.add_argument(
|
||||
"--backups-dir",
|
||||
default="/var/lib/backup/",
|
||||
help="Backup root directory (default: /var/lib/backup/)",
|
||||
required=True,
|
||||
help="Backup root directory (e.g. /var/lib/backup/)",
|
||||
)
|
||||
|
||||
p.add_argument(
|
||||
|
||||
Reference in New Issue
Block a user