mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-09 20:26:33 +00:00
kevinveenbirkenbachandClaude Opus 5
549d272884
Seven lookups read application_id out of the play's variables and every one of them has to template it, because sys-stk-full defines application_id from sys_stk_full_application_id and a dict read returns that unrendered. They did it in five spellings: a public resolve_var, two byte-identical private copies, and inline variants. Nothing named the rule, so it survived as folklore, and a lookup written without knowing it took down three jobs of one run. resolve_var now lives in utils/templating, which is where the six lookups that import it can reach it without pulling in a networking module for a concern that is not networking. utils/networks/lookup_context re-exports it under the alias form, so its own importers are untouched and autodoc still resolves one target. The two private copies go, and so does the fourth copy this branch added to webserver_resource a few commits ago. The private copies guarded value is not None and the public one did not. The canonical keeps the guard: it is narrower than every live caller, each of which passes a defaulted value, so no existing call can reach the branch. The helper had no test at all. Its six behaviours are characterised first, including that a templar raising on an undefined variable leaves the value alone rather than failing the play, which is what the suppression is for. Four inline copies stay. compose_volumes lets a template error propagate where this suppresses it, and mcp_servers only templates a str containing a template marker. Folding those in would change behaviour, which is not a refactor. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Templating Utilities 🧩
Strict Jinja renderers used by lookup plugins, library modules, and the YAML cache layer.
Scope 📋
Modules in utils/templating/ MUST limit themselves to rendering {{ ... }} and {% ... %} constructs found in YAML values, lookups, and templated config strings.
Both renderers fail loudly when Jinja markers cannot be resolved so generated configs never silently leak unrendered placeholders.
Modules 📦
| Module | Engine | When to use |
|---|---|---|
| ansible.py | Ansible's internal Templar (with TrustedAsTemplate tagging for Ansible 2.19+) |
When the caller already has Ansible's variable stack and wants tag-aware rendering with shortcuts for lookup('env', ...), simple var.path lookups, and literal coercion. |
| jinja.py | Standalone jinja2.Environment |
When the caller runs in a context where Templar can silently leave markers untouched (some lookup plugin entry points). Renders multiple passes so nested vars (A.x = "{{ B.y }}", B.y = "{{ C.z }}") collapse fully. |
Example Imports ✍️
from utils.templating.ansible import render_ansible_strict
from utils.templating.jinja import render_strict