Files
computer-playbook/tests/unit/python/plugins/lookup/test_backup_volume.py
T
kevinveenbirkenbachandClaude Opus 5 e8e89d293d refactor(seaweedfs): split the object store from its browser consoles
web-app-seaweedfs becomes two roles. web-svc-seaweedfs keeps the storage
engine: the container, the seaweedfs_data volume, the per-consumer S3
identities and the single canonical domain api. web-app-seaweedfs-console
takes the filer and master web UIs into its own compose stack behind the
admin-only oauth2 proxy, reaching the engine over the shared object-store
network. A node can now run the store without the consoles.

The console needs a distinct role name because get_entity_name strips the
category prefix: both halves would have resolved to the entity seaweedfs and
collided on the compose project, the instance directory and the container
name.

The filer and master ports move into the engine's services.seaweedfs.ports
.internal as their single owner; 01_init_consumer.yml consumes the master
port and would otherwise have resolved it only by role-var leakage from the
console, breaking bucket provisioning on exactly the console-less node the
split makes possible.

The engine's api vhost gains the prometheus locations. It never had them: the
override satisfied the cross-cutting-include lint only because the strings sat
in the SSO branch that the api domain never took.

Consumers, the objstore lookup and the catalogs follow the role id.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-10-01 02:20:12 +02:00

228 lines
8.3 KiB
Python

import importlib.util
import unittest
import unittest.mock as mock
from types import ModuleType
from typing import ClassVar
from . import PROJECT_ROOT
def _load_module() -> ModuleType:
plugin_path = (
PROJECT_ROOT
/ "roles"
/ "svc-bkp-volume-2-local"
/ "lookup_plugins"
/ "backup_volume.py"
)
spec = importlib.util.spec_from_file_location("backup_volume", plugin_path)
module = importlib.util.module_from_spec(spec)
assert spec.loader is not None
spec.loader.exec_module(module)
return module
def _run(
module: ModuleType,
applications: dict,
variables: dict | None = None,
templar: object | None = None,
) -> list[str]:
loader = mock.MagicMock()
loader.get.return_value.run.return_value = [applications]
with mock.patch.object(module, "lookup_loader", loader):
plugin = module.LookupModule()
if templar is not None:
plugin._templar = templar
return plugin.run(None, variables=variables or {})[0]
class TestBackupVolumeLookup(unittest.TestCase):
@classmethod
def setUpClass(cls) -> None:
cls._module = _load_module()
def test_only_backup_false_is_emitted(self) -> None:
apps = {
"web-app-matrix": {
"volumes": {
"mdad_docker": {"name": "matrix_mdad_docker", "backup": False},
"mdad_matrix": {"name": "matrix_mdad_matrix"},
"mdad_state": {"name": "matrix_mdad_state", "backup": True},
}
}
}
self.assertEqual(_run(type(self)._module, apps), ["matrix_mdad_docker"])
def test_the_pinned_docker_name_wins_over_the_semantic_key(self) -> None:
apps = {"r": {"volumes": {"semantic": {"name": "pinned", "backup": False}}}}
self.assertEqual(_run(type(self)._module, apps), ["pinned"])
def test_a_nameless_entry_falls_back_to_its_key(self) -> None:
apps = {"r": {"volumes": {"semantic": {"backup": False}}}}
self.assertEqual(_run(type(self)._module, apps), ["semantic"])
def test_names_are_deduplicated_and_sorted(self) -> None:
apps = {
"a": {"volumes": {"v": {"name": "zeta", "backup": False}}},
"b": {"volumes": {"v": {"name": "zeta", "backup": False}}},
"c": {"volumes": {"v": {"name": "alpha", "backup": False}}},
}
self.assertEqual(_run(type(self)._module, apps), ["alpha", "zeta"])
def test_an_app_without_volumes_is_skipped(self) -> None:
apps = {"a": {"services": {}}, "b": {"volumes": None}}
self.assertEqual(_run(type(self)._module, apps), [])
def test_a_truthy_string_is_not_treated_as_an_opt_out(self) -> None:
apps = {"r": {"volumes": {"v": {"name": "kept", "backup": "false"}}}}
self.assertEqual(_run(type(self)._module, apps), [])
class TestSwarmNfsExclusion(unittest.TestCase):
"""In swarm mode with NFS storage the export host's repo captures the
NFS-backed volumes, so the volume backup must skip them; manager-pinned
roles keep node-local volumes and stay covered here."""
SWARM_NFS: ClassVar[dict] = {
"DEPLOYMENT_MODE": "swarm",
"IS_COMPOSE_MODE": False,
"IS_SWARM_MODE": True,
"storage": {"backend": "nfs"},
"groups": {"svc-bkp-nfs-2-local": ["nfs-server"]},
}
@classmethod
def setUpClass(cls) -> None:
cls._module = _load_module()
def test_nfs_backed_volumes_are_excluded_in_swarm(self) -> None:
apps = {
"web-app-nextcloud": {
"volumes": {"data": {"name": "nextcloud_data"}},
},
"web-svc-seaweedfs": {
"volumes": {"data": {"name": "seaweedfs_data"}},
},
}
self.assertEqual(
_run(type(self)._module, apps, variables=dict(self.SWARM_NFS)),
["nextcloud_data"],
)
def test_compose_mode_excludes_nothing(self) -> None:
apps = {"web-app-nextcloud": {"volumes": {"data": {"name": "nextcloud_data"}}}}
self.assertEqual(
_run(
type(self)._module,
apps,
variables={"DEPLOYMENT_MODE": "compose", "storage": {"backend": "nfs"}},
),
[],
)
def test_an_nfs_opt_out_stays_covered(self) -> None:
apps = {
"web-app-nextcloud": {
"volumes": {"data": {"name": "kept_local", "nfs": False}},
}
}
self.assertEqual(
_run(type(self)._module, apps, variables=dict(self.SWARM_NFS)), []
)
def test_the_deployment_mode_expression_is_templated(self) -> None:
"""group_vars/all/18_swarm.yml defines DEPLOYMENT_MODE as a Jinja
expression, so the raw value never equals 'swarm'. Comparing it
unrendered silently disables the whole exclusion."""
expression = (
"{{ 'swarm' if (groups['svc-swarm-node'] | default([]) | length) > 1"
" else 'compose' }}"
)
rendered = {expression: "swarm"}
templar = mock.Mock()
templar.template.side_effect = lambda value: rendered.get(value, value)
apps = {"web-app-nextcloud": {"volumes": {"data": {"name": "nextcloud_data"}}}}
self.assertEqual(
_run(
type(self)._module,
apps,
variables={**self.SWARM_NFS, "DEPLOYMENT_MODE": expression},
templar=templar,
),
["nextcloud_data"],
)
def test_a_role_forcing_compose_keeps_its_volumes_covered(self) -> None:
"""compose_mode_force overrides the cluster mode for ONE role. The
lookup answers for every role at once, so an ambient value must not
exclude a role that is not on the export - web-app-bigbluebutton runs
compose-mode in a swarm cluster and its volumes stay node-local."""
apps = {
"web-app-bigbluebutton": {
"volumes": {"database": {"name": "bigbluebutton_database"}},
},
"web-app-nextcloud": {
"volumes": {"data": {"name": "nextcloud_data"}},
},
}
self.assertEqual(
_run(
type(self)._module,
apps,
variables={
"compose_mode_force": "compose",
**dict(self.SWARM_NFS),
},
),
["nextcloud_data"],
)
def test_without_the_export_repo_nothing_is_excluded(self) -> None:
"""svc-bkp-nfs-2-local enters a play by inventory group membership
alone, and svc-storage-nfs-server ships a variant that runs without
it. Excluding on storage.backend alone would leave those volumes with
no capture at all."""
apps = {"web-app-nextcloud": {"volumes": {"data": {"name": "nextcloud_data"}}}}
variables = {k: v for k, v in self.SWARM_NFS.items() if k != "groups"}
self.assertEqual(_run(type(self)._module, apps, variables=variables), [])
def test_an_empty_export_repo_group_does_not_exclude(self) -> None:
apps = {"web-app-nextcloud": {"volumes": {"data": {"name": "nextcloud_data"}}}}
variables = {**self.SWARM_NFS, "groups": {"svc-bkp-nfs-2-local": []}}
self.assertEqual(_run(type(self)._module, apps, variables=variables), [])
def test_a_config_entry_is_never_excluded_by_the_nfs_rule(self) -> None:
apps = {
"web-app-nextcloud": {
"volumes": {
"loader": {"name": "nc_loader", "type": "config"},
"data": {"name": "nextcloud_data"},
}
}
}
self.assertEqual(
_run(type(self)._module, apps, variables=dict(self.SWARM_NFS)),
["nextcloud_data"],
)
def test_backup_false_still_excludes_without_swarm(self) -> None:
apps = {"r": {"volumes": {"v": {"name": "gone", "backup": False}}}}
self.assertEqual(
_run(
type(self)._module,
apps,
variables={
"DEPLOYMENT_MODE": "compose",
"IS_COMPOSE_MODE": True,
"IS_SWARM_MODE": False,
"storage": {"backend": "local"},
},
),
["gone"],
)
if __name__ == "__main__":
unittest.main()