mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-11 13:17:07 +00:00
kevinveenbirkenbachandClaude Opus 4.7
dcd84754f0
Adds six more rule families to the strict ruleset: - ``T10`` — committed ``breakpoint()`` / ``pdb`` calls - ``PGH`` — pygrep-hooks (blanket ``# type: ignore`` without code) - ``EXE`` — shebang/executable-bit consistency - ``RSE`` — ``raise X()`` style cleanups - ``ICN`` — standard import aliases - ``DTZ`` — tz-naive ``datetime`` bugs Fixes (99 violations cleared) ============================= EXE001 (68): every file with a Python shebang now has the executable bit set. Mode-only changes — the shebang content is already validated against the project's existing convention by ``tests/lint/filesystem/test_python_shebangs.py`` (``#\!/usr/bin/env python3`` for portable scripts, ``#\!/usr/bin/python`` for Ansible custom modules in ``library/``). PGH003 (17): removed blanket ``# type: ignore`` markers. The project doesn't run mypy/pyright in CI, so these were decoration only. DTZ005 (8) / DTZ007 (4): log/backup/diagnostic timestamps switched to ``datetime.now(tz=timezone.utc)`` so cross-host log correlation doesn't depend on each host's local TZ. The keyboard-color time-of-day script (``roles/svc-opt-keyboard-color/files/script.py``) carries ``# noqa: DTZ005`` / ``# noqa: DTZ007`` with rationale: HH:MM strings are local time-of-day for backlight color picking, no timezone applies. The OpenSSL date parser in ``utils/cert_utils.py`` anchors the parsed naive datetime to UTC explicitly via ``.replace(tzinfo=UTC)`` (openssl always emits the literal "GMT"). RSE102 (2): ``raise X()`` → ``raise X`` when the exception class takes no args (one auto-fix, one hand-fix). Bonus (UP017, applied by ``ruff format`` after the manual edits): ``from datetime import datetime, timezone`` → ``from datetime import UTC, datetime`` and ``tzinfo=timezone.utc`` → ``tzinfo=UTC`` (Python 3.11+ shorthand). Verification ============ - ``ruff check .`` → All checks passed - ``ruff format --check .`` → 894 files formatted - 1621 unit tests → all pass - Integration suite: 44 baseline failures, 1 skipped (unchanged) 86 files changed, +55 / −37 content lines, plus 68 mode-only changes (``chmod +x``). Combined with the prior strict-rule commits the branch satisfies 17 ruff rule families end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
51 lines
1.7 KiB
Python
Executable File
51 lines
1.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
import unittest
|
|
|
|
from utils.cert_utils import CertUtils
|
|
|
|
|
|
class TestCertUtilsMatches(unittest.TestCase):
|
|
def setUp(self):
|
|
# prepare your test cases
|
|
self.tests = [
|
|
# Exact matches
|
|
("example.com", "example.com", True),
|
|
("www.example.com", "www.example.com", True),
|
|
("api.example.com", "api.example.com", True),
|
|
# Wildcard matches
|
|
("sub.example.com", "*.example.com", True),
|
|
("www.example.com", "*.example.com", True),
|
|
# Wildcard non-matches
|
|
("example.com", "*.example.com", False), # base domain is not covered
|
|
("deep.sub.example.com", "*.example.com", False), # too deep
|
|
(
|
|
"sub.deep.example.com",
|
|
"*.deep.example.com",
|
|
True,
|
|
), # correct: one level below
|
|
# Special cases
|
|
("deep.api.example.com", "*.api.example.com", True),
|
|
(
|
|
"api.example.com",
|
|
"*.api.example.com",
|
|
False,
|
|
), # base not covered by wildcard
|
|
# Completely different domains
|
|
("test.other.com", "*.example.com", False),
|
|
]
|
|
|
|
def test_matches(self):
|
|
for domain, san, expected in self.tests:
|
|
with self.subTest(domain=domain, san=san):
|
|
result = CertUtils.matches(domain, san)
|
|
self.assertEqual(
|
|
result,
|
|
expected,
|
|
msg=f"CertUtils.matches({domain!r}, {san!r}) returned {result}, expected {expected}",
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|