0 Fork 0

mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2026-11-08 11:46:35 +00:00

Files

T

kevinveenbirkenbachandClaude Opus 4.8 d9a53a0545 chore(lint): pin ruff to 0.16.0 and resolve the rules that version enforces

The ruff toolchain was unpinned, so host venvs, the lint container and CI
installed different releases over time. That drift is why lint-python only
failed on CI: locally ruff 0.15.x preview-gated ISC004/FURB192 and (falsely)
fired S310 on urllib.request.Request, while CI's 0.16.0 has ISC004/FURB192
stable and drops the S310-on-Request false positive.

Pin ruff==0.16.0 in pyproject.toml's dev extras (Dependabot keeps it current)
and have utils.install.lint.ruff read that pin and reinstall whenever the
found version drifts, so every environment resolves the same ruff. Then fix
what 0.16.0 flags: parenthesise the implicit string concatenations (ISC004),
use min() over sorted()[0] (FURB192), drop the now-unused S310 noqa on the
Request() builders (RUF100), and delete the narration comments that the
comment lint surfaces in the touched files.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-23 23:08:26 +02:00

lint

chore(lint): pin ruff to 0.16.0 and resolve the rules that version enforces

2026-07-23 23:08:26 +02:00

__init__.py

…

github_release.py

fix(install): cap urlopen with explicit timeouts in install-lint helpers

2026-05-21 14:55:10 +02:00

npm.py

…

pip.py

…

primitives.py

fix(install): cap urlopen with explicit timeouts in install-lint helpers

2026-05-21 14:55:10 +02:00

README.md

chore(lint): drop galaxy-importer lint

2026-05-20 20:40:34 +02:00

system_pkg.py

feat(readme): role README generator with Cosmos diagrams, Quick Setup, and lint

2026-07-17 14:44:33 +02:00

README.md

utils/install

This directory hosts the Python implementation behind make install-lint. For the general rules that govern READMEs in code directories see documentation.md.

Purpose

The package installs the lint toolchain (actionlint, shfmt, ruff, ansible-lint, mbake, markdownlint-cli2, eslint, shellcheck, ansible-playbook, ansible-galaxy) using the right channel per tool (system package manager, pip, npm, or GitHub release). Modules at this level are channel-agnostic primitives; per-tool policy lives one level down in lint/.

Structure

File	Role
`primitives.py`	Logging, sudo wrapping, PATH mutation, and stdlib-based URL download.
`pip.py`	Venv-aware pip installer with `--break-system-packages` and `--user` fallback.
`npm.py`	Global / local npm install with per-user `--prefix` fallback.
`github_release.py`	Latest-tag resolver and asset downloader for GitHub releases.
`system_pkg.py`	Per-manager dispatch for `pacman` / `apt-get` / `dnf` / `yum` / `brew`.
`lint/`	One module per tool, each exposing `ensure()`. See lint README.

The CLI entry point lives at __main__.py, invoked from lint.sh as python3 -m utils.install.lint. The matching dispatcher wrapper.sh routes make install-lint host vs container based on INFINITO_LINT_RUNNER.

File Naming

Module names MUST stay lowercase snake_case.
Channel-agnostic helpers MUST live directly under utils/install/.
Per-tool policy (one tool per file) MUST live under lint/ (see lint README).
Test files live in tests/unit/utils/install/ and mirror the module name with a test_ prefix.

Import Rules

primitives.py MUST NOT import from any other module in this package.
pip.py, npm.py, github_release.py, and system_pkg.py MAY import from primitives.py.
npm.py MAY import from system_pkg.py to bootstrap npm itself; no other cross-imports between these four are allowed.
Per-tool modules under lint/ MUST NOT import each other (see lint README).