Files
computer-playbook/tests/unit/python/utils/packages/test_plan.py
T
kevinveenbirkenbachandClaude Opus 5 75a2726389 feat(packages): install from Flathub where no distro package exists
An empty distro entry made package_install return skipped, so the role
deployed and the binary was simply missing. Blender#0 showed the shape:
'blender declare nothing to install on centos', then 'blender
--background' with rc 2 and no output at all.

A flatpak source closes the largest group of those gaps in one
mechanism. It takes application ids, installs the runtime and the
Flathub remote first, and links flatpak.command onto PATH -- without
that link the export is named after the application id, so a role
calling the plain binary still finds nothing and the fix would look
applied while changing nothing.

Roughly fifty entries move across, every id verified against Flathub's
appstream API rather than guessed; four candidates were wrong and did
not survive that check. The external probe now asks Flathub for a
flatpak entry instead of the distribution index, so the same
verification runs on every sweep.

jrnl and msi-perkeyrgb have no package anywhere and install from PyPI
instead: the task registers package_install and falls back to
sys-pip-install only 'when: ... is skipped', which keeps the registry
the single source of the per-distro decision rather than copying it
into the role.

The entries that legitimately install nothing keep their nocheck and
lose the deferral: the myhostname module ships inside systemd, the
kernel server inside nfs-utils, wine carries its own mono and gecko. A
new rule holds that line -- a justification may explain why nothing is
installed, but may no longer park the install behind a TODO. Twelve
gaps still fail it and stay red until each has a mechanism.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-10-23 02:09:32 +02:00

259 lines
9.6 KiB
Python

import re
import unittest
from utils.packages.calls import STATE_ABSENT, STATE_PRESENT
from utils.packages.plan import build_plan
from utils.packages.schema import (
SOURCE_AUR,
SOURCE_BUILD,
SOURCE_COPR,
SOURCE_FLATPAK,
PackageSpec,
)
from utils.packages.sources import (
AUR_BUILDER_USER,
FLATPAK_COMMAND_DIR,
FLATPAK_EXPORT_DIR,
PACMAN_CONF,
)
class TestExternalFetchRetries(unittest.TestCase):
"""Every call that fetches over the network carries a retry policy, the
distribution's own repositories included: their mirror pools degrade
independently of whatever retries the package manager does internally."""
def _retried(self, plan):
return {call.module for call in plan if call.retry is not None}
def test_the_aur_build_is_retried(self):
plan = build_plan(
PackageSpec(("nfs-ganesha",), source=SOURCE_AUR), STATE_PRESENT
)
self.assertEqual(
self._retried(plan), {"kewlfft.aur.aur", "ansible.builtin.package"}
)
def test_the_build_command_is_retried(self):
spec = PackageSpec(("tool",), source=SOURCE_BUILD, build={"command": "make"})
self.assertEqual(
self._retried(build_plan(spec, STATE_PRESENT)),
{"ansible.builtin.command", "ansible.builtin.package"},
)
def test_enabling_a_copr_is_retried(self):
spec = PackageSpec(("pkg",), source=SOURCE_COPR, repo={"copr": "user/proj"})
self.assertEqual(
self._retried(build_plan(spec, STATE_PRESENT)),
{"community.general.copr", "ansible.builtin.package"},
)
def test_adding_a_ppa_is_retried(self):
spec = PackageSpec(("pkg",), repo={"ppa": "ppa:x/y"})
self.assertEqual(
self._retried(build_plan(spec, STATE_PRESENT)),
{"ansible.builtin.apt_repository", "ansible.builtin.package"},
)
def test_a_plain_repository_install_is_retried(self):
plan = build_plan(PackageSpec(("git",)), STATE_PRESENT)
self.assertEqual(self._retried(plan), {"ansible.builtin.package"})
def _modules(plan):
return [call.module for call in plan]
class TestBuildPlan(unittest.TestCase):
def test_plain_repo_is_a_single_call(self):
plan = build_plan(PackageSpec(("git",)), STATE_PRESENT)
self.assertEqual(_modules(plan), ["ansible.builtin.package"])
self.assertEqual(plan[0].args["state"], STATE_PRESENT)
def test_empty_names_produce_no_calls(self):
self.assertEqual(build_plan(PackageSpec(()), STATE_PRESENT), [])
def test_absent_never_needs_the_source(self):
spec = PackageSpec(("nfs-ganesha",), source="aur")
plan = build_plan(spec, STATE_ABSENT)
self.assertEqual(_modules(plan), ["ansible.builtin.package"])
self.assertEqual(plan[0].args["state"], STATE_ABSENT)
def test_aur_bootstraps_a_build_user_then_builds(self):
plan = build_plan(PackageSpec(("nfs-ganesha",), source="aur"), STATE_PRESENT)
self.assertEqual(
_modules(plan),
[
"ansible.builtin.package",
"ansible.builtin.user",
"ansible.builtin.lineinfile",
"kewlfft.aur.aur",
],
)
self.assertEqual(plan[-1].become_user, AUR_BUILDER_USER)
def test_copr_enables_before_installing(self):
spec = PackageSpec(("foo",), source="copr", repo={"copr": "user/project"})
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(
_modules(plan), ["community.general.copr", "ansible.builtin.package"]
)
def test_ppa_adds_the_repository_before_installing(self):
spec = PackageSpec(("foo",), source="ppa", repo={"ppa": "ppa:user/foo"})
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(
_modules(plan),
["ansible.builtin.apt_repository", "ansible.builtin.package"],
)
def test_copr_without_repo_raises(self):
with self.assertRaises(ValueError):
build_plan(PackageSpec(("foo",), source="copr"), STATE_PRESENT)
def test_build_installs_depends_then_runs_the_command(self):
spec = PackageSpec(
("foo",),
source="build",
build={
"command": "make install",
"depends": ["gcc"],
"creates": "/usr/bin/foo",
},
)
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(
_modules(plan), ["ansible.builtin.package", "ansible.builtin.command"]
)
self.assertEqual(plan[1].args["cmd"], "make install")
def test_build_without_block_raises(self):
with self.assertRaises(ValueError):
build_plan(PackageSpec(("foo",), source="build"), STATE_PRESENT)
def test_bootstrap_package_repo_installs_the_enabler_first(self):
spec = PackageSpec(("micro",), repo={"bootstrap_package": "epel-release"})
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(plan[0].args["name"], ["epel-release"])
self.assertEqual(plan[1].args["name"], ["micro"])
def test_enable_existing_uses_dnf_with_the_repo(self):
spec = PackageSpec(
("libntirpc",),
repo={"enable_existing": "updates-testing", "state": "latest"},
)
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(_modules(plan), ["ansible.builtin.dnf"])
self.assertEqual(plan[0].args["enablerepo"], "updates-testing")
def test_pacman_section_is_uncommented_before_the_install(self):
spec = PackageSpec(("steam",), repo={"pacman_section": "multilib"})
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(
_modules(plan), ["ansible.builtin.replace", "community.general.pacman"]
)
self.assertEqual(plan[0].args["path"], PACMAN_CONF)
self.assertIn("multilib", plan[0].args["regexp"])
self.assertTrue(plan[1].args["update_cache"])
self.assertEqual(plan[1].args["name"], ["steam"])
def test_pacman_section_regex_matches_the_stock_pacman_conf(self):
spec = PackageSpec(("steam",), repo={"pacman_section": "multilib"})
call = build_plan(spec, STATE_PRESENT)[0]
stock = "#[multilib]\n#Include = /etc/pacman.d/mirrorlist\n"
enabled = re.sub(
call.args["regexp"],
call.args["replace"].replace("\\n", "\n"),
stock,
flags=re.MULTILINE,
)
self.assertEqual(enabled, "[multilib]\nInclude = /etc/pacman.d/mirrorlist\n")
self.assertEqual(
re.sub(
call.args["regexp"],
call.args["replace"].replace("\\n", "\n"),
enabled,
flags=re.MULTILINE,
),
enabled,
)
def test_externally_managed_repo_only_installs(self):
spec = PackageSpec(("docker-ce",), repo={"managed_externally": "role does it"})
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(_modules(plan), ["ansible.builtin.package"])
def test_full_repo_definition_is_rendered_first(self):
spec = PackageSpec(
("nfs-ganesha",),
repo={
"name": "sig",
"description": "SIG",
"baseurl": "https://example/",
"gpgkey": "https://example/key",
},
)
plan = build_plan(spec, STATE_PRESENT)
self.assertEqual(
_modules(plan),
["ansible.builtin.yum_repository", "ansible.builtin.package"],
)
class TestFlatpakSource(unittest.TestCase):
"""A Flatpak id is installed from a remote and exposed under the name the
role actually invokes."""
def test_the_runtime_and_remote_come_before_the_application(self):
spec = PackageSpec(("org.blender.Blender",), source=SOURCE_FLATPAK)
self.assertEqual(
_modules(build_plan(spec, STATE_PRESENT)),
[
"ansible.builtin.package",
"community.general.flatpak_remote",
"community.general.flatpak",
],
)
def test_a_declared_command_is_linked_onto_the_path(self):
spec = PackageSpec(
("org.blender.Blender",),
source=SOURCE_FLATPAK,
flatpak={"command": "blender"},
)
link = build_plan(spec, STATE_PRESENT)[-1]
self.assertEqual(link.module, "ansible.builtin.file")
self.assertEqual(link.args["state"], "link")
self.assertEqual(link.args["dest"], f"{FLATPAK_COMMAND_DIR}/blender")
self.assertEqual(link.args["src"], f"{FLATPAK_EXPORT_DIR}/org.blender.Blender")
def test_without_a_command_nothing_is_linked(self):
spec = PackageSpec(("org.blender.Blender",), source=SOURCE_FLATPAK)
self.assertNotIn(
"ansible.builtin.file", _modules(build_plan(spec, STATE_PRESENT))
)
def test_the_remote_and_the_install_are_retried(self):
spec = PackageSpec(("org.blender.Blender",), source=SOURCE_FLATPAK)
retried = {
call.module for call in build_plan(spec, STATE_PRESENT) if call.retry
}
self.assertEqual(
retried,
{
"ansible.builtin.package",
"community.general.flatpak_remote",
"community.general.flatpak",
},
)
def test_removal_goes_through_the_host_manager(self):
spec = PackageSpec(("org.blender.Blender",), source=SOURCE_FLATPAK)
self.assertEqual(
_modules(build_plan(spec, STATE_ABSENT)), ["ansible.builtin.package"]
)
if __name__ == "__main__":
unittest.main()