mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
57 lines
1.9 KiB
Python
57 lines
1.9 KiB
Python
from __future__ import annotations
|
|
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from plugins.lookup.command_path import LookupModule
|
|
|
|
|
|
class TestCommandPathLookup(unittest.TestCase):
|
|
def setUp(self):
|
|
self.plugin = LookupModule()
|
|
|
|
def test_requires_at_least_one_term(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.plugin.run([])
|
|
|
|
def test_resolves_single_command(self):
|
|
with patch(
|
|
"plugins.lookup.command_path.shutil.which",
|
|
return_value="/usr/local/bin/gitcon",
|
|
):
|
|
out = self.plugin.run(["gitcon"])
|
|
self.assertEqual(out, ["/usr/local/bin/gitcon"])
|
|
|
|
def test_resolves_multiple_commands(self):
|
|
def _fake_which(cmd, path=None):
|
|
return f"/usr/local/bin/{cmd}"
|
|
|
|
with patch("plugins.lookup.command_path.shutil.which", side_effect=_fake_which):
|
|
out = self.plugin.run(["baudolo", "baudolo-seed"])
|
|
self.assertEqual(out, ["/usr/local/bin/baudolo", "/usr/local/bin/baudolo-seed"])
|
|
|
|
def test_rejects_whitespace_command(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.plugin.run(["setup-hibernate --help"])
|
|
|
|
def test_missing_command_raises(self):
|
|
with (
|
|
patch("plugins.lookup.command_path.shutil.which", return_value=None),
|
|
self.assertRaises(AnsibleError),
|
|
):
|
|
self.plugin.run(["does-not-exist"])
|
|
|
|
def test_custom_path_argument_is_passed_to_which(self):
|
|
with patch(
|
|
"plugins.lookup.command_path.shutil.which", return_value="/custom/bin/tool"
|
|
) as which:
|
|
out = self.plugin.run(["tool"], path="/custom/bin:/usr/bin")
|
|
self.assertEqual(out, ["/custom/bin/tool"])
|
|
which.assert_called_once_with("tool", path="/custom/bin:/usr/bin")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|