0 Fork 0

mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2026-11-11 13:17:07 +00:00

Files

T

kevinveenbirkenbachandClaude Opus 5 3136110ccf fix(test): install the PHP extensions PHPUnit requires

ensure_php_toolchain installed the php and composer binaries and stopped
there. A distro ships the interpreter and its extensions as separate
packages, and ensure_command_present returns early once shutil.which
finds php - which it always does since the image bakes the interpreter -
so the extensions were never provisioned on any path.

composer then refused to resolve the vendor tree with
"phpunit/phpunit requires ext-dom * -> it is missing from your system"
and test-unit-php failed in every workspace job. The loaded ini list in
those logs shows 20-mbstring.ini present and no 20-dom.ini, 20-xml.ini
or 20-xmlwriter.ini, i.e. php-xml missing.

Extensions are now probed against php -m and installed from a per-manager
mapping, then re-probed so a package that does not deliver the extension
raises instead of leaving composer to fail later. The loop sits in
ensure_php_toolchain because both entry points pass through it: the image
build via utils.install.interpreters and the test run via
scripts/install/php.sh, so a prebuilt image is repaired at test time.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-23 04:31:56 +02:00

lint

…

__init__.py

…

github_release.py

…

interpreters.py

feat(image): bake the php and ruby interpreters into the image

2026-08-22 20:56:55 +02:00

node.py

fix(test): install php and ruby instead of skipping their suites

2026-08-22 20:30:40 +02:00

npm.py

…

php.py

fix(test): install the PHP extensions PHPUnit requires

2026-08-23 04:31:56 +02:00

pip.py

…

primitives.py

…

README.md

…

ruby.py

fix(test): install php and ruby instead of skipping their suites

2026-08-22 20:30:40 +02:00

system_pkg.py

fix(test): install the PHP extensions PHPUnit requires

2026-08-23 04:31:56 +02:00

README.md

utils/install

This directory hosts the Python implementation behind make install-lint. For the general rules that govern READMEs in code directories see documentation.md.

Purpose

The package installs the lint toolchain (actionlint, shfmt, ruff, ansible-lint, mbake, markdownlint-cli2, eslint, shellcheck, ansible-playbook, ansible-galaxy) using the right channel per tool (system package manager, pip, npm, or GitHub release). Modules at this level are channel-agnostic primitives; per-tool policy lives one level down in lint/.

Structure

File	Role
`primitives.py`	Logging, sudo wrapping, PATH mutation, and stdlib-based URL download.
`pip.py`	Venv-aware pip installer with `--break-system-packages` and `--user` fallback.
`npm.py`	Global / local npm install with per-user `--prefix` fallback.
`github_release.py`	Latest-tag resolver and asset downloader for GitHub releases.
`system_pkg.py`	Per-manager dispatch for `pacman` / `apt-get` / `dnf` / `yum` / `brew`.
`lint/`	One module per tool, each exposing `ensure()`. See lint README.

The CLI entry point lives at __main__.py, invoked from lint.sh as python3 -m utils.install.lint. The matching dispatcher wrapper.sh routes make install-lint host vs container based on INFINITO_LINT_RUNNER.

File Naming

Module names MUST stay lowercase snake_case.
Channel-agnostic helpers MUST live directly under utils/install/.
Per-tool policy (one tool per file) MUST live under lint/ (see lint README).
Test files live in tests/unit/python/utils/install/ and mirror the module name with a test_ prefix.

Import Rules

primitives.py MUST NOT import from any other module in this package.
pip.py, npm.py, github_release.py, and system_pkg.py MAY import from primitives.py.
npm.py MAY import from system_pkg.py to bootstrap npm itself; no other cross-imports between these four are allowed.
Per-tool modules under lint/ MUST NOT import each other (see lint README).