0 Fork 0

mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2026-11-08 11:46:35 +00:00

Files

T

kevinveenbirkenbachandClaude Opus 5 86f7d8c4f5 fix(install): keep the collection check inside the slice that runs it

The image runs this module from a layer that holds three files of utils:
__init__.py, install/__init__.py and install/collections.py, the slice
ef45d69dc3 cut so the source tree cannot invalidate the collection install.
67f5398985 established that the module therefore stays on the standard
library, and d4ae5cf9f0 broke it 15 minutes later by routing the reads
through utils.cache.files to satisfy the cache-read lint. The import raises
ModuleNotFoundError: No module named 'utils.cache' in that layer, which no
import inside a full checkout can show, because this repository installs
utils into site-packages.

Nothing turned red. The caller reads only the exit code, and the module's
contract is exit 1 with the missing collections on stdout, so a crash - exit
1, nothing on stdout - is indistinguishable from work to do. Every image
build since has reinstalled every collection with --force-with-deps, which
is the cost the check exists to avoid. The deploy job the traceback was
found in finished green.

The reads go back to Path.read_text with a cache-read marker each. The cache
was never earning its place here: read_text is an lru_cache keyed on the
path, and one run reads the requirements file once and one MANIFEST.json per
collection, eight distinct paths, none of them twice. Copying utils/cache
into the slice instead would work - the closure is three stdlib-only files -
but it binds a package with 51 commits in the last twelve months to the
layer that installs ansible, in front of a cache with no possible hit.

The caller now exits 3 when a non-zero status arrives with an empty stdout,
a state the contract cannot produce, so the next crash stops the install
instead of quietly reinstalling everything. all.sh runs under set -e and
touches the stamp only after ansible.sh returns, so the failure also leaves
the stamp stale rather than recording an install that did not happen.

The probe that would have caught this builds the slice in a tempdir from the
Dockerfile's own COPY lines and runs the module inside it. It has to pass
python -S: without it the interpreter resolves every submodule from the
installed checkout however the slice is built, and the test passes on a
module that cannot import in the image. Verified by injecting the import
back into the tempdir copy, which reproduces the traceback verbatim.

Delta measured by loading the committed module and this one side by side:
identical on both requirements files, against the real collections directory
and an empty one, on a missing file, on non-UTF-8 input and on a corrupt
MANIFEST.json. The one behavioural difference is that a file changed within
a process is now read fresh rather than from the memo.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-09-18 03:03:37 +02:00

lint

feat(install): pin the collections and stop refetching what is already there

2026-09-16 20:38:50 +02:00

__init__.py

…

collections.py

fix(install): keep the collection check inside the slice that runs it

2026-09-18 03:03:37 +02:00

github_release.py

…

interpreters.py

feat(image): bake the php and ruby interpreters into the image

2026-08-22 20:56:55 +02:00

node.py

…

npm.py

…

php.py

fix(test): resolve the PHP vendor tree against a declared floor

2026-09-09 02:15:56 +02:00

pip.py

…

primitives.py

…

README.md

…

ruby.py

…

system_pkg.py

fix(install): refresh the apt index once before giving up on a package

2026-09-12 10:00:08 +02:00

README.md

utils/install

This directory hosts the Python implementation behind make install-lint. For the general rules that govern READMEs in code directories see documentation.md.

Purpose

The package installs the lint toolchain (actionlint, shfmt, ruff, ansible-lint, mbake, markdownlint-cli2, eslint, shellcheck, ansible-playbook, ansible-galaxy) using the right channel per tool (system package manager, pip, npm, or GitHub release). Modules at this level are channel-agnostic primitives; per-tool policy lives one level down in lint/.

Structure

File	Role
`primitives.py`	Logging, sudo wrapping, PATH mutation, and stdlib-based URL download.
`pip.py`	Venv-aware pip installer with `--break-system-packages` and `--user` fallback.
`npm.py`	Global / local npm install with per-user `--prefix` fallback.
`github_release.py`	Latest-tag resolver and asset downloader for GitHub releases.
`system_pkg.py`	Per-manager dispatch for `pacman` / `apt-get` / `dnf` / `yum` / `brew`.
`lint/`	One module per tool, each exposing `ensure()`. See lint README.

The CLI entry point lives at __main__.py, invoked from lint.sh as python3 -m utils.install.lint. The matching dispatcher wrapper.sh routes make install-lint host vs container based on INFINITO_LINT_RUNNER.

File Naming

Module names MUST stay lowercase snake_case.
Channel-agnostic helpers MUST live directly under utils/install/.
Per-tool policy (one tool per file) MUST live under lint/ (see lint README).
Test files live in tests/unit/python/utils/install/ and mirror the module name with a test_ prefix.

Import Rules

primitives.py MUST NOT import from any other module in this package.
pip.py, npm.py, github_release.py, and system_pkg.py MAY import from primitives.py.
npm.py MAY import from system_pkg.py to bootstrap npm itself; no other cross-imports between these four are allowed.
Per-tool modules under lint/ MUST NOT import each other (see lint README).