mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
100 lines
3.4 KiB
Python
100 lines
3.4 KiB
Python
import unittest
|
|
import unittest.mock as mock
|
|
from types import SimpleNamespace
|
|
|
|
from utils.storage import constrained
|
|
from utils.storage.constrained import is_constrained, required_storage_bytes
|
|
|
|
_GIB = 1024**3
|
|
_USAGE = SimpleNamespace(free=123 * _GIB)
|
|
|
|
|
|
class TestIsConstrained(unittest.TestCase):
|
|
def test_need_above_free_is_constrained(self):
|
|
self.assertTrue(
|
|
is_constrained(free_bytes=122 * _GIB, required_bytes=381 * _GIB)
|
|
)
|
|
|
|
def test_need_equal_to_free_fits(self):
|
|
self.assertFalse(
|
|
is_constrained(free_bytes=100 * _GIB, required_bytes=100 * _GIB)
|
|
)
|
|
|
|
def test_need_below_free_fits(self):
|
|
self.assertFalse(
|
|
is_constrained(free_bytes=300 * _GIB, required_bytes=113 * _GIB)
|
|
)
|
|
|
|
def test_undeclared_need_never_constrains(self):
|
|
self.assertFalse(is_constrained(free_bytes=1, required_bytes=0))
|
|
|
|
|
|
class TestRequiredStorageBytes(unittest.TestCase):
|
|
def test_unknown_role_declares_nothing(self):
|
|
self.assertEqual(required_storage_bytes(["web-app-does-not-exist"]), 0)
|
|
|
|
def test_empty_selection_declares_nothing(self):
|
|
self.assertEqual(required_storage_bytes([]), 0)
|
|
|
|
def test_a_real_role_declares_a_positive_need(self):
|
|
self.assertGreater(required_storage_bytes(["svc-db-mariadb"]), 0)
|
|
|
|
def test_dependencies_are_counted_once_across_apps(self):
|
|
single = required_storage_bytes(["svc-db-mariadb"])
|
|
twice = required_storage_bytes(["svc-db-mariadb", "svc-db-mariadb"])
|
|
self.assertEqual(single, twice)
|
|
|
|
|
|
class TestDockerRootFreeBytes(unittest.TestCase):
|
|
"""The daemon reports its data root in ITS namespace, which need not be ours.
|
|
|
|
A caller running inside a container of that daemon sees a path that does not
|
|
resolve, which used to raise FileNotFoundError out of shutil.disk_usage and
|
|
abort the nested swarm drill of every workspace job.
|
|
"""
|
|
|
|
def test_resolvable_root_is_measured_directly(self):
|
|
with (
|
|
mock.patch.object(constrained, "docker_data_root", return_value="/"),
|
|
mock.patch.object(
|
|
constrained.shutil, "disk_usage", return_value=_USAGE
|
|
) as usage,
|
|
):
|
|
self.assertEqual(
|
|
constrained.docker_root_free_bytes(local_vantage="/nonexistent"),
|
|
_USAGE.free,
|
|
)
|
|
usage.assert_called_once_with("/")
|
|
|
|
def test_unresolvable_root_falls_to_the_local_vantage(self):
|
|
with (
|
|
mock.patch.object(
|
|
constrained, "docker_data_root", return_value="/var/lib/docker-absent"
|
|
),
|
|
mock.patch.object(
|
|
constrained.shutil, "disk_usage", return_value=_USAGE
|
|
) as usage,
|
|
):
|
|
self.assertEqual(
|
|
constrained.docker_root_free_bytes(local_vantage="/"),
|
|
_USAGE.free,
|
|
)
|
|
usage.assert_called_once_with("/")
|
|
|
|
def test_unreachable_daemon_still_raises(self):
|
|
with (
|
|
mock.patch.object(
|
|
constrained, "docker_data_root", side_effect=RuntimeError("no daemon")
|
|
),
|
|
self.assertRaises(RuntimeError),
|
|
):
|
|
constrained.docker_root_free_bytes(local_vantage="/")
|
|
|
|
def test_local_vantage_has_no_default(self):
|
|
with self.assertRaises(TypeError):
|
|
constrained.docker_root_free_bytes()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|