mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-09 12:17:13 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
106 lines
3.5 KiB
Python
Executable File
106 lines
3.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
import contextlib
|
|
import importlib.util
|
|
import io
|
|
import sys
|
|
from types import SimpleNamespace
|
|
from unittest import TestCase, main, mock
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
|
|
def load_target_module():
|
|
repo_root = PROJECT_ROOT
|
|
script_path = (
|
|
repo_root
|
|
/ "roles"
|
|
/ "sys-ctl-hlth-disc-space"
|
|
/ "files"
|
|
/ "python"
|
|
/ "script.py"
|
|
)
|
|
|
|
if not script_path.is_file():
|
|
raise FileNotFoundError(f"Target script not found at: {script_path}")
|
|
|
|
spec = importlib.util.spec_from_file_location("target_script", script_path)
|
|
module = importlib.util.module_from_spec(spec)
|
|
assert spec and spec.loader
|
|
spec.loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
SCRIPT_MODULE = load_target_module()
|
|
|
|
|
|
class TestDiskSpaceScript(TestCase):
|
|
def test_get_disk_usage_percentages_parses_output(self):
|
|
fake_df_output = "Use%\n 10%\n 50%\n100%\n"
|
|
|
|
with mock.patch.object(
|
|
SCRIPT_MODULE.subprocess,
|
|
"run",
|
|
return_value=SimpleNamespace(stdout=fake_df_output, returncode=0),
|
|
):
|
|
result = SCRIPT_MODULE.get_disk_usage_percentages()
|
|
|
|
self.assertEqual(result, [10, 50, 100])
|
|
|
|
def test_main_exits_zero_when_below_threshold(self):
|
|
df_print_cp = SimpleNamespace(stdout="Filesystem ...\n", returncode=0)
|
|
df_pcent_cp = SimpleNamespace(stdout="Use%\n 10%\n 50%\n 80%\n", returncode=0)
|
|
|
|
def fake_run(args, capture_output=False, text=False, check=False):
|
|
if args == ["df", "--output=pcent"]:
|
|
return df_pcent_cp
|
|
if args == ["df"]:
|
|
return df_print_cp
|
|
raise AssertionError(f"Unexpected subprocess.run args: {args}")
|
|
|
|
with (
|
|
mock.patch.object(SCRIPT_MODULE.subprocess, "run", side_effect=fake_run),
|
|
mock.patch.object(sys, "argv", ["script.py", "80"]),
|
|
mock.patch.object(
|
|
SCRIPT_MODULE.sys, "exit", side_effect=SystemExit
|
|
) as mock_exit,
|
|
contextlib.redirect_stdout(io.StringIO()),
|
|
self.assertRaises(SystemExit),
|
|
):
|
|
SCRIPT_MODULE.main()
|
|
|
|
mock_exit.assert_called_once_with(0)
|
|
|
|
def test_main_exits_with_error_count_and_prints_warnings(self):
|
|
df_print_cp = SimpleNamespace(stdout="Filesystem ...\n", returncode=0)
|
|
df_pcent_cp = SimpleNamespace(stdout="Use%\n 60%\n 90%\n 95%\n", returncode=0)
|
|
|
|
def fake_run(args, capture_output=False, text=False, check=False):
|
|
if args == ["df", "--output=pcent"]:
|
|
return df_pcent_cp
|
|
if args == ["df"]:
|
|
return df_print_cp
|
|
raise AssertionError(f"Unexpected subprocess.run args: {args}")
|
|
|
|
with (
|
|
mock.patch.object(SCRIPT_MODULE.subprocess, "run", side_effect=fake_run),
|
|
mock.patch.object(sys, "argv", ["script.py", "80"]),
|
|
mock.patch.object(
|
|
SCRIPT_MODULE.sys, "exit", side_effect=SystemExit
|
|
) as mock_exit,
|
|
):
|
|
buffer = io.StringIO()
|
|
with contextlib.redirect_stdout(buffer), self.assertRaises(SystemExit):
|
|
SCRIPT_MODULE.main()
|
|
|
|
mock_exit.assert_called_once_with(2)
|
|
|
|
output = buffer.getvalue()
|
|
self.assertIn("Checking disk space usage...", output)
|
|
self.assertIn("WARNING: 90% exceeds the limit of 80%.", output)
|
|
self.assertIn("WARNING: 95% exceeds the limit of 80%.", output)
|
|
self.assertNotIn("60% exceeds the limit of 80%.", output)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|