mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 03:38:23 +00:00
TC (flake8-type-checking): typing-only imports moved into
``if TYPE_CHECKING:`` blocks across 8 source files via auto-fix
(117 hits). Reduces runtime import surface and rules out circular
imports for type-only deps. Project-wide ``from __future__ import
annotations`` (FA, already enabled) keeps annotations as strings,
so the moved imports never need to load at runtime.
N (pep8-naming): 32 hits handled.
Renames (semantic + lint):
- ``isSmallerThenMaximumBackupSize`` -> ``is_larger_than_maximum_backup_size``
(snake_case + fixes both the typo "Then -> Than" and the
semantic mismatch: the function returns ``current > maximum``)
- ``isDirectoryDeletable`` / ``deleteVersion`` /
``getAmountOfIteration`` / ``deleteIteration`` -> snake_case
- 8 test functions with ALL-CAPS env-var fragments
(``test_..._DOMAIN_PRIMARY_...`` etc.) -> snake_case
- Mock alias ``VH`` -> ``vh`` in test_host_vars.py
Exception class renames (``N818`` Error suffix):
- ``TimeLimitExceededException`` -> ``TimeLimitExceededError``
- ``AttemptException`` -> ``AttemptError``
- ``PathNotFound`` -> ``PathNotFoundError`` (propagated across
4 callers under tests/integration/lookups/config/)
- ``_ExitJson`` / ``_FailJson`` -> ``*_Error``
Refactor:
- ``METADATA = {...}`` local constant in two functions of
``plugins/filter/invokable_paths.py`` lifted to module-level
``_METADATA_KEYS``.
- ``from typing import TYPE_CHECKING`` in
``tasks/utils/migrate_meta_layout/__main__.py`` moved above
the ``sys.path.insert`` hack to satisfy E402 (collateral from
the TC auto-fix that landed it after the path mutation).
Per-file ignores in pyproject.toml for the legitimate cases the
rule cannot accept:
- ``pull-specific-host.py`` -> ``N999`` (Ansible-invoked role-level
script, hyphenated filename pinned by the surrounding stack).
- 4 matrix-deploy files -> ``N806`` for the ``include_R`` /
``raw_include_R`` round-index notation; the uppercase ``R``
here mirrors the formula in the docstring rather than naming
a constant.
- ``plugins/filter/value_generator.py`` -> ``N806`` for the
lazy-loaded class binding ``ValueGenerator =
_value_generator_cls()``, which retains the imported class
identifier per PEP 8.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
141 lines
4.4 KiB
Python
141 lines
4.4 KiB
Python
"""Unified suppression markers for infinito-nexus tests.
|
|
|
|
A single grammar covers every per-line, per-block, and per-file
|
|
opt-out across the test suite. See
|
|
``docs/contributing/actions/testing/suppression.md`` for the catalog
|
|
of valid rule keys, their placement, and the test that consumes each.
|
|
|
|
Grammar
|
|
=======
|
|
|
|
<comment-prefix> (noqa|nocheck): <rule>(\\s*,\\s*<rule>)*
|
|
|
|
Accepted comment prefixes:
|
|
|
|
* ``#`` (Python, YAML, shell, conf, INI, …)
|
|
* ``//`` (JS, JSONC, …)
|
|
* ``{# … #}`` (Jinja2)
|
|
* ``<!-- … -->`` (HTML, Markdown)
|
|
|
|
``noqa`` and ``nocheck`` are accepted as synonyms (case-insensitive)
|
|
by this parser. By repo convention every project rule from
|
|
``docs/contributing/actions/testing/suppression.md`` MUST use
|
|
``nocheck:`` because ``# noqa: <code>`` is also parsed by ruff as a
|
|
flake8 directive and triggers ``invalid-noqa-code`` warnings on every
|
|
project-specific rule key. ``noqa:`` is reserved for real flake8 / ruff
|
|
codes (``E402``, ``F401``, …). The ``direct-yaml`` lint enforces the
|
|
convention by hard-rejecting the ``noqa:`` form.
|
|
|
|
Multiple rules may be combined on one comment, comma-separated:
|
|
|
|
# nocheck: shared, email
|
|
# nocheck: url, docker-version
|
|
|
|
Position semantics are per-rule and listed in the catalog page. This
|
|
module exposes three resolvers:
|
|
|
|
* :func:`is_suppressed_at`: same line, line above, or either.
|
|
* :func:`is_suppressed_in_head`: anywhere in the first N lines
|
|
(file-level opt-outs).
|
|
* :func:`is_suppressed_anywhere`: anywhere in the file (used by the
|
|
run-once schema check).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from typing import TYPE_CHECKING
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Sequence
|
|
|
|
_KEYWORD_RE = re.compile(
|
|
r"(?:noqa|nocheck)\s*:\s*([a-z0-9][a-z0-9\-]*(?:\s*,\s*[a-z0-9][a-z0-9\-]*)*)",
|
|
re.IGNORECASE,
|
|
)
|
|
|
|
|
|
def _rules_on_line(line: str) -> set[str]:
|
|
"""Return the set of rule keys present in suppression markers on *line*."""
|
|
found: set[str] = set()
|
|
for match in _KEYWORD_RE.finditer(line):
|
|
for raw_rule in match.group(1).split(","):
|
|
rule = raw_rule.strip().lower()
|
|
if rule:
|
|
found.add(rule)
|
|
return found
|
|
|
|
|
|
def line_has_rule(line: str, rule: str) -> bool:
|
|
"""Return True iff *line* carries a marker for *rule*."""
|
|
return rule.lower() in _rules_on_line(line)
|
|
|
|
|
|
def is_suppressed_at(
|
|
lines: Sequence[str],
|
|
line_no: int,
|
|
rule: str,
|
|
*,
|
|
mode: str = "same-or-above",
|
|
) -> bool:
|
|
"""Check whether the construct at 1-based *line_no* is suppressed.
|
|
|
|
``mode`` selects placement semantics:
|
|
|
|
* ``"same-line"``: marker must be on the construct's line.
|
|
* ``"line-above"``: marker must be on the immediately preceding
|
|
non-empty line. Blank lines between marker and construct break
|
|
the association.
|
|
* ``"same-or-above"`` (default): either of the above.
|
|
"""
|
|
if line_no < 1 or line_no > len(lines):
|
|
return False
|
|
|
|
rule = rule.lower()
|
|
|
|
if mode in ("same-line", "same-or-above") and line_has_rule(
|
|
lines[line_no - 1], rule
|
|
):
|
|
return True
|
|
|
|
if mode in ("line-above", "same-or-above"):
|
|
prev = line_no - 2
|
|
while prev >= 0 and not lines[prev].strip():
|
|
prev -= 1
|
|
if prev >= 0 and line_has_rule(lines[prev], rule):
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def is_suppressed_in_head(
|
|
lines: Sequence[str],
|
|
rule: str,
|
|
*,
|
|
scan_lines: int = 30,
|
|
) -> bool:
|
|
"""Return True iff *rule* appears in the first *scan_lines* lines.
|
|
|
|
File-level opt-outs (e.g. ``file-size``) MUST live near the top of
|
|
the file so the cost of carrying the exemption stays visible.
|
|
"""
|
|
rule = rule.lower()
|
|
return any(line_has_rule(line, rule) for line in lines[:scan_lines])
|
|
|
|
|
|
def is_suppressed_anywhere(lines: Sequence[str], rule: str) -> bool:
|
|
"""Return True iff *rule* appears on any line of *lines*.
|
|
|
|
Used for whole-file opt-outs whose semantics legitimately apply to
|
|
the entire file regardless of where the marker sits (e.g.
|
|
``run-once`` on roles that are intentionally executed every play).
|
|
"""
|
|
rule = rule.lower()
|
|
return any(line_has_rule(line, rule) for line in lines)
|
|
|
|
|
|
def suppressed_line_numbers(lines: Sequence[str], rule: str) -> set[int]:
|
|
"""Return the set of 1-based line numbers carrying a marker for *rule*."""
|
|
rule = rule.lower()
|
|
return {idx for idx, line in enumerate(lines, start=1) if line_has_rule(line, rule)}
|