mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-09 20:26:33 +00:00
kevinveenbirkenbachandClaude Opus 5
d6d7ff8c9e
Four libretranslate jobs in run 37173067619 failed with failed to solve: ghcr.io/…/mirror/docker.io/libretranslate/libretranslate:v1.9.6-cuda: not found svc-ai-libretranslate-engine and web-svc-libretranslate append '-cuda' to the version in vars/main.yml when the gpu flag is set. iter_role_images is the only enumeration the mirror pipeline sees and it reads image and version alone, so the derived tag was never a candidate for mirroring and resolved against a registry that has no such tag. Upstream does publish it: Docker Hub answers 200 for v1.9.6-cuda, the mirror 404. The suffixes are now declared next to the version they extend, and discovery yields a ref per suffix. A suffix rather than a full tag keeps the version number in one place when it is bumped. The gpu flag is static: it is set in meta/services.yml, no inventory overrides it, and resource_filter reads configuration rather than hardware. Every host therefore takes the cuda path today, which is why all four jobs failed rather than some. Rejected: mirror_policy: skip, which has no users in this repository and would route these two images around the mirror to Docker Hub permanently, reintroducing the rate limit the mirror exists to avoid. Also rejected: baking '-cuda' into version, which fixes the mirror but removes the GPU switch. The test pins both halves; without the discovery change its two variant cases fail and its two base cases still pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
56 lines
2.0 KiB
Python
56 lines
2.0 KiB
Python
from __future__ import annotations
|
|
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from utils.docker.image.discovery import iter_role_images
|
|
from utils.roles.mapping import ROLE_FILE_META_SERVICES
|
|
|
|
BASE = """---
|
|
engine:
|
|
image: libretranslate/libretranslate
|
|
version: v1.9.6
|
|
"""
|
|
|
|
WITH_VARIANTS = """---
|
|
engine:
|
|
image: libretranslate/libretranslate
|
|
version: v1.9.6
|
|
version_variants:
|
|
- "-cuda"
|
|
"""
|
|
|
|
|
|
class TestImageDiscoveryVersionVariants(unittest.TestCase):
|
|
def _versions(self, services_yaml: str) -> set[str]:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
services = Path(tmp) / "roles" / "svc-demo" / ROLE_FILE_META_SERVICES
|
|
services.parent.mkdir(parents=True)
|
|
services.write_text(services_yaml, encoding="utf-8")
|
|
return {ref.version for ref in iter_role_images(Path(tmp))}
|
|
|
|
def test_a_role_without_variants_yields_only_the_declared_version(self) -> None:
|
|
self.assertEqual({"v1.9.6"}, self._versions(BASE))
|
|
|
|
def test_each_variant_suffix_yields_its_own_ref(self) -> None:
|
|
self.assertEqual({"v1.9.6", "v1.9.6-cuda"}, self._versions(WITH_VARIANTS))
|
|
|
|
def test_the_variant_ref_carries_the_derived_pull_source(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
services = Path(tmp) / "roles" / "svc-demo" / ROLE_FILE_META_SERVICES
|
|
services.parent.mkdir(parents=True)
|
|
services.write_text(WITH_VARIANTS, encoding="utf-8")
|
|
sources = {ref.source for ref in iter_role_images(Path(tmp))}
|
|
|
|
self.assertIn("docker.io/libretranslate/libretranslate:v1.9.6-cuda", sources)
|
|
|
|
def test_blank_and_non_list_variants_are_ignored(self) -> None:
|
|
for declaration in (' version_variants: "-cuda"\n', " version_variants:\n - ' '\n"):
|
|
with self.subTest(declaration=declaration):
|
|
self.assertEqual({"v1.9.6"}, self._versions(BASE + declaration))
|
|
|
|
|
|
if __name__ == "__main__": # pragma: no cover
|
|
unittest.main()
|