Files
computer-playbook/plugins/lookup/unit_name.py
T
kevinveenbirkenbachandClaude Opus 5.5 ef246a6e03 refactor(unit_name): build unit names from SYS_SERVICE_VERSION_SUFFIX
The lookup assembled '.<version>.<software domain>' itself, a second copy of the infix the unlock and prune phases now read from the SPOT. It reads SYS_SERVICE_VERSION_SUFFIX instead and refuses one that does not start with a dot or carries an empty segment. The direct version-plugin fallback goes with it: it existed because the plugin rendered the untrusted literal "{{ lookup('version') }}", while the SPOT arrives as a trusted group_vars string. Every unit name rendered from group_vars is byte-identical before and after.

The timer description names the versioned service it starts instead of the legacy unversioned name.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 23:34:13 +02:00

141 lines
4.5 KiB
Python

# Ansible lookup plugin to build versioned systemd unit names.
#
# Target format:
# <service_name>.<version>.<software_domain><suffix>
#
# Examples:
# lookup('unit_name', 'svc-foo') -> svc-foo.1.2.3.infinito.nexus.service
# lookup('unit_name', 'sys-ctl-cln-bkps') -> cln-bkps.1.2.3.infinito.nexus.service
# lookup('unit_name', 'svc-foo', suffix='.timer') -> svc-foo.1.2.3.infinito.nexus.timer
# lookup('unit_name', 'alarm@') -> alarm.1.2.3.infinito.nexus@.service
#
# Requirements:
# - SYS_SERVICE_VERSION_SUFFIX (group_vars/all/06_daemons.yml) must be available in vars.
from __future__ import annotations
from ansible.errors import AnsibleError
from ansible.plugins.lookup import LookupBase
def _looks_like_template(value) -> bool:
if not isinstance(value, str):
return False
return ("{{" in value) or ("{%" in value) or ("{#" in value)
def _render_if_template(templar, value, var_name: str):
if not _looks_like_template(value):
return value
try:
rendered = templar.template(value)
except TypeError:
rendered = templar.template(value)
except Exception as exc:
raise AnsibleError(
f"unit_name lookup: failed to render template for '{var_name}': {value}"
) from exc
if _looks_like_template(rendered):
raise AnsibleError(
f"unit_name lookup: unresolved template for '{var_name}': {value}"
)
return rendered
def _normalize_suffix(suffix) -> str:
"""
Normalize suffix input to a systemd unit suffix string:
- None / "" -> ".service"
- False -> "" (no suffix)
- "service" -> ".service"
- ".timer" -> ".timer"
"""
if suffix is False:
return ""
if suffix is None or str(suffix).strip() == "":
return ".service"
sfx = str(suffix).strip().lower()
if not sfx.startswith("."):
sfx = "." + sfx
return sfx
def _lower_required(value, name: str) -> str:
if value is None:
raise AnsibleError(
f"unit_name lookup: missing required variable '{name}' (is None)."
)
sval = str(value).strip()
if not sval:
raise AnsibleError(
f"unit_name lookup: missing required variable '{name}' (empty)."
)
if _looks_like_template(sval):
raise AnsibleError(
f"unit_name lookup: unresolved template for '{name}': {sval}"
)
return sval.lower()
def _strip_sys_ctl_prefix(systemctl_id: str) -> str:
prefix = "sys-ctl-"
if systemctl_id.startswith(prefix):
return systemctl_id[len(prefix) :]
return systemctl_id
def _build_unit_name(systemctl_id: str, version_suffix: str, suffix) -> str:
sid = _strip_sys_ctl_prefix(_lower_required(systemctl_id, "systemctl_id"))
if not sid:
raise AnsibleError(
"unit_name lookup: normalized systemctl_id is empty after stripping prefix."
)
sfx = _normalize_suffix(suffix)
if sid.endswith("@"):
return f"{sid[:-1]}{version_suffix}@{sfx}"
return f"{sid}{version_suffix}{sfx}"
class LookupModule(LookupBase):
"""
Lookup plugin entrypoint.
Usage:
- "{{ lookup('unit_name', system_service_id) }}"
- "{{ lookup('unit_name', system_service_id, suffix='.timer') }}"
- "{{ lookup('unit_name', system_service_id, suffix=False) }}" # no suffix
"""
def run(self, terms, variables=None, **kwargs):
self.set_options(var_options=variables, direct=kwargs)
if not terms:
raise AnsibleError(
"unit_name lookup: at least one term (systemctl_id) is required."
)
available = getattr(self._templar, "available_variables", {}) or {}
version_suffix = available.get("SYS_SERVICE_VERSION_SUFFIX")
if not version_suffix:
raise AnsibleError(
"unit_name lookup: SYS_SERVICE_VERSION_SUFFIX is not defined in the variable context."
)
version_suffix = _lower_required(
_render_if_template(
self._templar, version_suffix, "SYS_SERVICE_VERSION_SUFFIX"
),
"SYS_SERVICE_VERSION_SUFFIX",
)
if not version_suffix.startswith(".") or "" in version_suffix[1:].split("."):
raise AnsibleError(
f"unit_name lookup: SYS_SERVICE_VERSION_SUFFIX must read '.<version>.<domain>', got '{version_suffix}'."
)
suffix = kwargs.get("suffix")
return [_build_unit_name(term, version_suffix, suffix) for term in terms]