mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
93 lines
2.7 KiB
Python
93 lines
2.7 KiB
Python
import importlib
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
|
|
class TestVersionLookup(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
try:
|
|
cls.plugin_module = importlib.import_module("plugins.lookup.version")
|
|
cls.LookupModule = cls.plugin_module.LookupModule
|
|
except ModuleNotFoundError as exc:
|
|
raise unittest.SkipTest(
|
|
"Could not import lookup plugin 'plugins.lookup.version'. "
|
|
"Make sure tests run with repo root on PYTHONPATH."
|
|
) from exc
|
|
except Exception as exc:
|
|
raise unittest.SkipTest(f"Failed importing lookup plugin: {exc}") from exc
|
|
|
|
# Ensure ansible is importable (plugin depends on it)
|
|
try:
|
|
import ansible # noqa: F401
|
|
except Exception as exc:
|
|
raise unittest.SkipTest(
|
|
f"Ansible not available for unit tests: {exc}"
|
|
) from exc
|
|
|
|
def _run_with_repo_layout(self, pyproject_content: str | None):
|
|
"""
|
|
Creates a temporary repo-like layout:
|
|
<tmp>/pyproject.toml (optional)
|
|
Then executes the lookup plugin with PROJECT_ROOT pointing at <tmp>.
|
|
"""
|
|
plugin_mod = self.plugin_module
|
|
original_root = plugin_mod.PROJECT_ROOT
|
|
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
if pyproject_content is not None:
|
|
pyproject_path = str(Path(tmp) / "pyproject.toml")
|
|
with Path(pyproject_path).open("w", encoding="utf-8") as f:
|
|
f.write(pyproject_content)
|
|
|
|
plugin_mod.PROJECT_ROOT = Path(tmp)
|
|
|
|
try:
|
|
plugin = self.LookupModule()
|
|
return plugin.run([])
|
|
finally:
|
|
plugin_mod.PROJECT_ROOT = original_root
|
|
|
|
def test_reads_project_version(self):
|
|
result = self._run_with_repo_layout(
|
|
"""
|
|
[project]
|
|
name = "demo"
|
|
version = "1.2.3"
|
|
"""
|
|
)
|
|
self.assertEqual(result, ["1.2.3"])
|
|
|
|
def test_falls_back_to_poetry_version(self):
|
|
result = self._run_with_repo_layout(
|
|
"""
|
|
[tool.poetry]
|
|
name = "demo"
|
|
version = "2.3.4"
|
|
"""
|
|
)
|
|
self.assertEqual(result, ["2.3.4"])
|
|
|
|
def test_missing_pyproject_raises(self):
|
|
from ansible.errors import AnsibleError
|
|
|
|
with self.assertRaises(AnsibleError):
|
|
self._run_with_repo_layout(pyproject_content=None)
|
|
|
|
def test_missing_version_raises(self):
|
|
from ansible.errors import AnsibleError
|
|
|
|
with self.assertRaises(AnsibleError):
|
|
self._run_with_repo_layout(
|
|
"""
|
|
[project]
|
|
name = "demo"
|
|
# no version here
|
|
"""
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|