mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
TC (flake8-type-checking): typing-only imports moved into
``if TYPE_CHECKING:`` blocks across 8 source files via auto-fix
(117 hits). Reduces runtime import surface and rules out circular
imports for type-only deps. Project-wide ``from __future__ import
annotations`` (FA, already enabled) keeps annotations as strings,
so the moved imports never need to load at runtime.
N (pep8-naming): 32 hits handled.
Renames (semantic + lint):
- ``isSmallerThenMaximumBackupSize`` -> ``is_larger_than_maximum_backup_size``
(snake_case + fixes both the typo "Then -> Than" and the
semantic mismatch: the function returns ``current > maximum``)
- ``isDirectoryDeletable`` / ``deleteVersion`` /
``getAmountOfIteration`` / ``deleteIteration`` -> snake_case
- 8 test functions with ALL-CAPS env-var fragments
(``test_..._DOMAIN_PRIMARY_...`` etc.) -> snake_case
- Mock alias ``VH`` -> ``vh`` in test_host_vars.py
Exception class renames (``N818`` Error suffix):
- ``TimeLimitExceededException`` -> ``TimeLimitExceededError``
- ``AttemptException`` -> ``AttemptError``
- ``PathNotFound`` -> ``PathNotFoundError`` (propagated across
4 callers under tests/integration/lookups/config/)
- ``_ExitJson`` / ``_FailJson`` -> ``*_Error``
Refactor:
- ``METADATA = {...}`` local constant in two functions of
``plugins/filter/invokable_paths.py`` lifted to module-level
``_METADATA_KEYS``.
- ``from typing import TYPE_CHECKING`` in
``tasks/utils/migrate_meta_layout/__main__.py`` moved above
the ``sys.path.insert`` hack to satisfy E402 (collateral from
the TC auto-fix that landed it after the path mutation).
Per-file ignores in pyproject.toml for the legitimate cases the
rule cannot accept:
- ``pull-specific-host.py`` -> ``N999`` (Ansible-invoked role-level
script, hyphenated filename pinned by the surrounding stack).
- 4 matrix-deploy files -> ``N806`` for the ``include_R`` /
``raw_include_R`` round-index notation; the uppercase ``R``
here mirrors the formula in the docstring rather than naming
a constant.
- ``plugins/filter/value_generator.py`` -> ``N806`` for the
lazy-loaded class binding ``ValueGenerator =
_value_generator_cls()``, which retains the imported class
identifier per PEP 8.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
184 lines
6.3 KiB
Python
184 lines
6.3 KiB
Python
"""Process-level cached filesystem helpers for project-tree scans.
|
|
|
|
Many integration/lint tests and CLI tools walk the whole repo and read every
|
|
matching file. Doing that N times per process is wasteful — the tree doesn't
|
|
change during a run. These helpers walk the tree once per process and memoise
|
|
both the path list and file contents, so every caller after the first one pays
|
|
near-zero cost.
|
|
|
|
Usage:
|
|
|
|
from utils.cache.files import iter_project_files, read_text
|
|
|
|
for path in iter_project_files(extensions=(".yml", ".yml.j2"), exclude_tests=True):
|
|
content = read_text(path)
|
|
...
|
|
|
|
`PROJECT_ROOT` is the repo root derived from this file's location.
|
|
|
|
Gitignore-filtered iteration
|
|
----------------------------
|
|
|
|
The matcher itself lives in :mod:`utils.cache.gitignore` (single SPOT for
|
|
``.gitignore`` parsing and matching). :func:`iter_non_ignored_files`
|
|
here composes the cached project walk with that matcher and is the
|
|
recommended helper for lint tests that want the "files git would track"
|
|
view without subprocessing.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from functools import lru_cache
|
|
from pathlib import Path
|
|
from typing import TYPE_CHECKING
|
|
|
|
from . import PROJECT_ROOT
|
|
from .gitignore import is_path_gitignored, load_gitignore_patterns
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Iterable, Iterator
|
|
|
|
# Directories never worth descending into during project-tree scans.
|
|
_DEFAULT_SKIP_DIRS: frozenset[str] = frozenset(
|
|
{
|
|
".git",
|
|
".cache",
|
|
".pytest_cache",
|
|
".ruff_cache",
|
|
".venv",
|
|
"venv",
|
|
"__pycache__",
|
|
"node_modules",
|
|
}
|
|
)
|
|
|
|
|
|
@lru_cache(maxsize=1)
|
|
def _all_project_files() -> tuple[str, ...]:
|
|
"""One-shot filesystem walk from PROJECT_ROOT.
|
|
|
|
Returns absolute paths as a tuple (immutable → safe to cache).
|
|
Pruned at walk-time by `_DEFAULT_SKIP_DIRS`, since those dirs are never
|
|
relevant for any project-tree test and descending into them is pure waste.
|
|
"""
|
|
root_str = str(PROJECT_ROOT)
|
|
paths: list[str] = []
|
|
for dirpath, dirnames, filenames in os.walk(root_str, topdown=True):
|
|
# prune in-place (topdown=True): stops descent into skipped dirs
|
|
dirnames[:] = [d for d in dirnames if d not in _DEFAULT_SKIP_DIRS]
|
|
paths.extend(str(Path(dirpath) / fn) for fn in filenames)
|
|
return tuple(paths)
|
|
|
|
|
|
def iter_project_files(
|
|
*,
|
|
extensions: Iterable[str] | None = None,
|
|
exclude_tests: bool = False,
|
|
exclude_dirs: Iterable[str] | None = None,
|
|
) -> Iterator[str]:
|
|
"""Yield absolute paths of project files matching the filter.
|
|
|
|
Args:
|
|
extensions: Suffix strings (e.g. ``(".yml", ".yaml.j2")``). Matching is
|
|
case-insensitive via plain string suffix. ``None`` yields all files.
|
|
exclude_tests: Skip everything under ``<root>/tests/``.
|
|
exclude_dirs: Additional top-level-or-nested directory names to skip.
|
|
Matched by path-component containment, not by prefix. E.g.
|
|
``exclude_dirs=("docs",)`` skips any file whose path contains a
|
|
``docs`` segment.
|
|
"""
|
|
all_files = _all_project_files()
|
|
tests_prefix = str(Path(str(PROJECT_ROOT)) / "tests") + os.sep
|
|
ext_lower = tuple(e.lower() for e in extensions) if extensions else None
|
|
exclude_dirs_set = set(exclude_dirs) if exclude_dirs else None
|
|
|
|
for path in all_files:
|
|
if exclude_tests and path.startswith(tests_prefix):
|
|
continue
|
|
if exclude_dirs_set is not None:
|
|
# Cheap path-segment check; avoids splitting the full path.
|
|
rel = os.path.relpath(path, str(PROJECT_ROOT))
|
|
if exclude_dirs_set.intersection(Path(rel).parts):
|
|
continue
|
|
if ext_lower is not None:
|
|
lower = path.lower()
|
|
if not any(lower.endswith(e) for e in ext_lower):
|
|
continue
|
|
yield path
|
|
|
|
|
|
@lru_cache(maxsize=8192)
|
|
def read_text(path: str) -> str:
|
|
"""Return the UTF-8 text content of a file; cached process-wide.
|
|
|
|
Raises OSError / UnicodeDecodeError unchanged — callers that scan arbitrary
|
|
files can wrap this in try/except if non-UTF-8 blobs may appear.
|
|
"""
|
|
with Path(path).open(encoding="utf-8") as f:
|
|
return f.read()
|
|
|
|
|
|
def iter_project_files_with_content(
|
|
*,
|
|
extensions: Iterable[str] | None = None,
|
|
exclude_tests: bool = False,
|
|
exclude_dirs: Iterable[str] | None = None,
|
|
) -> Iterator[tuple[str, str]]:
|
|
"""Yield ``(path, content)`` for matching files; content is cached.
|
|
|
|
Files that fail to read (permission errors, non-UTF-8) are silently
|
|
skipped — that matches the prior caller behaviour of wrapping
|
|
``open().read()`` in a bare ``try/except Exception: continue``.
|
|
"""
|
|
for path in iter_project_files(
|
|
extensions=extensions,
|
|
exclude_tests=exclude_tests,
|
|
exclude_dirs=exclude_dirs,
|
|
):
|
|
try:
|
|
content = read_text(path)
|
|
except (OSError, UnicodeDecodeError):
|
|
continue
|
|
yield path, content
|
|
|
|
|
|
def iter_non_ignored_files(
|
|
*,
|
|
extensions: Iterable[str] | None = None,
|
|
exclude_tests: bool = False,
|
|
exclude_dirs: Iterable[str] | None = None,
|
|
root: str | None = None,
|
|
) -> Iterator[str]:
|
|
"""Yield project files filtered through ``.gitignore``.
|
|
|
|
Combines :func:`iter_project_files` with :func:`is_path_gitignored`
|
|
so callers get the "files git would track" view without spawning a
|
|
git subprocess. ``root`` defaults to :data:`PROJECT_ROOT`.
|
|
|
|
A path is yielded iff it survives both the in-process skip-dir
|
|
pruning of :func:`iter_project_files` and the ``.gitignore`` match.
|
|
"""
|
|
base = Path(root) if root else PROJECT_ROOT
|
|
patterns = load_gitignore_patterns(str(base))
|
|
for path in iter_project_files(
|
|
extensions=extensions,
|
|
exclude_tests=exclude_tests,
|
|
exclude_dirs=exclude_dirs,
|
|
):
|
|
rel = os.path.relpath(path, str(base)).replace(os.sep, "/")
|
|
if is_path_gitignored(rel, patterns):
|
|
continue
|
|
yield path
|
|
|
|
|
|
def _reset() -> None:
|
|
"""Test-only helper: clear the project-walk and file-content caches.
|
|
|
|
Named ``_reset`` for parity with the per-domain reset helpers in
|
|
sibling modules; ``utils.cache._reset_cache_for_tests`` orchestrates
|
|
calls to all of them.
|
|
"""
|
|
_all_project_files.cache_clear()
|
|
read_text.cache_clear()
|