mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 4.7
a26bfc4e94
Module moves (with imports, paths, argv literals, scripts, docs, and
parents[N] formulas updated in lockstep):
- cli/deploy -> cli/administration/deploy
- cli/validate/inventory -> cli/administration/inventory/validate
- cli/vault -> cli/administration/secrets/vault
- cli/administration/inventory/encrypt -> cli/administration/secrets/seal
- cli/mirror -> cli/contributing/mirror
The new cli/administration/secrets cluster collocates the whole-file
ansible-vault wrapper next to the inventory-aware per-field sealer.
The user-facing CLI subcommand paths follow the package layout, e.g.
"infinito administration deploy dedicated <inv>" and
"infinito administration inventory validate <inv>".
Help system redesign in cli/core/{discovery,help,app}.py:
- Discovery now distinguishes runnable commands (directories with
__main__.py) from category folders (directories that only group
further commands). Empty support packages are filtered out.
- Each category folder MAY carry a README.md; its H1 heading is used
as the title and its first paragraph as the one-line description in
the help output.
- "infinito" / "infinito --help" prints only the top-level entries
(one level deep). "infinito <category>" navigates into a folder and
shows its sub-folders and commands one level deep, with the README
title as the page heading and the invocation as a dim subtitle.
- New "--tree [N]" flag walks the tree under the (optional) path
prefix recursively. N caps the depth (1-based); omit N for an
unbounded walk. The output uses Unicode tree connectors, an emoji
per entry (folder for categories, gear for commands), a globally
aligned description column, and multi-line wrapped descriptions
with tree-continuity bars on continuation lines.
- Category and command listings use the full invocation
("infinito meta callorder") rather than the bare leaf name, so the
output is copy-pasteable.
Convention doc + 17 CLI READMEs:
- New docs/contributing/artefact/files/cli/readme_md.md describes the
H1+paragraph layout the help system reads, and how it differs from
role/docs READMEs.
- README.md added for cli/{administration, build, contributing, meta}
and their immediate sub-folders, plus cli/meta/roles/applications
and its resolution sub-folder. Each follows the "title with trailing
emoji + single descriptive paragraph" convention.
Mirror resolver/sync description strings (the help system reads them
from argparse --help output) added so they no longer surface as
"options:" in the global index. cli/mirror/cleanup already had a
description and is unchanged.
Fixes uncovered by the move:
- import unittest.mock added to four dedicated-deploy tests so
unittest.mock.patch resolves under stdlib unittest discovery
(Python 3.13 no longer surfaces unittest.mock through "import
unittest" alone).
- parents[N] index in the new
cli/administration/inventory/validate/__init__.py corrected from
3 to 4 to match the deeper layout.
- test_paths.INVENTORY_VALIDATOR_PATH assertion and test_runner
substring assertions updated to match the new validator path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
92 lines
3.3 KiB
Python
92 lines
3.3 KiB
Python
"""Unit tests for Profile."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from cli.administration.deploy.development.profile import Profile
|
|
|
|
# Blank explicit signals; clear=True would unset PATH.
|
|
_BLANK_CI_ENV = {
|
|
"GITHUB_ACTIONS": "",
|
|
"RUNNING_ON_GITHUB": "",
|
|
"CI": "",
|
|
}
|
|
|
|
|
|
class TestProfileIsCI(unittest.TestCase):
|
|
@patch.dict(os.environ, _BLANK_CI_ENV, clear=False)
|
|
def test_is_ci_false_when_no_signals_set(self) -> None:
|
|
self.assertFalse(Profile().is_ci())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "GITHUB_ACTIONS": "true"}, clear=False)
|
|
def test_is_ci_true_when_github_actions_signal_set(self) -> None:
|
|
self.assertTrue(Profile().is_ci())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "RUNNING_ON_GITHUB": "true"}, clear=False)
|
|
def test_is_ci_true_when_running_on_github_signal_set(self) -> None:
|
|
self.assertTrue(Profile().is_ci())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "CI": "true"}, clear=False)
|
|
def test_is_ci_true_when_generic_ci_signal_set(self) -> None:
|
|
self.assertTrue(Profile().is_ci())
|
|
|
|
@patch.dict(
|
|
os.environ,
|
|
{**_BLANK_CI_ENV, "GITHUB_ACTIONS": "1"},
|
|
clear=False,
|
|
)
|
|
def test_is_ci_false_when_signal_value_is_one(self) -> None:
|
|
self.assertFalse(Profile().is_ci())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "GITHUB_ACTIONS": "false"}, clear=False)
|
|
def test_is_ci_false_when_signal_value_is_explicit_false(self) -> None:
|
|
self.assertFalse(Profile().is_ci())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "GITHUB_ACTIONS": "yes"}, clear=False)
|
|
def test_is_ci_false_when_signal_value_is_yes(self) -> None:
|
|
self.assertFalse(Profile().is_ci())
|
|
|
|
|
|
class TestProfileRegistryCacheActive(unittest.TestCase):
|
|
@patch.dict(os.environ, _BLANK_CI_ENV, clear=False)
|
|
def test_active_locally_when_no_ci_signal_set(self) -> None:
|
|
self.assertTrue(Profile().registry_cache_active())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "GITHUB_ACTIONS": "true"}, clear=False)
|
|
def test_inactive_under_github_actions(self) -> None:
|
|
self.assertFalse(Profile().registry_cache_active())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "CI": "true"}, clear=False)
|
|
def test_inactive_under_generic_ci_signal(self) -> None:
|
|
self.assertFalse(Profile().registry_cache_active())
|
|
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "RUNNING_ON_GITHUB": "true"}, clear=False)
|
|
def test_is_strict_inverse_of_is_ci(self) -> None:
|
|
p = Profile()
|
|
self.assertEqual(p.registry_cache_active(), not p.is_ci())
|
|
|
|
|
|
class TestProfileArgs(unittest.TestCase):
|
|
@patch.dict(os.environ, {**_BLANK_CI_ENV, "CI": "true"}, clear=False)
|
|
def test_args_ci_only_on_runner(self) -> None:
|
|
self.assertEqual(Profile().args(), ["--profile", "ci"])
|
|
|
|
@patch.dict(os.environ, _BLANK_CI_ENV, clear=False)
|
|
def test_args_returns_only_ci_profile_locally(self) -> None:
|
|
self.assertEqual(Profile().args(), ["--profile", "ci"])
|
|
|
|
@patch.dict(os.environ, _BLANK_CI_ENV, clear=False)
|
|
def test_args_returns_a_fresh_list_each_call(self) -> None:
|
|
# Callers may mutate the returned list.
|
|
p = Profile()
|
|
first = p.args()
|
|
first.append("--mutated")
|
|
self.assertNotIn("--mutated", p.args())
|
|
|
|
|
|
if __name__ == "__main__": # pragma: no cover
|
|
unittest.main()
|