mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
Add tests/lint/repository/test_inline_script_block_size.py: scans
roles/, tasks/, playbooks/ and .github/ YAML for literal block scalars
(`|` / `|-` / `|+`) following the keys `shell`, `command`, `script`,
`raw` (Ansible) and `run` (GitHub Actions). Counts logical lines —
trailing-`\` continuations collapse to one line, blank lines are
ignored — and fails when a block exceeds 12.
FOLDED scalars (`>` / `>-` / `>+`) are exempt: they are one shell
statement after YAML folding, even if they span many source lines for
readability.
The walk goes through `utils.cache.files.iter_project_files(...)` per
`docs/agents/action/testing.md` so the shared project-tree cache is
reused across the lint suite.
The fail message tells the author exactly how to fix: Ansible tasks
get the built-in `script:` module (collapses the task to one line);
GitHub Actions workflows extract into `scripts/github/<name>.sh` and
call it via `run: bash scripts/github/<name>.sh` (or
`_helpers/scripts/github/<name>.sh` when the workflow checks out the
repo into `_helpers/`).
Extract the pre-existing literal-block offenders so the new lint
ships green:
Ansible (script: module, file under <role>/files/)
web-app-friendica sync_addon.sh
web-app-fider create_admin_user.sh
web-app-fider configure_oidc_provider.sh
web-app-mediawiki install_or_update.sh
web-app-mediawiki composer_install_extension.sh
web-app-xwiki debug_superadmin.sh
GitHub Actions (scripts/github/)
pick_distro.sh
guard_release.sh
resolve_release_inputs.sh
disk_pressure_report.sh
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
38 lines
1.2 KiB
Bash
Executable File
38 lines
1.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Decide which distros the latest-push CI run should cover. If the
|
|
# pushed commit carries a `vX.Y.Z` annotated tag, run every distro in
|
|
# `ALL_DISTROS`; otherwise pick one at random. Emits both
|
|
# `is_version` and `distros` to GITHUB_OUTPUT.
|
|
#
|
|
# Usage:
|
|
# pick_distro.sh
|
|
# (reads GITHUB_SHA from env; writes to GITHUB_OUTPUT)
|
|
set -euo pipefail
|
|
|
|
ALL_DISTROS=(arch debian ubuntu fedora centos)
|
|
|
|
version_tag="$(
|
|
git tag --points-at "${GITHUB_SHA}" |
|
|
grep -E '^v[0-9]+(\.[0-9]+)*$' |
|
|
head -n 1 || true
|
|
)"
|
|
|
|
if [[ -n "$version_tag" ]]; then
|
|
echo "is_version=true" >>"$GITHUB_OUTPUT"
|
|
echo "version_tag=${version_tag}" >>"$GITHUB_OUTPUT"
|
|
distros="${ALL_DISTROS[*]}"
|
|
echo "🎯 Commit ${GITHUB_SHA} has version tag ${version_tag} → running ALL distros"
|
|
else
|
|
echo "is_version=false" >>"$GITHUB_OUTPUT"
|
|
echo "version_tag=" >>"$GITHUB_OUTPUT"
|
|
one="$(printf '%s\n' "${ALL_DISTROS[@]}" | shuf -n 1)"
|
|
distros="$one"
|
|
echo "🎲 No version tag on commit → picked distro: ${one}"
|
|
fi
|
|
|
|
echo "distros=${distros}" >>"$GITHUB_OUTPUT"
|
|
echo "=== Selected distros: ${distros} ==="
|
|
echo "=== is_version: $(grep -E '^is_version=' "$GITHUB_OUTPUT" | tail -n 1) ==="
|
|
echo "=== version_tag: $(grep -E '^version_tag=' "$GITHUB_OUTPUT" | tail -n 1) ==="
|