mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-11 21:26:44 +00:00
kevinveenbirkenbachandClaude Opus 5
d0937b0bb7
Three places where a data-root verdict was produced and then lost. report.sh matched `requested=[a-z]+`, which never matches `ext4`. Against the real deploy log of a run that recorded five ext4 verdicts, the old pattern yields 0 matches and the summary table was silently empty of them; the fixed pattern aggregates the same five into one row. docker_dataroot.sh wrote the reason only to GITHUB_STEP_SUMMARY, which is unset inside the lab node containers - so on exactly the machines that decline, the reason went nowhere. It now rides on the machine-readable report line too. This is what leaves the mariadb drill's decline reason unrecoverable from run 30781723102. resolve.sh's exclusions went to stderr only, i.e. into the deploy log rather than the job summary. The reason is emitted as a list below the table, not as a column: reasons embed per-node data (the pool name carries the hostname, plus the loop device), so folding them into the `sort | uniq -c` key would split one five-node row into five one-node rows exactly in the failure case the reason exists to explain. `reason=[^']*` keeps ansible's closing quote out of the value, and `|` is replaced so a reason cannot break the markdown table. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
107 lines
2.9 KiB
Bash
Executable File
107 lines
2.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Resolve which filesystem one matrix entry runs its docker data root on and
|
|
# record the decision for the steps that follow.
|
|
#
|
|
# A random pick draws from what this kernel serves, measured here, narrowed to
|
|
# what every distro of the entry carries a userland for. A stated pick is
|
|
# honoured even where it is unsupported, and the applying step then fails. The
|
|
# choice goes to the step summary, since reproducing a red run means re-stating
|
|
# it verbatim.
|
|
#
|
|
# Arguments:
|
|
# $1 STATED ext4 | btrfs | zfs; 'auto' or empty for a random pick
|
|
# $2 LABEL matrix entry the pick belongs to, e.g. compose/web-app-gitea
|
|
# $3 DISTROS space-separated distributions the entry deploys on
|
|
# $4 SCOPE node every distro in DISTROS must carry the userland too
|
|
# runner DISTROS is ignored; only the kernel decides
|
|
set -euo pipefail
|
|
|
|
STATED="${1:-}"
|
|
LABEL="${2:?usage: resolve.sh STATED LABEL DISTROS SCOPE}"
|
|
DISTROS="${3:-}"
|
|
SCOPE="${4:?usage: resolve.sh STATED LABEL DISTROS SCOPE}"
|
|
|
|
POOL="ext4 btrfs zfs"
|
|
|
|
note() {
|
|
echo "filesystem: $*" >&2
|
|
[ -n "${GITHUB_STEP_SUMMARY:-}" ] || return 0
|
|
echo "- \`${LABEL}\` filesystem: $*" >>"${GITHUB_STEP_SUMMARY}"
|
|
}
|
|
|
|
kernel_serves() {
|
|
local fs="$1"
|
|
[ "${fs}" != zfs ] || [ ! -c /dev/zfs ] || return 0
|
|
if [ "${fs}" != zfs ] && grep -qw "${fs}" /proc/filesystems 2>/dev/null; then
|
|
return 0
|
|
fi
|
|
if ! command -v modinfo >/dev/null; then
|
|
note "${fs} left out: not loaded and modinfo is unavailable to ask for the module"
|
|
return 1
|
|
fi
|
|
modinfo "${fs}" >/dev/null 2>&1 && return 0
|
|
note "${fs} left out: this kernel carries no module for it"
|
|
return 1
|
|
}
|
|
|
|
userland_for() {
|
|
case "$1" in
|
|
centos | arch | fedora) echo "ext4 btrfs" ;;
|
|
*) echo "ext4 btrfs zfs" ;;
|
|
esac
|
|
}
|
|
|
|
every_distro_carries() {
|
|
local fs="$1" distro
|
|
[ "${SCOPE}" = node ] || return 0
|
|
for distro in ${DISTROS}; do
|
|
case " $(userland_for "${distro}") " in
|
|
*" ${fs} "*) ;;
|
|
*) return 1 ;;
|
|
esac
|
|
done
|
|
return 0
|
|
}
|
|
|
|
candidates() {
|
|
local kept="" fs
|
|
for fs in ${POOL}; do
|
|
if ! kernel_serves "${fs}"; then
|
|
continue
|
|
fi
|
|
if ! every_distro_carries "${fs}"; then
|
|
note "${fs} left out: not every distro of this entry carries the userland"
|
|
continue
|
|
fi
|
|
kept="${kept} ${fs}"
|
|
done
|
|
kept="${kept# }"
|
|
echo "${kept:-ext4}"
|
|
}
|
|
|
|
if [ -n "${STATED}" ] && [ "${STATED}" != auto ]; then
|
|
PICKED="${STATED}"
|
|
ORIGIN="stated"
|
|
REQUIRED=true
|
|
else
|
|
POOL="$(candidates)"
|
|
read -ra POOL_ENTRIES <<<"${POOL}"
|
|
PICKED="$(printf '%s\n' "${POOL_ENTRIES[@]}" | shuf -n1)"
|
|
ORIGIN="random out of '${POOL}' on the ${SCOPE}; re-state it to reproduce this run"
|
|
REQUIRED=false
|
|
fi
|
|
|
|
echo "filesystem for ${LABEL}: ${PICKED} (${ORIGIN})"
|
|
|
|
if [ -n "${GITHUB_ENV:-}" ]; then
|
|
{
|
|
echo "INFINITO_DOCKER_FILESYSTEM=${PICKED}"
|
|
echo "INFINITO_DOCKER_FILESYSTEM_REQUIRED=${REQUIRED}"
|
|
} >>"${GITHUB_ENV}"
|
|
fi
|
|
|
|
if [ -n "${GITHUB_STEP_SUMMARY:-}" ]; then
|
|
echo "- \`${LABEL}\` runs its docker data root on \`${PICKED}\` (${ORIGIN})" \
|
|
>>"${GITHUB_STEP_SUMMARY}"
|
|
fi
|