mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-11 21:26:44 +00:00
3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
164 lines
5.1 KiB
Python
164 lines
5.1 KiB
Python
from __future__ import annotations
|
|
|
|
import argparse
|
|
import os
|
|
import unittest
|
|
import unittest.mock
|
|
|
|
from cli.administration.deploy.development import exec as exec_cmd
|
|
|
|
|
|
def _args(
|
|
*,
|
|
distro: str = "debian",
|
|
cmd: list[str] | None = None,
|
|
env: list[str] | None = None,
|
|
) -> argparse.Namespace:
|
|
return argparse.Namespace(
|
|
distro=distro,
|
|
cmd=cmd if cmd is not None else [],
|
|
env=env if env is not None else [],
|
|
)
|
|
|
|
|
|
class TestDevelopmentExec(unittest.TestCase):
|
|
def test_handler_forwards_services_disabled(self):
|
|
compose = unittest.mock.Mock()
|
|
compose.exec.return_value.returncode = 0
|
|
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
unittest.mock.patch.dict(os.environ, {"disable": "email"}, clear=False),
|
|
):
|
|
rc = exec_cmd.handler(_args(cmd=["--", "sh", "-lc", "true"]))
|
|
|
|
self.assertEqual(rc, 0)
|
|
compose.exec.assert_called_once_with(
|
|
["sh", "-lc", "true"],
|
|
check=False,
|
|
extra_env={"disable": "email"},
|
|
)
|
|
|
|
def test_handler_omits_extra_env_when_services_disabled_unset(self):
|
|
compose = unittest.mock.Mock()
|
|
compose.exec.return_value.returncode = 0
|
|
|
|
env = {**os.environ, "disable": ""}
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
unittest.mock.patch.dict(os.environ, env, clear=True),
|
|
):
|
|
rc = exec_cmd.handler(_args(cmd=["echo", "hi"]))
|
|
|
|
self.assertEqual(rc, 0)
|
|
compose.exec.assert_called_once_with(
|
|
["echo", "hi"], check=False, extra_env=None
|
|
)
|
|
|
|
def test_handler_requires_command(self):
|
|
with self.assertRaises(SystemExit):
|
|
exec_cmd.handler(_args(cmd=[]))
|
|
|
|
def test_env_pairs_are_injected_into_extra_env(self):
|
|
compose = unittest.mock.Mock()
|
|
compose.exec.return_value.returncode = 0
|
|
|
|
env = {**os.environ, "disable": ""}
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
unittest.mock.patch.dict(os.environ, env, clear=True),
|
|
):
|
|
rc = exec_cmd.handler(
|
|
_args(
|
|
cmd=["bash", "/opt/helper.sh"],
|
|
env=[
|
|
"INFINITO_INVENTORY_FILE=/srv/inv/devices.yml",
|
|
"apps=web-app-foo",
|
|
],
|
|
)
|
|
)
|
|
|
|
self.assertEqual(rc, 0)
|
|
compose.exec.assert_called_once_with(
|
|
["bash", "/opt/helper.sh"],
|
|
check=False,
|
|
extra_env={
|
|
"INFINITO_INVENTORY_FILE": "/srv/inv/devices.yml",
|
|
"apps": "web-app-foo",
|
|
},
|
|
)
|
|
|
|
def test_env_pair_with_equals_in_value_is_preserved(self):
|
|
compose = unittest.mock.Mock()
|
|
compose.exec.return_value.returncode = 0
|
|
|
|
env = {**os.environ, "disable": ""}
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
unittest.mock.patch.dict(os.environ, env, clear=True),
|
|
):
|
|
exec_cmd.handler(_args(cmd=["true"], env=["EXTRA_VARS=a=1 b=2"]))
|
|
|
|
compose.exec.assert_called_once_with(
|
|
["true"],
|
|
check=False,
|
|
extra_env={"EXTRA_VARS": "a=1 b=2"},
|
|
)
|
|
|
|
def test_env_pair_overrides_implicit_services_disabled(self):
|
|
compose = unittest.mock.Mock()
|
|
compose.exec.return_value.returncode = 0
|
|
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
unittest.mock.patch.dict(os.environ, {"disable": "from-env"}, clear=False),
|
|
):
|
|
exec_cmd.handler(_args(cmd=["true"], env=["disable=from-cli"]))
|
|
|
|
compose.exec.assert_called_once_with(
|
|
["true"],
|
|
check=False,
|
|
extra_env={"disable": "from-cli"},
|
|
)
|
|
|
|
def test_env_pair_without_equals_is_rejected(self):
|
|
compose = unittest.mock.Mock()
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
self.assertRaisesRegex(SystemExit, "expects KEY=VALUE"),
|
|
):
|
|
exec_cmd.handler(_args(cmd=["true"], env=["BARE"]))
|
|
|
|
def test_env_pair_with_empty_key_is_rejected(self):
|
|
compose = unittest.mock.Mock()
|
|
with (
|
|
unittest.mock.patch(
|
|
"cli.administration.deploy.development.exec.make_compose",
|
|
return_value=compose,
|
|
),
|
|
self.assertRaisesRegex(SystemExit, "KEY is empty"),
|
|
):
|
|
exec_cmd.handler(_args(cmd=["true"], env=["=value"]))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|