kevinveenbirkenbachandClaude Opus 5.5
fad0c60e52
On the Fedora, CentOS Stream and Manjaro workspace jobs install-lint
ran `puppeteer browsers install chrome-headless-shell --install-deps`
as root, and puppeteer rejected it with "apt-get does not seem to be
available". The installer only warned ("optional lint tool"), so
install-lint passed while mmdc had no browser.
--install-deps is now passed only where apt-get exists. Everywhere else
the libraries `ldd` reports missing are installed by soname: dnf and
yum through the RPM provide `<soname>()(64bit)`, pacman through the
first package `pacman -F usr/lib/<soname>` names (libgbm.so.1 is owned
by both mesa and mesa-amber, which conflict). browser_installed() also
requires every library to resolve, so the install-lint stamp stays
stale until the browser can actually load.
A failed npm install, a missing mmdc, a failed or timed-out browser
download and unresolved libraries now raise instead of warning.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
utils/install/lint
Per-tool installer policy for the lint toolchain. For the package's overall role see README.md. For general README conventions see documentation.md.
Purpose
Each module in this directory owns exactly one lint tool and exposes a single ensure() function.
The CLI in __main__.py groups these ensure calls and applies the stamp-based skip for the default "all" invocation.
File Naming
- A module name MUST match the lowercase snake_case of the tool it installs:
actionlint->actionlint.pymarkdownlint-cli2->markdownlint_cli2.pyansible-lint->ansible/lint.py
- Aggregate installers (one helper covers a tightly coupled command pair) take the topic name without a key suffix.
Example:
ansible/commands.pyinstalls bothansible-playbookandansible-galaxyvia the same system-package candidates.
Module Shape
Every per-tool module MUST expose the same surface so the dispatcher can call it uniformly:
"""<one-line docstring: what gets installed and via which channel>."""
from __future__ import annotations
def ensure() -> None:
"""Install <tool> if not present. Raises RuntimeError on failure."""
ensure()MUST be idempotent: return immediately when the tool is already on PATH (or importable, for Python modules).ensure()MUST raiseRuntimeErrorwith a descriptive message on failure.- A module MAY read tool-specific environment overrides (e.g.
ACTIONLINT_VERSION,RUFF_PIP_SPEC) at call time.
Import Rules
- A per-tool module MUST NOT import another per-tool module.
Shared logic flows through
utils.install.primitives,utils.install.pip,utils.install.npm,utils.install.github_release, andutils.install.system_pkgonly. - A per-tool module MAY import from
utils.cache(forPROJECT_ROOT) and from stdlib.
Group Dispatch
__main__.py maps each CLI group to a fixed set of ensure() calls:
| Group | Modules called (in order) |
|---|---|
action |
actionlint |
ansible |
ansible_commands, ansible_collections, ansible_lint |
python |
shfmt, ruff |
shellcheck |
shellcheck |
markdown |
markdownlint_cli2 |
makefile |
mbake |
javascript |
eslint |
all (default) |
every group above, in the order listed |
The all mode honors a per-interpreter stamp at build/install-lint-<hash>.stamp (the suffix is the first 8 chars of sha256(sys.executable), so host and container track independently even though build/ is bind-mounted).
Stamp dependencies are lint.sh and pyproject.toml.
Group-targeted invocations always run and never touch the stamp.