mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
Every one of the eleven declared tools carried the placeholder schema
{"properties": {}, "type": "object"}. The adapter answers tools/list purely
from this contract, so each client saw parameterless tools: nothing could know
that read_post needs a post_id, and the call failed upstream instead of being
formed correctly. The schemas here were measured against the running upstream;
list_agents keeps an empty property set because upstream declares none.
Both pins of the file follow, as the adapter rehashes the contract at startup.
Add a lint binding the declared surface to the shipped one. Only the allowlist
is an equality: writer_allowlist is a superset by construction, because
passthrough.py rejects a whole contract as soon as one tool declares
mutating: true while mutations are off, and upstream_serves is an observation
that may legitimately exceed what the platform allows.
The suppression lookup both MCP lints need moves into suppress.py rather than
being written twice.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
156 lines
4.9 KiB
Python
156 lines
4.9 KiB
Python
"""Unified suppression markers for infinito-nexus tests.
|
|
|
|
A single grammar covers every per-line, per-block, and per-file
|
|
opt-out across the test suite. See
|
|
``docs/contributing/actions/testing/suppression.md`` for the catalog
|
|
of valid rule keys, their placement, and the test that consumes each.
|
|
|
|
Grammar
|
|
=======
|
|
|
|
<comment-prefix> (noqa|nocheck): <rule>(\\s*,\\s*<rule>)*
|
|
|
|
Accepted comment prefixes:
|
|
|
|
* ``#`` (Python, YAML, shell, conf, INI, …)
|
|
* ``//`` (JS, JSONC, …)
|
|
* ``{# … #}`` (Jinja2)
|
|
* ``<!-- … -->`` (HTML, Markdown)
|
|
|
|
``noqa`` and ``nocheck`` are accepted as synonyms (case-insensitive)
|
|
by this parser. By repo convention every project rule from
|
|
``docs/contributing/actions/testing/suppression.md`` MUST use
|
|
``nocheck:`` because ``# noqa: <code>`` is also parsed by ruff as a
|
|
flake8 directive and triggers ``invalid-noqa-code`` warnings on every
|
|
project-specific rule key. ``noqa:`` is reserved for real flake8 / ruff
|
|
codes (``E402``, ``F401``, …). The ``direct-yaml`` lint enforces the
|
|
convention by hard-rejecting the ``noqa:`` form.
|
|
|
|
Multiple rules may be combined on one comment, comma-separated:
|
|
|
|
# nocheck: shared, email
|
|
# nocheck: url, docker-version
|
|
|
|
Position semantics are per-rule and listed in the catalog page. This
|
|
module exposes three resolvers:
|
|
|
|
* :func:`is_suppressed_at`: same line, line above, or either.
|
|
* :func:`is_suppressed_in_head`: anywhere in the first N lines
|
|
(file-level opt-outs).
|
|
* :func:`is_suppressed_anywhere`: anywhere in the file (used by the
|
|
run-once schema check).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from typing import TYPE_CHECKING
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Sequence
|
|
|
|
_KEYWORD_RE = re.compile(
|
|
r"(?:noqa|nocheck)\s*:\s*([a-z0-9][a-z0-9\-]*(?:\s*,\s*[a-z0-9][a-z0-9\-]*)*)",
|
|
re.IGNORECASE,
|
|
)
|
|
|
|
|
|
def _rules_on_line(line: str) -> set[str]:
|
|
"""Return the set of rule keys present in suppression markers on *line*."""
|
|
found: set[str] = set()
|
|
for match in _KEYWORD_RE.finditer(line):
|
|
for raw_rule in match.group(1).split(","):
|
|
rule = raw_rule.strip().lower()
|
|
if rule:
|
|
found.add(rule)
|
|
return found
|
|
|
|
|
|
def line_has_rule(line: str, rule: str) -> bool:
|
|
"""Return True iff *line* carries a marker for *rule*."""
|
|
return rule.lower() in _rules_on_line(line)
|
|
|
|
|
|
def is_suppressed_at(
|
|
lines: Sequence[str],
|
|
line_no: int,
|
|
rule: str,
|
|
*,
|
|
mode: str = "same-or-above",
|
|
) -> bool:
|
|
"""Check whether the construct at 1-based *line_no* is suppressed.
|
|
|
|
``mode`` selects placement semantics:
|
|
|
|
* ``"same-line"``: marker must be on the construct's line.
|
|
* ``"line-above"``: marker must be on the immediately preceding
|
|
non-empty line. Blank lines between marker and construct break
|
|
the association.
|
|
* ``"same-or-above"`` (default): either of the above.
|
|
"""
|
|
if line_no < 1 or line_no > len(lines):
|
|
return False
|
|
|
|
rule = rule.lower()
|
|
|
|
if mode in ("same-line", "same-or-above") and line_has_rule(
|
|
lines[line_no - 1], rule
|
|
):
|
|
return True
|
|
|
|
if mode in ("line-above", "same-or-above"):
|
|
prev = line_no - 2
|
|
while prev >= 0 and not lines[prev].strip():
|
|
prev -= 1
|
|
if prev >= 0 and line_has_rule(lines[prev], rule):
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def is_suppressed_in_head(
|
|
lines: Sequence[str],
|
|
rule: str,
|
|
*,
|
|
scan_lines: int = 30,
|
|
) -> bool:
|
|
"""Return True iff *rule* appears in the first *scan_lines* lines.
|
|
|
|
File-level opt-outs (e.g. ``file-size``) MUST live near the top of
|
|
the file so the cost of carrying the exemption stays visible.
|
|
"""
|
|
rule = rule.lower()
|
|
return any(line_has_rule(line, rule) for line in lines[:scan_lines])
|
|
|
|
|
|
def is_suppressed_anywhere(lines: Sequence[str], rule: str) -> bool:
|
|
"""Return True iff *rule* appears on any line of *lines*.
|
|
|
|
Used for whole-file opt-outs whose semantics legitimately apply to
|
|
the entire file regardless of where the marker sits (e.g.
|
|
``run-once`` on roles that are intentionally executed every play).
|
|
"""
|
|
rule = rule.lower()
|
|
return any(line_has_rule(line, rule) for line in lines)
|
|
|
|
|
|
def is_suppressed_for_key(lines: Sequence[str], key: str, rule: str) -> bool:
|
|
"""Whether the mapping line declaring *key* carries a marker for *rule*.
|
|
|
|
Args:
|
|
lines: the file's lines.
|
|
key: the YAML key, matched as ``<key>:`` after stripping indentation.
|
|
rule: the rule to look for.
|
|
"""
|
|
number = next(
|
|
(n for n, line in enumerate(lines, 1) if line.strip().startswith(f"{key}:")),
|
|
None,
|
|
)
|
|
return number is not None and is_suppressed_at(lines, number, rule)
|
|
|
|
|
|
def suppressed_line_numbers(lines: Sequence[str], rule: str) -> set[int]:
|
|
"""Return the set of 1-based line numbers carrying a marker for *rule*."""
|
|
rule = rule.lower()
|
|
return {idx for idx, line in enumerate(lines, start=1) if line_has_rule(line, rule)}
|