mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
123 lines
4.0 KiB
Python
123 lines
4.0 KiB
Python
from __future__ import annotations
|
|
|
|
import io
|
|
import os
|
|
import runpy
|
|
import sys
|
|
import unittest
|
|
from contextlib import redirect_stdout
|
|
from types import ModuleType
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
SCRIPT_PATH = PROJECT_ROOT / "roles/web-app-baserow/files/python/bootstrap_admin.py"
|
|
|
|
DEFAULT_ENV = {
|
|
"BOOTSTRAP_ADMIN_USERNAME": "alice",
|
|
"BOOTSTRAP_ADMIN_EMAIL": "alice@example.com",
|
|
"BOOTSTRAP_ADMIN_PASSWORD": "s3cret",
|
|
}
|
|
|
|
|
|
def _fake_django_modules(
|
|
user_cls: MagicMock, profile_cls: MagicMock
|
|
) -> dict[str, ModuleType]:
|
|
contrib_auth = ModuleType("django.contrib.auth")
|
|
contrib_auth.get_user_model = MagicMock(return_value=user_cls)
|
|
|
|
contrib = ModuleType("django.contrib")
|
|
contrib.auth = contrib_auth
|
|
|
|
django = ModuleType("django")
|
|
django.contrib = contrib
|
|
|
|
baserow_core_models = ModuleType("baserow.core.models")
|
|
baserow_core_models.UserProfile = profile_cls
|
|
|
|
baserow_core = ModuleType("baserow.core")
|
|
baserow_core.models = baserow_core_models
|
|
|
|
baserow = ModuleType("baserow")
|
|
baserow.core = baserow_core
|
|
|
|
return {
|
|
"baserow": baserow,
|
|
"baserow.core": baserow_core,
|
|
"baserow.core.models": baserow_core_models,
|
|
"django": django,
|
|
"django.contrib": contrib,
|
|
"django.contrib.auth": contrib_auth,
|
|
}
|
|
|
|
|
|
class TestBootstrapAdmin(unittest.TestCase):
|
|
def _run(
|
|
self, *, created: bool, env: dict[str, str] | None = None
|
|
) -> tuple[str, MagicMock, MagicMock, MagicMock, MagicMock]:
|
|
if not SCRIPT_PATH.is_file():
|
|
raise FileNotFoundError(f"bootstrap_admin.py not found at: {SCRIPT_PATH}")
|
|
|
|
user_instance = MagicMock(name="user")
|
|
manager = MagicMock(name="objects")
|
|
manager.get_or_create.return_value = (user_instance, created)
|
|
|
|
user_cls = MagicMock(name="User")
|
|
user_cls.objects = manager
|
|
profile = MagicMock(name="profile")
|
|
profile.email_verified = False
|
|
profile.completed_onboarding = False
|
|
profile_manager = MagicMock(name="profile_objects")
|
|
profile_manager.get_or_create.return_value = (profile, False)
|
|
profile_cls = MagicMock(name="UserProfile")
|
|
profile_cls.objects = profile_manager
|
|
|
|
buf = io.StringIO()
|
|
with (
|
|
patch.dict(os.environ, env if env is not None else DEFAULT_ENV, clear=True),
|
|
patch.dict(sys.modules, _fake_django_modules(user_cls, profile_cls)),
|
|
redirect_stdout(buf),
|
|
):
|
|
runpy.run_path(str(SCRIPT_PATH), run_name="__main__")
|
|
|
|
return buf.getvalue().strip(), user_instance, manager, profile, profile_manager
|
|
|
|
def test_creates_new_superuser(self) -> None:
|
|
out, user, manager, profile, profile_manager = self._run(created=True)
|
|
|
|
manager.get_or_create.assert_called_once_with(
|
|
username="alice",
|
|
defaults={
|
|
"email": "alice@example.com",
|
|
"is_staff": True,
|
|
"is_superuser": True,
|
|
},
|
|
)
|
|
user.set_password.assert_called_once_with("s3cret")
|
|
user.save.assert_called_once_with()
|
|
profile_manager.get_or_create.assert_called_once_with(user=user)
|
|
profile.save.assert_called_once_with(
|
|
update_fields=["email_verified", "completed_onboarding"]
|
|
)
|
|
self.assertEqual(out, "created")
|
|
|
|
def test_skips_password_when_user_exists(self) -> None:
|
|
out, user, manager, profile, profile_manager = self._run(created=False)
|
|
|
|
manager.get_or_create.assert_called_once()
|
|
user.set_password.assert_not_called()
|
|
user.save.assert_not_called()
|
|
profile_manager.get_or_create.assert_called_once_with(user=user)
|
|
profile.save.assert_called_once_with(
|
|
update_fields=["email_verified", "completed_onboarding"]
|
|
)
|
|
self.assertEqual(out, "exists")
|
|
|
|
def test_missing_env_raises_keyerror(self) -> None:
|
|
with self.assertRaises(KeyError):
|
|
self._run(created=True, env={})
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|