mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
102 lines
3.6 KiB
Python
102 lines
3.6 KiB
Python
from __future__ import annotations
|
|
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from plugins.lookup.tor_reachable import LookupModule, is_reachable
|
|
from utils.cache import _reset_cache_for_tests
|
|
from utils.cache.yaml import dump_yaml_str
|
|
from utils.roles.mapping import ROLE_FILE_META_SERVICES
|
|
|
|
|
|
def _apps(tor_enabled: object, exposed: object) -> dict:
|
|
return {
|
|
"svc-db-mariadb": {
|
|
"services": {
|
|
"tor": {"enabled": tor_enabled},
|
|
"mariadb": {"exposed": exposed, "ports": {"local": {"mariadb": 3306}}},
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
class TestIsReachable(unittest.TestCase):
|
|
def test_tor_enabled_and_exposed(self) -> None:
|
|
self.assertTrue(is_reachable(_apps(True, True), "svc-db-mariadb"))
|
|
|
|
def test_exposed_without_tor(self) -> None:
|
|
self.assertFalse(is_reachable(_apps(False, True), "svc-db-mariadb"))
|
|
|
|
def test_tor_without_exposed(self) -> None:
|
|
self.assertFalse(is_reachable(_apps(True, False), "svc-db-mariadb"))
|
|
|
|
def test_string_truthiness_matches_tor_ports(self) -> None:
|
|
self.assertTrue(is_reachable(_apps("true", "yes"), "svc-db-mariadb"))
|
|
self.assertFalse(is_reachable(_apps("true", "off"), "svc-db-mariadb"))
|
|
|
|
def test_exposed_service_without_local_port_has_no_onion_target(self) -> None:
|
|
apps = {
|
|
"svc-db-mariadb": {
|
|
"services": {
|
|
"tor": {"enabled": True},
|
|
"mariadb": {"exposed": True, "ports": {"public": {"tls": 3307}}},
|
|
}
|
|
}
|
|
}
|
|
self.assertFalse(is_reachable(apps, "svc-db-mariadb"))
|
|
|
|
def test_unknown_or_malformed_application(self) -> None:
|
|
self.assertFalse(is_reachable(_apps(True, True), "svc-db-nope"))
|
|
self.assertFalse(is_reachable({"a": None}, "a"))
|
|
self.assertFalse(is_reachable({}, "a"))
|
|
|
|
|
|
class TestTorReachableLookup(unittest.TestCase):
|
|
def setUp(self) -> None:
|
|
self._tmpdir = tempfile.TemporaryDirectory()
|
|
self.roles_dir = Path(self._tmpdir.name) / "roles"
|
|
_reset_cache_for_tests()
|
|
for role, exposed in (("svc-db-mariadb", True), ("svc-db-postgres", False)):
|
|
path = self.roles_dir / role / ROLE_FILE_META_SERVICES
|
|
path.parent.mkdir(parents=True, exist_ok=True)
|
|
entity = role.rsplit("-", 1)[-1]
|
|
path.write_text(
|
|
dump_yaml_str(
|
|
{
|
|
"tor": {"enabled": True},
|
|
entity: {
|
|
"exposed": exposed,
|
|
"ports": {"local": {entity: 3306}},
|
|
},
|
|
}
|
|
),
|
|
encoding="utf-8",
|
|
)
|
|
self.lookup = LookupModule()
|
|
self.lookup._templar = None
|
|
|
|
def tearDown(self) -> None:
|
|
_reset_cache_for_tests()
|
|
self._tmpdir.cleanup()
|
|
|
|
def _run(self, application_id: str) -> bool:
|
|
return self.lookup.run(
|
|
[application_id], variables={}, roles_dir=str(self.roles_dir)
|
|
)[0]
|
|
|
|
def test_run_resolves_against_the_merged_applications_view(self) -> None:
|
|
self.assertTrue(self._run("svc-db-mariadb"))
|
|
self.assertFalse(self._run("svc-db-postgres"))
|
|
|
|
def test_arity_and_empty_term_raise(self) -> None:
|
|
for terms in ([], ["a", "b"], [""], [" "]):
|
|
with self.subTest(terms=terms), self.assertRaises(AnsibleError):
|
|
self.lookup.run(terms, variables={}, roles_dir=str(self.roles_dir))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|