mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
102 lines
3.1 KiB
Python
102 lines
3.1 KiB
Python
import sys
|
|
import unittest
|
|
import unittest.mock as mock
|
|
from unittest.mock import patch
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
|
|
def _ensure_repo_root_on_syspath():
|
|
if str(PROJECT_ROOT) not in sys.path:
|
|
sys.path.insert(0, str(PROJECT_ROOT))
|
|
|
|
|
|
_ensure_repo_root_on_syspath()
|
|
|
|
from plugins.lookup.domain import LookupModule # noqa: E402
|
|
|
|
|
|
class TestDomainLookup(unittest.TestCase):
|
|
"""Unit tests for the `domain` lookup.
|
|
|
|
The plugin delegates the canonical-domains map build to the `domains`
|
|
lookup reached through the Ansible lookup loader. These tests patch that
|
|
loader so we assert only the plugin's dispatch + primary-domain extraction
|
|
logic, not the merge pipeline (which has its own integration tests).
|
|
"""
|
|
|
|
def setUp(self):
|
|
self.lookup = LookupModule()
|
|
self.lookup._loader = mock.MagicMock()
|
|
|
|
def run_lookup(self, application_id, domains_map):
|
|
with patch("plugins.lookup.domain.lookup_loader") as loader_mock:
|
|
|
|
def _get(name, *a, **k):
|
|
if name == "domains":
|
|
return mock.MagicMock(run=lambda *_a, **_k: [domains_map])
|
|
return mock.MagicMock(run=lambda *_a, **_k: [{}])
|
|
|
|
loader_mock.get.side_effect = _get
|
|
return self.lookup.run(
|
|
terms=[application_id],
|
|
variables={},
|
|
)
|
|
|
|
def test_string_domain(self):
|
|
self.assertEqual(
|
|
self.run_lookup("app", {"app": "example.com"}), ["example.com"]
|
|
)
|
|
|
|
def test_list_domain(self):
|
|
self.assertEqual(
|
|
self.run_lookup("app", {"app": ["example.com", "alt.example.com"]}),
|
|
["example.com"],
|
|
)
|
|
|
|
def test_dict_domain(self):
|
|
self.assertEqual(
|
|
self.run_lookup(
|
|
"app",
|
|
{"app": {"primary": "example.com", "secondary": "alt.example.com"}},
|
|
),
|
|
["example.com"],
|
|
)
|
|
|
|
def test_missing_application_id(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.run_lookup_raw([])
|
|
|
|
def test_unknown_application_id(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.run_lookup("unknown", {"app": "example.com"})
|
|
|
|
def test_empty_string_domain(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.run_lookup("app", {"app": ""})
|
|
|
|
def test_empty_list_domain(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.run_lookup("app", {"app": []})
|
|
|
|
def test_empty_dict_domain(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.run_lookup("app", {"app": {}})
|
|
|
|
def test_invalid_application_id_type(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.run_lookup_raw([123])
|
|
|
|
def run_lookup_raw(self, terms):
|
|
with patch("plugins.lookup.domain.lookup_loader") as loader_mock:
|
|
loader_mock.get.return_value = mock.MagicMock(
|
|
run=lambda *_a, **_k: [{"app": "example.com"}]
|
|
)
|
|
return self.lookup.run(terms=terms, variables={})
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|