mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-07 19:32:17 +00:00
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
177 lines
5.8 KiB
Python
177 lines
5.8 KiB
Python
import unittest
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from plugins.lookup.canonical_url import LookupModule
|
|
|
|
|
|
class TestCanonicalUrlLookup(unittest.TestCase):
|
|
def setUp(self):
|
|
self.lookup = LookupModule()
|
|
self.base_vars = {"TLS_ENABLED": True}
|
|
|
|
def _get(name, *args, **kwargs):
|
|
plugin = MagicMock()
|
|
|
|
def _run(terms, variables=None, **_kwargs):
|
|
key = "domains" if name == "domains" else "applications"
|
|
return [(variables or {}).get(key, {})]
|
|
|
|
plugin.run.side_effect = _run
|
|
return plugin
|
|
|
|
patcher = patch(
|
|
"plugins.lookup.canonical_url.lookup_loader.get",
|
|
side_effect=_get,
|
|
)
|
|
patcher.start()
|
|
self.addCleanup(patcher.stop)
|
|
|
|
def _run(self, terms, domains, applications=None, extra_vars=None, **kwargs):
|
|
v = dict(self.base_vars)
|
|
v["domains"] = domains
|
|
v["applications"] = applications or {}
|
|
if extra_vars:
|
|
v.update(extra_vars)
|
|
return self.lookup.run(terms, variables=v, **kwargs)[0]
|
|
|
|
def test_primary_clearnet_is_https(self):
|
|
out = self._run(["web-app-a"], {"web-app-a": ["a.example"]})
|
|
self.assertEqual(out, "https://a.example")
|
|
|
|
def test_primary_onion_is_http(self):
|
|
out = self._run(["web-app-a"], {"web-app-a": ["a.abc.onion"]})
|
|
self.assertEqual(out, "http://a.abc.onion")
|
|
|
|
def test_named_canonical_clearnet(self):
|
|
out = self._run(
|
|
["web-app-matrix", "element"],
|
|
{
|
|
"web-app-matrix": {
|
|
"synapse": "matrix.example",
|
|
"element": "element.example",
|
|
}
|
|
},
|
|
)
|
|
self.assertEqual(out, "https://element.example")
|
|
|
|
def test_named_canonical_onion(self):
|
|
out = self._run(
|
|
["web-app-matrix", "synapse"],
|
|
{
|
|
"web-app-matrix": {
|
|
"synapse": "matrix.abc.onion",
|
|
"element": "element.abc.onion",
|
|
}
|
|
},
|
|
)
|
|
self.assertEqual(out, "http://matrix.abc.onion")
|
|
|
|
def test_missing_key_raises(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self._run(
|
|
["web-app-matrix", "nope"],
|
|
{"web-app-matrix": {"element": "element.example"}},
|
|
)
|
|
|
|
def test_key_on_list_domain_raises(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self._run(["web-app-a", "element"], {"web-app-a": ["a.example"]})
|
|
|
|
def test_bad_arity_raises(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self.lookup.run([], variables=self.base_vars)
|
|
|
|
def test_primary_aligns_to_clearnet_consumer(self):
|
|
out = self._run(
|
|
["web-svc-cdn"],
|
|
{
|
|
"web-svc-cdn": ["cdn.abc.onion", "cdn.example"],
|
|
"web-app-bigbluebutton": ["bbb.example"],
|
|
},
|
|
extra_vars={"application_id": "web-app-bigbluebutton"},
|
|
)
|
|
self.assertEqual(out, "https://cdn.example")
|
|
|
|
def test_primary_stays_onion_for_onion_consumer(self):
|
|
out = self._run(
|
|
["web-svc-cdn"],
|
|
{
|
|
"web-svc-cdn": ["cdn.abc.onion", "cdn.example"],
|
|
"web-app-dashboard": ["dash.abc.onion"],
|
|
},
|
|
extra_vars={"application_id": "web-app-dashboard"},
|
|
)
|
|
self.assertEqual(out, "http://cdn.abc.onion")
|
|
|
|
def test_primary_onion_only_falls_back_for_clearnet_consumer(self):
|
|
out = self._run(
|
|
["web-svc-cdn"],
|
|
{
|
|
"web-svc-cdn": ["cdn.abc.onion"],
|
|
"web-app-bigbluebutton": ["bbb.example"],
|
|
},
|
|
extra_vars={"application_id": "web-app-bigbluebutton"},
|
|
)
|
|
self.assertEqual(out, "http://cdn.abc.onion")
|
|
|
|
def test_primary_unchanged_without_consumer_context(self):
|
|
out = self._run(
|
|
["web-svc-cdn"],
|
|
{
|
|
"web-svc-cdn": ["cdn.abc.onion", "cdn.example"],
|
|
"web-app-bigbluebutton": ["bbb.example"],
|
|
},
|
|
)
|
|
self.assertEqual(out, "http://cdn.abc.onion")
|
|
|
|
def test_consumer_kwarg_drives_alignment(self):
|
|
out = self._run(
|
|
["web-svc-cdn"],
|
|
{
|
|
"web-svc-cdn": ["cdn.abc.onion", "cdn.example"],
|
|
"web-app-bigbluebutton": ["bbb.example"],
|
|
},
|
|
applications={
|
|
"web-app-bigbluebutton": {"services": {"cdn": {"enabled": True}}}
|
|
},
|
|
consumer="web-app-bigbluebutton",
|
|
)
|
|
self.assertEqual(out, "https://cdn.example")
|
|
|
|
def test_consumer_with_enabled_binding_resolves(self):
|
|
out = self._run(
|
|
["web-app-seaweedfs", "filer"],
|
|
{"web-app-seaweedfs": {"filer": "filer.example"}},
|
|
applications={
|
|
"web-app-nextcloud": {"services": {"seaweedfs": {"enabled": True}}}
|
|
},
|
|
consumer="web-app-nextcloud",
|
|
)
|
|
self.assertEqual(out, "https://filer.example")
|
|
|
|
def test_consumer_with_disabled_binding_is_empty(self):
|
|
out = self._run(
|
|
["web-app-seaweedfs", "filer"],
|
|
{"web-app-seaweedfs": {"filer": "filer.example"}},
|
|
applications={
|
|
"web-app-nextcloud": {"services": {"seaweedfs": {"enabled": False}}}
|
|
},
|
|
consumer="web-app-nextcloud",
|
|
)
|
|
self.assertEqual(out, "")
|
|
|
|
def test_consumer_without_binding_is_empty(self):
|
|
out = self._run(
|
|
["web-app-seaweedfs", "filer"],
|
|
{"web-app-seaweedfs": {"filer": "filer.example"}},
|
|
applications={"web-app-nextcloud": {"services": {}}},
|
|
consumer="web-app-nextcloud",
|
|
)
|
|
self.assertEqual(out, "")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|