mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
176 lines
5.6 KiB
Python
176 lines
5.6 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import unittest
|
|
import urllib.error
|
|
from typing import Self
|
|
from unittest.mock import patch
|
|
|
|
import cli.contributing.mirror.cleanup.__main__ as cleanup_main
|
|
|
|
|
|
class _FakeResponse:
|
|
def __init__(self, payload: bytes = b"[]"):
|
|
self._payload = payload
|
|
|
|
def read(self) -> bytes:
|
|
return self._payload
|
|
|
|
def __enter__(self) -> Self:
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc, tb) -> bool:
|
|
return False
|
|
|
|
|
|
def _org_probe_ok() -> _FakeResponse:
|
|
return _FakeResponse(b"[]")
|
|
|
|
|
|
def _org_probe_404() -> _FakeResponse:
|
|
raise urllib.error.HTTPError("url", 404, "Not Found", {}, None)
|
|
|
|
|
|
class TestCleanupMain(unittest.TestCase):
|
|
def _pkg(self, name: str, visibility: str = "private") -> dict:
|
|
return {"name": name, "visibility": visibility}
|
|
|
|
@patch.dict(os.environ, {"GITHUB_TOKEN": "tok"}, clear=False)
|
|
def test_dry_run_does_not_delete(self) -> None:
|
|
packages = [self._pkg("mirror/foo")]
|
|
responses = [
|
|
_org_probe_ok(),
|
|
_FakeResponse(json.dumps(packages).encode()),
|
|
_FakeResponse(b"[]"),
|
|
]
|
|
with (
|
|
patch(
|
|
"cli.contributing.mirror.cleanup.__main__.urllib.request.urlopen",
|
|
side_effect=responses,
|
|
) as mock_open,
|
|
patch("sys.argv", ["cleanup", "--ghcr-namespace", "acme", "--dry-run"]),
|
|
):
|
|
result = cleanup_main.main()
|
|
|
|
self.assertEqual(result, 0)
|
|
delete_calls = [
|
|
c for c in mock_open.call_args_list if c[0][0].get_method() == "DELETE"
|
|
]
|
|
self.assertEqual(delete_calls, [])
|
|
|
|
@patch.dict(os.environ, {"GITHUB_TOKEN": "tok"}, clear=False)
|
|
def test_matching_private_package_is_deleted(self) -> None:
|
|
packages = [self._pkg("mirror/bar", "private")]
|
|
call_count = 0
|
|
|
|
def fake_urlopen(req):
|
|
nonlocal call_count
|
|
call_count += 1
|
|
if req.get_method() == "DELETE":
|
|
return _FakeResponse(b"")
|
|
if call_count == 1:
|
|
return _org_probe_ok()
|
|
return _FakeResponse(
|
|
json.dumps(packages if call_count == 2 else []).encode()
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"cli.contributing.mirror.cleanup.__main__.urllib.request.urlopen",
|
|
side_effect=fake_urlopen,
|
|
),
|
|
patch("sys.argv", ["cleanup", "--ghcr-namespace", "acme"]),
|
|
):
|
|
result = cleanup_main.main()
|
|
|
|
self.assertEqual(result, 0)
|
|
|
|
@patch.dict(os.environ, {"GITHUB_TOKEN": "tok"}, clear=False)
|
|
def test_package_outside_prefix_is_ignored(self) -> None:
|
|
packages = [self._pkg("other/foo", "private")]
|
|
responses = [
|
|
_org_probe_ok(),
|
|
_FakeResponse(json.dumps(packages).encode()),
|
|
_FakeResponse(b"[]"),
|
|
]
|
|
with (
|
|
patch(
|
|
"cli.contributing.mirror.cleanup.__main__.urllib.request.urlopen",
|
|
side_effect=responses,
|
|
) as mock_open,
|
|
patch("sys.argv", ["cleanup", "--ghcr-namespace", "acme"]),
|
|
):
|
|
result = cleanup_main.main()
|
|
|
|
self.assertEqual(result, 0)
|
|
delete_calls = [
|
|
c for c in mock_open.call_args_list if c[0][0].get_method() == "DELETE"
|
|
]
|
|
self.assertEqual(delete_calls, [])
|
|
|
|
@patch.dict(os.environ, {}, clear=True)
|
|
def test_missing_token_returns_error(self) -> None:
|
|
with patch("sys.argv", ["cleanup", "--ghcr-namespace", "acme"]):
|
|
result = cleanup_main.main()
|
|
self.assertEqual(result, 1)
|
|
|
|
@patch.dict(os.environ, {"GITHUB_TOKEN": "tok"}, clear=False)
|
|
def test_delete_failure_reports_and_exits_nonzero(self) -> None:
|
|
packages = [self._pkg("mirror/bad", "private")]
|
|
call_count = 0
|
|
|
|
def fake_urlopen(req):
|
|
nonlocal call_count
|
|
call_count += 1
|
|
if req.get_method() == "DELETE":
|
|
raise urllib.error.HTTPError("url", 403, "Forbidden", {}, None)
|
|
if call_count == 1:
|
|
return _org_probe_ok()
|
|
return _FakeResponse(
|
|
json.dumps(packages if call_count == 2 else []).encode()
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"cli.contributing.mirror.cleanup.__main__.urllib.request.urlopen",
|
|
side_effect=fake_urlopen,
|
|
),
|
|
patch("sys.argv", ["cleanup", "--ghcr-namespace", "acme"]),
|
|
):
|
|
result = cleanup_main.main()
|
|
|
|
self.assertEqual(result, 1)
|
|
|
|
@patch.dict(os.environ, {"GITHUB_TOKEN": "tok"}, clear=False)
|
|
def test_user_account_uses_user_endpoint(self) -> None:
|
|
packages = [self._pkg("mirror/foo", "private")]
|
|
call_count = 0
|
|
|
|
def fake_urlopen(req):
|
|
nonlocal call_count
|
|
call_count += 1
|
|
if call_count == 1:
|
|
raise urllib.error.HTTPError("url", 404, "Not Found", {}, None)
|
|
if req.get_method() == "DELETE":
|
|
self.assertIn("/user/packages/", req.full_url)
|
|
return _FakeResponse(b"")
|
|
return _FakeResponse(
|
|
json.dumps(packages if call_count == 2 else []).encode()
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"cli.contributing.mirror.cleanup.__main__.urllib.request.urlopen",
|
|
side_effect=fake_urlopen,
|
|
),
|
|
patch("sys.argv", ["cleanup", "--ghcr-namespace", "bob"]),
|
|
):
|
|
result = cleanup_main.main()
|
|
|
|
self.assertEqual(result, 0)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|