Files
computer-playbook/cli/contributing/mirror/sync/__main__.py
T
kevinveenbirkenbachandClaude Opus 5.5 8a29ba0bfd fix(images): leave eol roles out of image discovery
The scheduled mirror job has failed every day since 2026-09-25 on the same two
images: quay.io/minio/minio and quay.io/minio/mc answer `unauthorized` to
anonymous pulls ("2/197 failed", run 38352569503). Both belong to
web-app-minio, an eol role outside the lifecycle envelope that default.env
tests, so no CI deploy pulls them.

iter_role_images now skips every role that is_maintained() reports as
unmaintained, the check the version updaters already apply to the same list.
On the tree the discovery yields 187 images instead of 192; the five it drops
belong to the four eol roles web-app-confluence, web-app-jira, web-app-minio
and web-app-phpldapadmin. The mirror sync, resolver and wait read this list,
and their descriptions and mirror.md now say so.

The roles directory is resolved first: is_maintained reads a relative path as
a role name and would keep every role.

475ab9b386 on feature/store-i18n takes the same approach with a lifecycle
reader of its own; main already has is_maintained for it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-14 01:19:28 +02:00

140 lines
4.2 KiB
Python

from __future__ import annotations
import argparse
import subprocess
import sys
import time
from itertools import chain
from pathlib import Path
from cli.contributing.mirror.providers import GHCRProvider
from utils.docker.image.discovery import iter_role_images, iter_runner_images
def _validate_positive_int(value: str) -> int:
try:
n = int(value)
except ValueError as e:
raise argparse.ArgumentTypeError("must be an integer") from e
if n <= 0:
raise argparse.ArgumentTypeError("must be > 0")
return n
def _throttle_before_next_copy(
*, images_per_hour: int | None, last_start_ts: float | None
) -> float:
"""
If images_per_hour is set, ensure at least (3600 / images_per_hour) seconds
have elapsed since last_start_ts before returning.
Returns the (possibly updated) start timestamp for the next copy.
"""
if not images_per_hour:
return time.monotonic()
min_interval = 3600.0 / float(images_per_hour)
now = time.monotonic()
if last_start_ts is not None:
elapsed = now - last_start_ts
remaining = min_interval - elapsed
if remaining > 0:
print(
f"[mirror] throttling: sleeping {remaining:.1f}s "
f"(limit={images_per_hour} images/hour)",
flush=True,
)
time.sleep(remaining)
return time.monotonic()
def main() -> int:
parser = argparse.ArgumentParser(
description=(
"Mirror every image a non-eol role declares and every image the "
"CI runner pulls itself to the configured GHCR registry, "
"optionally throttled and optionally skipping already-mirrored "
"tags."
),
)
parser.add_argument("--repo-root", default=".")
GHCRProvider.add_args(parser)
parser.add_argument(
"--only-missing",
action="store_true",
help="Mirror only images that do not exist in the destination registry.",
)
parser.add_argument(
"--images-per-hour",
type=_validate_positive_int,
default=None,
help="Optional throttle: max images to mirror per hour (best-effort).",
)
args = parser.parse_args()
provider = GHCRProvider.from_args(args)
repo_root = Path(args.repo_root).resolve()
failures: list[str] = []
total = 0
last_start_ts: float | None = None
for img in chain(iter_role_images(repo_root), iter_runner_images(repo_root)):
last_start_ts = _throttle_before_next_copy(
images_per_hour=args.images_per_hour,
last_start_ts=last_start_ts,
)
total += 1
src = f"docker://{img.source}"
dest = f"docker://{provider.image_base(img)}:{img.version}"
label = f"{img.role}:{img.service} ({img.name}:{img.version})"
try:
if args.only_missing and provider.tag_exists(img):
print(
f"[mirror] {label}: destination exists, skipping ({dest})",
flush=True,
)
continue
print(f"[mirror] {label}: {src} -> {dest}", flush=True)
provider.mirror(img)
except subprocess.CalledProcessError as e:
msg = (
f"{label}: FAILED (exit={e.returncode})\n"
f" cmd: {' '.join(map(str, e.cmd))}"
)
failures.append(msg)
print(
f"[mirror] {label}: FAILED, continuing...",
file=sys.stderr,
flush=True,
)
except Exception as e:
msg = f"{label}: FAILED (unexpected error: {e!r})"
failures.append(msg)
print(
f"[mirror] {label}: FAILED (unexpected), continuing...",
file=sys.stderr,
flush=True,
)
if failures:
print("\n[mirror] SUMMARY: some images failed:", file=sys.stderr)
for f in failures:
print(f"- {f}", file=sys.stderr)
print(f"\n[mirror] Result: {len(failures)}/{total} failed.", file=sys.stderr)
return 1
print(f"\n[mirror] Result: {total}/{total} succeeded.")
return 0
if __name__ == "__main__":
raise SystemExit(main())