Files
computer-playbook/tests/unit/python/plugins/lookup/test_proxy_pass.py
T
kevinveenbirkenbachandClaude Opus 5.5 7e5da9422c fix(svc-prx-openresty): resolve OpenResty's own address in handlers notified from forced roles
web-app-matrix (ansible flavor) and web-app-bigbluebutton set
compose_mode_force: compose in their role vars, and those vars stay in
scope when their front-proxy includes notify the OpenResty handlers. In
swarm the handlers' container_address lookup then returned the bare
compose name, the validate retried for about 35 s against a container
that does not exist and ended ok, and the reload was skipped: 3 of 52
reloads in the WordPress#0 job of fork run 41926377524 (both matrix
.onion vhosts), so changed vhosts stayed unserved.

The validate, reload and restart handler tasks now clear
compose_mode_force at task level (task vars outrank the inherited role
vars), as the engine, rdbms and objstore entry points already do, and so
do the svc-db-openldap handlers, which the new lint also covers. The
proxy_pass lookup applies a caller's override only when the term names
the scope's own application_id, because the /logout location rendered
inside matrix and BBB vhosts pointed at 127.0.0.1 in swarm.

A real ansible-playbook integration test proves both modes and fails
without the fix; the new lint keeps every handler lookup of a fixed role
clearing the override.

🎯 Fix: 90 %
💥 Break: 4 %
🌱 Efficiency: –
⚡ Speed: –
🛡️ Security: ~100 %
🏆 Score: 86
🚦 Gate: ✅ 90/5, efficiency and speed <= 100, security 100 %

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 11:40:41 +00:00

254 lines
9.0 KiB
Python

"""Tests for the proxy_pass lookup wiring (DEPLOYMENT_MODE + overrides)."""
from __future__ import annotations
import unittest
import unittest.mock as mock
from typing import Any
from unittest.mock import patch
from ansible.errors import AnsibleError
from plugins.lookup.proxy_pass import LookupModule
class _Templar:
def __init__(self, vars_=None):
self.available_variables = vars_ or {}
def template(self, value, **_):
return value
def _apps() -> dict[str, Any]:
return {
"web-app-baserow": {
"services": {
"baserow": {
"ports": {"local": {"http": 8017}, "internal": {"http": 80}},
},
},
},
"web-svc-logout": {
"services": {
"logout": {
"ports": {"local": {"http": 8048}, "internal": {"http": 8000}},
},
},
},
}
def _run(terms, *, variables, **kwargs):
lm = LookupModule()
lm._templar = _Templar(variables)
lm._loader = mock.MagicMock()
with patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock:
loader_mock.get.return_value = mock.MagicMock(run=lambda *_a, **_k: [_apps()])
return lm.run(terms, variables=variables, **kwargs)
class TestProxyPassLookup(unittest.TestCase):
def test_missing_application_id_raises(self):
with self.assertRaises(AnsibleError):
_run([], variables={"DEPLOYMENT_MODE": "swarm"})
def test_swarm_app_directive_defaults_service_key_to_entity(self):
out = _run(
["web-app-baserow"],
variables={"DEPLOYMENT_MODE": "swarm"},
tail="request",
location="/",
)
self.assertEqual(
out[0],
'set $proxy_pass_upstream "baserow:80";\n'
" proxy_pass http://$proxy_pass_upstream$request_uri;",
)
def test_compose_app_directive(self):
out = _run(
["web-app-baserow", "application", "http"],
variables={"DEPLOYMENT_MODE": "compose"},
tail="request",
location="/",
)
self.assertEqual(out[0], "proxy_pass http://127.0.0.1:8017/;")
def test_oauth2_internal_port_override_swarm(self):
out = _run(
["web-app-baserow", "sso-proxy", "http"],
variables={"DEPLOYMENT_MODE": "swarm"},
tail="oauth2",
internal_port=4180,
)
self.assertEqual(
out[0],
'set $proxy_pass_upstream "baserow_sso-proxy:4180";\n'
" proxy_pass http://$proxy_pass_upstream$uri$is_args$args;",
)
def test_swarm_force_bridge_bool_uses_host_gateway_literal(self):
apps = {
"web-app-matrix": {
"services": {
"matrix": {"ports": {"local": {"http": 8021}}},
},
"networks": {"local": {"force_bridge": True}},
}
}
lm = LookupModule()
lm._templar = _Templar({"DEPLOYMENT_MODE": "swarm"})
lm._loader = mock.MagicMock()
with patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock:
loader_mock.get.return_value = mock.MagicMock(run=lambda *_a, **_k: [apps])
out = lm.run(
["web-app-matrix", "matrix", "http"],
variables={"DEPLOYMENT_MODE": "swarm"},
)
self.assertEqual(out[0], "proxy_pass http://host.docker.internal:8021/;")
def test_swarm_force_bridge_template_string_is_resolved(self):
apps = {
"web-app-matrix": {
"services": {"matrix": {"ports": {"local": {"http": 8021}}}},
"networks": {"local": {"force_bridge": "{{ flavor_is_ansible }}"}},
}
}
class _ResolvingTemplar(_Templar):
def template(self, value, **_):
return True if value == "{{ flavor_is_ansible }}" else value
lm = LookupModule()
lm._templar = _ResolvingTemplar({"DEPLOYMENT_MODE": "swarm"})
lm._loader = mock.MagicMock()
with patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock:
loader_mock.get.return_value = mock.MagicMock(run=lambda *_a, **_k: [apps])
out = lm.run(
["web-app-matrix", "matrix", "http"],
variables={"DEPLOYMENT_MODE": "swarm"},
)
self.assertEqual(out[0], "proxy_pass http://host.docker.internal:8021/;")
def test_unresolved_force_bridge_template_hard_fails(self):
apps = {
"web-app-matrix": {
"services": {"matrix": {"ports": {"local": {"http": 8021}}}},
"networks": {"local": {"force_bridge": "{{ never_resolves }}"}},
}
}
lm = LookupModule()
lm._templar = _Templar({"DEPLOYMENT_MODE": "swarm"})
lm._loader = mock.MagicMock()
with (
patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock,
self.assertRaises(AnsibleError),
):
loader_mock.get.return_value = mock.MagicMock(run=lambda *_a, **_k: [apps])
lm.run(
["web-app-matrix", "matrix", "http"],
variables={"DEPLOYMENT_MODE": "swarm"},
)
def test_force_bridge_host_gateway_survives_compose_mode_force(self):
apps = {
"web-app-matrix": {
"services": {"matrix": {"ports": {"local": {"http": 8021}}}},
"networks": {"local": {"force_bridge": True}},
}
}
lm = LookupModule()
lm._templar = _Templar(
{"DEPLOYMENT_MODE": "swarm", "compose_mode_force": "compose"}
)
lm._loader = mock.MagicMock()
with patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock:
loader_mock.get.return_value = mock.MagicMock(run=lambda *_a, **_k: [apps])
out = lm.run(
["web-app-matrix", "matrix", "http"],
variables={
"DEPLOYMENT_MODE": "swarm",
"IS_COMPOSE_MODE": False,
"IS_SWARM_MODE": True,
"compose_mode_force": "compose",
},
)
self.assertEqual(out[0], "proxy_pass http://host.docker.internal:8021/;")
def test_force_bridge_compose_real_mode_stays_loopback(self):
apps = {
"web-app-matrix": {
"services": {"matrix": {"ports": {"local": {"http": 8021}}}},
"networks": {"local": {"force_bridge": True}},
}
}
lm = LookupModule()
lm._templar = _Templar(
{"DEPLOYMENT_MODE": "compose", "compose_mode_force": "compose"}
)
lm._loader = mock.MagicMock()
with patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock:
loader_mock.get.return_value = mock.MagicMock(run=lambda *_a, **_k: [apps])
out = lm.run(
["web-app-matrix", "matrix", "http"],
variables={
"DEPLOYMENT_MODE": "compose",
"IS_COMPOSE_MODE": True,
"IS_SWARM_MODE": False,
"compose_mode_force": "compose",
},
)
self.assertEqual(out[0], "proxy_pass http://127.0.0.1:8021/;")
def test_a_forced_scope_leaves_a_foreign_app_at_the_cluster_mode(self):
out = _run(
["web-svc-logout", "logout", "http"],
variables={
"DEPLOYMENT_MODE": "swarm",
"compose_mode_force": "compose",
"application_id": "web-app-baserow",
},
tail="/logout",
)
self.assertEqual(
out[0],
'set $proxy_pass_upstream "logout:8000";\n'
" proxy_pass http://$proxy_pass_upstream/logout;",
)
def test_a_forced_scope_still_forces_its_own_app(self):
out = _run(
["web-app-baserow", "application", "http"],
variables={
"DEPLOYMENT_MODE": "swarm",
"compose_mode_force": "compose",
"application_id": "web-app-baserow",
},
tail="request",
location="/",
)
self.assertEqual(out[0], "proxy_pass http://127.0.0.1:8017/;")
def test_resolution_error_becomes_ansible_error(self):
lm = LookupModule()
lm._templar = _Templar({"DEPLOYMENT_MODE": "swarm"})
lm._loader = mock.MagicMock()
with (
patch("plugins.lookup.proxy_pass.lookup_loader") as loader_mock,
self.assertRaises(AnsibleError),
):
loader_mock.get.return_value = mock.MagicMock(
run=lambda *_a, **_k: [
{"web-app-x": {"services": {"x": {"ports": {"local": {}}}}}}
]
)
lm.run(
["web-app-x", "application", "http"],
variables={"DEPLOYMENT_MODE": "swarm"},
)
if __name__ == "__main__":
unittest.main()