Files
computer-playbook/utils/github/variant/pins.py
T
kevinveenbirkenbachandClaude Opus 5.5 85d5ad9984 fix(ci): refuse a priority token that leaves no combination to deploy
A priority row whose role is single_mode under a multi network axis (OpenCloud since 6e39be8383) gets no (mode, network, mesh) combination from axes.assign, so the planner silently dropped it and the run reported green for a selection that never ran (fork run 42411117881, OpenCloud#0). check_pins only rejected pinned networks. Extract the priority pick into pins.priority_picks, shared by axes.assign and cli.meta.ci.validate, and make validate (and the trigger's pre-dispatch check) refuse a priority token for which no pinned variant, or for a bare role no variant at all, has a combination left. Whitelist tokens are not held to this rule.

🎯 Fix: 93 %
💥 Break: 3 %
💸 Cost: –
⏱️ Time: –
🛡️ Security: 100 %
🏆 Score: 90
🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 %

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 07:55:48 +00:00

175 lines
6.3 KiB
Python

"""Prove a selection token's pins against what the row and the run permit.
Separate from :mod:`utils.github.variant.axes`, which decides the axes of a
row that carries no pin: this module only refuses the combinations a pin
asks for and the row cannot give.
"""
from __future__ import annotations
from typing import TYPE_CHECKING
from utils.github.variant.network import combinations, network_states
from utils.github.variant.pools import ARCHITECTURES
from utils.github.variant.vpn import VPN_DEPLOY_MODES, pinned_vpn_states
from utils.roles.display import VARIANT_SEPARATOR
from utils.roles.meta_lookup import get_role_architectures
if TYPE_CHECKING:
from collections.abc import Sequence
__all__ = ["check_pins", "priority_picks", "row_architectures"]
def _reject(app: str, variant: str, reason: str) -> None:
"""Abort on a selection the row cannot satisfy.
Raises:
SystemExit: always. A pin the row cannot take is an operator mistake,
and dropping the row instead would report a green run for a
combination that never ran.
"""
shard = f"{VARIANT_SEPARATOR}{variant}" if variant else ""
raise SystemExit(f"selection {app}{shard}: {reason}")
def check_pins(
app: str,
variant: str,
offered: Sequence[str],
*,
pin_mode: str | None,
pin_network: str | None,
pin_distro: str | None,
pin_filesystem: str | None,
pin_architecture: str | None = None,
pin_vpn: bool | None = None,
states: Sequence[str],
network_input: str,
vpn_mode: str = "auto",
distros: Sequence[str],
filesystems: Sequence[str],
architectures: Sequence[str] = ARCHITECTURES,
) -> None:
"""Prove the row can take what the selection token pinned on it.
The offered modes are already narrowed by the run's ``--modes`` input, the
network modes by its ``--network`` input, the mesh states by its ``--vpn``
input and the two pools by ``--distros`` and ``--filesystem``, so this
catches a pin that fights the role, the variant, or the run's own axes with
one check each.
"""
if pin_mode is not None and pin_mode not in offered:
_reject(
app,
variant,
f"pinned mode {pin_mode!r} is not available here "
f"(offered: {', '.join(offered)})",
)
for value, pool, axis in (
(pin_distro, distros, "distro"),
(pin_filesystem, filesystems, "filesystem"),
(pin_architecture, architectures, "architecture"),
):
if value is not None and value not in pool:
_reject(
app,
variant,
f"pinned {axis} {value!r} is outside this run's {axis} pool "
f"({', '.join(pool) or 'empty'})",
)
modes = (pin_mode,) if pin_mode else offered
if pin_network is not None and not any(
pin_network in network_states(mode, states=states, network_input=network_input)
for mode in modes
):
_reject(
app,
variant,
f"pinned network mode {pin_network!r} is impossible here (mode, "
f"variant, the role's reachability or the run's network axis "
f"rules it out)",
)
if pin_vpn is not None and not any(
pinned_vpn_states(mode, pin=pin_vpn, vpn_mode=vpn_mode) for mode in modes
):
_reject(
app,
variant,
f"pinned mesh state {'vpn' if pin_vpn else 'direct'} is impossible "
f"here (only {'/'.join(VPN_DEPLOY_MODES)} meshes). A held vpn axis "
f"overrides the pin instead and is not refused here",
)
def priority_picks(
offered: Sequence[str],
*,
pin_mode: str | None,
pin_network: str | None,
pin_vpn: bool | None,
states: Sequence[str],
network_input: str,
vpn_mode: str,
) -> list[tuple[str, str, bool]]:
"""Args:
offered: the deploy modes the row offers in this run.
pin_mode: the token's pinned deploy mode, ``None`` for any.
pin_network: the token's pinned network mode, ``None`` for any.
pin_vpn: the token's pinned mesh state, ``None`` for any.
states: the network modes the row's role can be served in.
network_input: the run's network axis.
vpn_mode: the run's mesh axis.
Returns:
``(mode, network, meshed)`` per job, empty when the row cannot deploy
in this run at all.
"""
return [
(mode, state, meshed)
for mode, state in combinations(
offered, states=states, network_input=network_input
)
if pin_mode in (None, mode) and pin_network in (None, state)
for meshed in pinned_vpn_states(mode, pin=pin_vpn, vpn_mode=vpn_mode)
]
def row_architectures(
app: str, run_pool: Sequence[str], services: Sequence[str] = ()
) -> tuple[str, ...]:
"""The architectures one role's rows may draw from this run.
A role that declares none takes the run's whole pool, which is what
spreads both architectures evenly over its variants: every row of the
catalogue advances the same rotation, so a role's consecutive rows
alternate rather than repeating one architecture.
Args:
app: role id, read for its ``meta/services.yml`` declaration.
run_pool: what the run permits, already narrowed by its own input.
services: the roles the row's variant deploys, each narrowing the
row like the role's own declaration.
Raises:
SystemExit: the role and the run permit nothing in common. Dropping
the row instead would report a green run for a role that never
deployed, and picking one anyway would deploy it on hardware one
of the two sides ruled out.
"""
allowed = tuple(run_pool)
declarations: list[str] = []
for role in (app, *services):
declared = get_role_architectures(role)
if declared:
declarations.append(f"{role} ({', '.join(declared)})")
allowed = tuple(value for value in allowed if value in declared)
if not allowed:
raise SystemExit(
f"{app}: meta/services.yml declares architectures for "
f"{'; '.join(declarations)}, and this run permits "
f"{', '.join(run_pool) or 'none'}. Widen the run's architecture "
f"pool or the declarations."
)
return allowed