mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
90 lines
3.3 KiB
Python
90 lines
3.3 KiB
Python
"""Unit tests for :mod:`utils.install.npm`."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import subprocess
|
|
import unittest
|
|
import unittest.mock as mock
|
|
|
|
from utils.install import npm as npm_mod
|
|
|
|
|
|
class TestEnsureNpmPresent(unittest.TestCase):
|
|
def test_present_noop(self) -> None:
|
|
with (
|
|
mock.patch.object(npm_mod.shutil, "which", return_value="/usr/bin/npm"),
|
|
mock.patch(
|
|
"utils.install.system_pkg.install_command_via_pkg"
|
|
) as install_pkg,
|
|
):
|
|
npm_mod.ensure_npm_present()
|
|
install_pkg.assert_not_called()
|
|
|
|
def test_installs_via_system_pkg(self) -> None:
|
|
whiches = iter([None, "/usr/bin/npm"])
|
|
with (
|
|
mock.patch.object(
|
|
npm_mod.shutil, "which", side_effect=lambda _x: next(whiches)
|
|
),
|
|
mock.patch(
|
|
"utils.install.system_pkg.install_command_via_pkg"
|
|
) as install_pkg,
|
|
):
|
|
npm_mod.ensure_npm_present()
|
|
install_pkg.assert_called_once_with("npm")
|
|
|
|
def test_raises_when_still_missing(self) -> None:
|
|
with (
|
|
mock.patch.object(npm_mod.shutil, "which", return_value=None),
|
|
mock.patch("utils.install.system_pkg.install_command_via_pkg"),
|
|
):
|
|
self.assertRaises(RuntimeError, npm_mod.ensure_npm_present)
|
|
|
|
|
|
class TestNpmInstallGlobal(unittest.TestCase):
|
|
def test_global_success(self) -> None:
|
|
with (
|
|
mock.patch.object(npm_mod, "ensure_npm_present"),
|
|
mock.patch.object(npm_mod, "install_with_optional_sudo") as installer,
|
|
):
|
|
npm_mod.npm_install_global("markdownlint-cli2")
|
|
installer.assert_called_once_with(["npm", "install", "-g", "markdownlint-cli2"])
|
|
|
|
def test_fallback_to_prefix(self) -> None:
|
|
err = subprocess.CalledProcessError(returncode=1, cmd=["npm"])
|
|
with (
|
|
mock.patch.object(npm_mod, "ensure_npm_present"),
|
|
mock.patch.object(npm_mod, "install_with_optional_sudo", side_effect=err),
|
|
mock.patch.object(npm_mod.Path, "mkdir"),
|
|
mock.patch.object(npm_mod, "ensure_dir_on_path"),
|
|
mock.patch.object(npm_mod.subprocess, "run") as run,
|
|
):
|
|
npm_mod.npm_install_global("markdownlint-cli2")
|
|
called_cmd = run.call_args.args[0]
|
|
self.assertIn("--prefix", called_cmd)
|
|
self.assertEqual(called_cmd[-1], "markdownlint-cli2")
|
|
|
|
|
|
class TestNpmInstallLocalInRepo(unittest.TestCase):
|
|
def test_uses_ci_when_lockfile_present(self) -> None:
|
|
with (
|
|
mock.patch.object(npm_mod, "ensure_npm_present"),
|
|
mock.patch.object(npm_mod.Path, "is_file", return_value=True),
|
|
mock.patch.object(npm_mod.subprocess, "run") as run,
|
|
):
|
|
npm_mod.npm_install_local_in_repo("/repo")
|
|
self.assertEqual(run.call_args.args[0][:2], ["npm", "ci"])
|
|
|
|
def test_uses_install_without_lockfile(self) -> None:
|
|
with (
|
|
mock.patch.object(npm_mod, "ensure_npm_present"),
|
|
mock.patch.object(npm_mod.Path, "is_file", return_value=False),
|
|
mock.patch.object(npm_mod.subprocess, "run") as run,
|
|
):
|
|
npm_mod.npm_install_local_in_repo("/repo")
|
|
self.assertEqual(run.call_args.args[0][:2], ["npm", "install"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|