Kevin Veen-Birkenbach 8b2f0ac47b
refactor(web-app-espocrm): improve config patching and container vars
- Replace `ESPOCRM_NAME` with `ESPOCRM_CONTAINER` for clarity and consistency.
- Drop unused `ESPOCRM_CONFIG_FILE_PUBLIC`, rely only on `config-internal.php`.
- Make DB credential patching idempotent using `grep` + `sed` checks.
- Replace direct sed edits for maintenance/cron/cache with EspoCRM ConfigWriter.
- Add fallback execution as root if www-data user cannot write config.
- Clear EspoCRM cache only when config changes and in update mode.
- Remove obsolete OIDC scopes inline task (now handled via env/vars).
- Fix docker-compose template to use `ESPOCRM_CONTAINER`.

This refactor makes the EspoCRM role more robust, idempotent, and aligned
with EspoCRM’s official ConfigWriter mechanism.

See conversation: https://chatgpt.com/share/68a87820-12f8-800f-90d6-01ba97a1b279
2025-08-22 16:01:48 +02:00

111 lines
4.5 KiB
YAML

- name: Update DB host (idempotent)
command: >
docker exec --user root {{ ESPOCRM_CONTAINER }} sh -lc
"grep -q \"'host' *=> *'{{ database_host }}',\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} ||
{ sed -i \"s/'host'\\s*=>\\s*[^,]*,/'host' => '{{ database_host }}',/\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} && echo CHANGED; }"
register: db_host_set
changed_when: "'CHANGED' in db_host_set.stdout"
notify: docker compose restart
- name: Update DB name (idempotent)
command: >
docker exec --user root {{ ESPOCRM_CONTAINER }} sh -lc
"grep -q \"'dbname' *=> *'{{ database_name }}',\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} ||
{ sed -i \"s/'dbname'\\s*=>\\s*[^,]*,/'dbname' => '{{ database_name }}',/\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} && echo CHANGED; }"
register: db_name_set
changed_when: "'CHANGED' in db_name_set.stdout"
notify: docker compose restart
- name: Update DB user (idempotent)
command: >
docker exec --user root {{ ESPOCRM_CONTAINER }} sh -lc
"grep -q \"'user' *=> *'{{ database_username }}',\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} ||
{ sed -i \"s/'user'\\s*=>\\s*[^,]*,/'user' => '{{ database_username }}',/\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} && echo CHANGED; }"
register: db_user_set
changed_when: "'CHANGED' in db_user_set.stdout"
notify: docker compose restart
- name: Update DB password (idempotent)
command: >
docker exec --user root {{ ESPOCRM_CONTAINER }} sh -lc
"grep -q \"'password' *=> *'{{ database_password }}',\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} ||
{ sed -i \"s/'password'\\s*=>\\s*[^,]*,/'password' => '{{ database_password }}',/\" {{ ESPOCRM_CONFIG_FILE_PRIVATE }} && echo CHANGED; }"
register: db_pass_set
changed_when: "'CHANGED' in db_pass_set.stdout"
notify: docker compose restart
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
- name: Ensure siteUrl matches canonical domain
ansible.builtin.shell: |
docker compose exec -T web php -r '
require "/var/www/html/bootstrap.php";
$app = new \Espo\Core\Application();
$c = $app->getContainer();
$cfg = $c->get("config");
$writer = $c->get("injectableFactory")->create("\Espo\Core\Utils\Config\ConfigWriter");
$new = "{{ ESPOCRM_URL }}";
if ($cfg->get("siteUrl") !== $new) {
$writer->set("siteUrl", $new);
$writer->save();
echo "CHANGED";
}
'
args:
chdir: "{{ docker_compose.directories.instance }}"
register: siteurl_set
changed_when: "'CHANGED' in siteurl_set.stdout"
- name: Ensure maintenance off, cron on, cache on (idempotent via ConfigWriter)
block:
- name: Apply config via ConfigWriter as app user
command: >
docker exec --user {{ ESPOCRM_USER }} {{ ESPOCRM_CONTAINER }}
php -r '
require "/var/www/html/bootstrap.php";
$app = new \Espo\Core\Application();
$c = $app->getContainer();
$cfg = $c->get("config");
$w = $c->get("injectableFactory")->create("\Espo\Core\Utils\Config\ConfigWriter");
$pairs = [
"maintenanceMode" => false,
"cronDisabled" => false,
"useCache" => true
];
$changed = false;
foreach ($pairs as $k => $v) {
if ($cfg->get($k) !== $v) { $w->set($k, $v); $changed = true; }
}
if ($changed) { $w->save(); echo "CHANGED"; }
'
register: cfg_set
changed_when: "'CHANGED' in cfg_set.stdout"
rescue:
- name: Apply config via ConfigWriter as root (fallback)
command: >
docker exec --user root {{ ESPOCRM_CONTAINER }}
php -r '
require "/var/www/html/bootstrap.php";
$app = new \Espo\Core\Application();
$c = $app->getContainer();
$cfg = $c->get("config");
$w = $c->get("injectableFactory")->create("\Espo\Core\Utils\Config\ConfigWriter");
$pairs = [
"maintenanceMode" => false,
"cronDisabled" => false,
"useCache" => true
];
$changed = false;
foreach ($pairs as $k => $v) {
if ($cfg->get($k) !== $v) { $w->set($k, $v); $changed = true; }
}
if ($changed) { $w->save(); echo "CHANGED"; }
'
register: cfg_set
changed_when: "'CHANGED' in cfg_set.stdout"
- name: Clear EspoCRM cache (only when config changed and we are updating)
command: >
docker exec --user {{ ESPOCRM_USER }} {{ ESPOCRM_CONTAINER }} php clear_cache.php
when: "'CHANGED' in cfg_set.stdout and MODE_UPDATE | bool"