mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-11 13:17:07 +00:00
kevinveenbirkenbach
505af3e2ad
- Change --log flag to require explicit log directory (--log <LOG_DIR>) - Automatically create log directory with parents=True - Harden permissions best-effort (0700) - Update CLI help text accordingly - Adjust Makefile test targets to pass explicit log directory - Ignore logs/ via .gitignore and .dockerignore - Refactor flag parsing to correctly detect deploy with --log - Add dedicated logging unit tests - Update existing tests for new log semantics - Remove deprecated -i alias for --id in deploy command https://chatgpt.com/share/6969680a-dbf8-800f-aafb-3d32d6212ba0
89 lines
3.2 KiB
Python
89 lines
3.2 KiB
Python
import sys
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
from cli.core.app import parse_flags, main as app_main
|
|
|
|
|
|
class TestApp(unittest.TestCase):
|
|
def test_parse_flags_log_only_for_deploy(self):
|
|
# --log is ignored for non-deploy commands; it is removed from argv
|
|
argv = ["infinito", "--log", "/tmp/infinito-logs", "build", "tree"]
|
|
flags = parse_flags(argv)
|
|
self.assertIsNone(flags.log_dir)
|
|
self.assertNotIn("--log", argv)
|
|
self.assertNotIn("/tmp/infinito-logs", argv)
|
|
|
|
# --log is accepted for deploy; it is removed from argv and stored in flags
|
|
argv2 = ["infinito", "--log", "/tmp/infinito-logs", "deploy", "container"]
|
|
flags2 = parse_flags(argv2)
|
|
self.assertEqual(flags2.log_dir, Path("/tmp/infinito-logs"))
|
|
self.assertNotIn("--log", argv2)
|
|
self.assertNotIn("/tmp/infinito-logs", argv2)
|
|
|
|
def test_parse_flags_log_requires_argument(self):
|
|
# Missing argument: '--log' is followed by another flag (or end of argv)
|
|
argv = ["infinito", "--log", "--git-clean", "deploy", "container"]
|
|
with self.assertRaises(SystemExit) as cm:
|
|
parse_flags(argv)
|
|
self.assertEqual(cm.exception.code, 1)
|
|
|
|
argv2 = ["infinito", "--log"]
|
|
with self.assertRaises(SystemExit) as cm2:
|
|
parse_flags(argv2)
|
|
self.assertEqual(cm2.exception.code, 1)
|
|
|
|
def test_parse_flags_alarm_timeout(self):
|
|
argv = ["infinito", "--alarm-timeout", "5", "deploy", "container"]
|
|
flags = parse_flags(argv)
|
|
self.assertEqual(flags.alarm_timeout, 5)
|
|
self.assertNotIn("--alarm-timeout", argv)
|
|
|
|
@patch("cli.core.app.init_multiprocessing")
|
|
@patch(
|
|
"cli.core.app.resolve_command_module",
|
|
return_value=("cli.deploy.container.command.command", ["--x"]),
|
|
)
|
|
@patch("cli.core.app.run_command_once", return_value=True)
|
|
def test_app_main_dispatches_to_resolved_module(
|
|
self, _mock_run, _mock_resolve, _mock_init
|
|
):
|
|
old_argv = sys.argv
|
|
try:
|
|
sys.argv = ["infinito", "deploy", "container", "--x"]
|
|
with self.assertRaises(SystemExit) as cm:
|
|
app_main()
|
|
self.assertEqual(cm.exception.code, 0)
|
|
finally:
|
|
sys.argv = old_argv
|
|
|
|
@patch("cli.core.app.init_multiprocessing")
|
|
@patch("cli.core.app.resolve_command_module", return_value=(None, ["nope"]))
|
|
def test_app_main_unknown_command_exits_1(self, _mock_resolve, _mock_init):
|
|
old_argv = sys.argv
|
|
try:
|
|
sys.argv = ["infinito", "nope"]
|
|
with self.assertRaises(SystemExit) as cm:
|
|
app_main()
|
|
self.assertEqual(cm.exception.code, 1)
|
|
finally:
|
|
sys.argv = old_argv
|
|
|
|
@patch("cli.core.app.init_multiprocessing")
|
|
@patch("cli.core.app.print_global_help")
|
|
def test_app_main_global_help(self, mock_help, _mock_init):
|
|
old_argv = sys.argv
|
|
try:
|
|
sys.argv = ["infinito", "--help"]
|
|
with self.assertRaises(SystemExit) as cm:
|
|
app_main()
|
|
self.assertEqual(cm.exception.code, 0)
|
|
self.assertTrue(mock_help.called)
|
|
finally:
|
|
sys.argv = old_argv
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|