mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 11:46:35 +00:00
The merge brought in main's new roles and carried this branch's cross-cutting renames and lints past them, so files that never conflicted were left inconsistent. make quality-high is green again: 4 test targets, 15 lint targets.a05071fe78renamed get_entity_name to entity_name. Three files main added still used the old name and merged cleanly because this branch never touched them: plugins/lookup/email.py raised ImportError on import, which also took down sys-ctl-hlth-msmtp's mail_recipient lookup; web-app-stalwart/tasks/00_core.yml applied `| get_entity_name`, a filter that does not exist (the registration in plugins/filter/get/entity_name.py is `entity_name`), so a compose deploy of stalwart would have failed while rendering sys-stk-front-proxy's vars; and test_database.py patched a name the module no longer binds. web-app-stalwart and web-app-mailu spell DEPLOYMENT_MODE out in 15 places. The named booleans in group_vars/all/18_swarm.yml are the SPOT and the bare form is the idiom: 177 existing uses, and web-app-listmonk/tasks/utils/mcp.yml:42,49 drives both as mutually exclusive `when:` conditions, which a truthy string would break. svc-net-tor-smtp pinned aiosmtpd and PySocks inside its Dockerfile, where Dependabot cannot see them. The pins move to files/requirements.txt; since sys-svc-compose stages only the Dockerfile, 00_core.yml now stages the requirements file into the build context too. stalwart's webui_version had no upstream declared. Its three inline `environment:` blocks stay, with a nocheck each: the role sets no docker_compose_env, so one templates/env.j2 would also be the env_file of the sibling containers, and clamav would receive the recovery admin credential and the OIDC client secret. The 13 bindings in stalwart's playwright env.js defaulted to "" and were consumed unconditionally. Every key is emitted unconditionally by playwright.env.j2 from a lookup that fails rather than yields empty, and OIDC_ISSUER_URL always concatenates the realm path, so requireDotenvValue is the correct binding. gitlab's adminUsername gets the toBeTruthy guard its two siblings already had. web-svc-api and svc-cache-package collided with stalwart on local.http 8094 and 8095 and move to 8098 and 8099, which exhausts the 8001-8099 band. svc-ai-agent-broker collided with stalwart on 192.168.223.0/24 and moves to 192.168.81.0/24; the suggester only subdivides blocks already in use at the requested prefix, so the move was validated with --block. web-app-weblate calls lookup('email') without emitting lookup('container_extra_hosts'), so on an onion deploy its SMTP client drops every message without an error. test_main.py read the primary domain from a literal while main moved INFINITO_DOMAIN to main.infinito.test. It now takes the value from default_domain_primary(), in the shapee2beab9f1cuses on feature/web-app-wazuh/add-role, so that branch merges here without a conflict. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>