mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
141 lines
5.0 KiB
Python
141 lines
5.0 KiB
Python
"""Unit tests for the container_healthcheck lookup plugin.
|
|
|
|
Pins that values taken straight out of the play vars are templated before
|
|
use. ``include_role: vars:`` hands them over unrendered, so under
|
|
``sys-stk-full`` ``application_id`` arrives as the literal string
|
|
``{{ sys_stk_full_application_id }}``, and the same holds for a
|
|
``healthcheck.hostname`` read out of the service config.
|
|
|
|
Also pins that the ``container_hostname`` play var never reaches the probe's
|
|
HTTP ``Host`` header: it is computed for ``sethostname(2)`` and clamped to 63
|
|
bytes, so on a v3 onion deployment it degrades to the bare entity name and the
|
|
app rejects it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import unittest
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
SERVICES = {
|
|
"web-app-dashboard": {
|
|
"services.dashboard.healthcheck": {"flavor": "tcp", "start_period": "10m"},
|
|
"services.dashboard.ports.internal.http": 5000,
|
|
},
|
|
"web-app-x": {
|
|
"services.web.healthcheck": {"flavor": "curl", "samples": 2},
|
|
"services.web.ports.internal.http": 8080,
|
|
},
|
|
"web-app-host": {
|
|
"services.web.healthcheck": {
|
|
"flavor": "curl",
|
|
"hostname": "{{ lookup('domain', application_id) }}",
|
|
},
|
|
"services.web.ports.internal.http": 8080,
|
|
},
|
|
"web-app-bare": {},
|
|
}
|
|
|
|
|
|
def _load_lookup():
|
|
spec = importlib.util.spec_from_file_location(
|
|
"lookup_container_healthcheck",
|
|
str(PROJECT_ROOT / "plugins/lookup/container_healthcheck.py"),
|
|
)
|
|
mod = importlib.util.module_from_spec(spec)
|
|
assert spec and spec.loader
|
|
spec.loader.exec_module(mod)
|
|
return mod
|
|
|
|
|
|
class _DummyTemplar:
|
|
def __init__(self, available_variables=None, rendered=None):
|
|
self.available_variables = available_variables or {}
|
|
self.rendered = rendered or {}
|
|
|
|
def template(self, value):
|
|
return self.rendered[value]
|
|
|
|
|
|
class _DummyConfigLookup:
|
|
def run(self, terms, variables=None):
|
|
application_id, path, default = terms[0], terms[1], terms[2]
|
|
return [SERVICES.get(application_id, {}).get(path, default)]
|
|
|
|
|
|
class TestContainerHealthcheckLookup(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.mod = _load_lookup()
|
|
|
|
def setUp(self):
|
|
self.original_loader = self.mod.lookup_loader
|
|
self.mod.lookup_loader = type(
|
|
"_Loader", (), {"get": staticmethod(lambda *a, **kw: _DummyConfigLookup())}
|
|
)()
|
|
|
|
def tearDown(self):
|
|
self.mod.lookup_loader = self.original_loader
|
|
|
|
def _make(self, variables, rendered=None):
|
|
lm = self.mod.LookupModule()
|
|
lm._templar = _DummyTemplar(variables, rendered)
|
|
lm._loader = None
|
|
return lm
|
|
|
|
def test_unrendered_application_id_is_templated(self):
|
|
vars_ = {
|
|
"application_id": "{{ sys_stk_full_application_id }}",
|
|
"sys_stk_full_application_id": "web-app-dashboard",
|
|
}
|
|
rendered = {"{{ sys_stk_full_application_id }}": "web-app-dashboard"}
|
|
block = self._make(vars_, rendered).run(["dashboard"], variables=vars_)[0]
|
|
self.assertIn("/dev/tcp/localhost/5000", block)
|
|
self.assertIn("start_period: 10m", block)
|
|
|
|
def test_unrendered_healthcheck_hostname_is_templated(self):
|
|
vars_ = {"application_id": "web-app-host"}
|
|
rendered = {"{{ lookup('domain', application_id) }}": "x.example.com"}
|
|
block = self._make(vars_, rendered).run(["web"], variables=vars_)[0]
|
|
self.assertIn("Host: x.example.com", block)
|
|
self.assertNotIn("lookup(", block)
|
|
|
|
def test_container_hostname_play_var_never_reaches_the_host_header(self):
|
|
vars_ = {"application_id": "web-app-x", "container_hostname": "bookwyrm"}
|
|
block = self._make(vars_).run(["web"], variables=vars_)[0]
|
|
self.assertNotIn("Host:", block)
|
|
|
|
def test_plain_application_id_passes_through(self):
|
|
vars_ = {"application_id": "web-app-dashboard"}
|
|
block = self._make(vars_).run(["dashboard"], variables=vars_)[0]
|
|
self.assertIn("/dev/tcp/localhost/5000", block)
|
|
|
|
def test_missing_flavor_and_test_raises(self):
|
|
vars_ = {"application_id": "web-app-bare"}
|
|
with self.assertRaises(AnsibleError) as ctx:
|
|
self._make(vars_).run(["bare"], variables=vars_)
|
|
self.assertIn("web-app-bare", str(ctx.exception))
|
|
|
|
def test_missing_application_id_raises(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self._make({}).run(["web"], variables={})
|
|
|
|
def test_missing_service_name_raises(self):
|
|
with self.assertRaises(AnsibleError):
|
|
self._make({}).run([], variables={})
|
|
|
|
def test_unrendered_leftover_template_raises(self):
|
|
vars_ = {"application_id": "{{ untrusted }}"}
|
|
rendered = {"{{ untrusted }}": "{{ untrusted }}"}
|
|
with self.assertRaises(AnsibleError) as ctx:
|
|
self._make(vars_, rendered).run(["web"], variables=vars_)
|
|
self.assertIn("did not render", str(ctx.exception))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|