mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
9f179e8edc
Host and container share this checkout through a bind mount but run as different uids -- 1000 and 0, measured. Whichever writes .ruff_cache or .import_linter_cache first owns it, and the other is then locked out: ruff aborts with "Failed to create temporary file: Permission denied" and test_import_contracts fails the same way, reporting a broken contract that is in fact perfectly intact. Point both at build/<tool>-cache-$(id -u). build/ is already 0777 and gitignored, and this is the mechanism the lint stamp (build/install-lint-<hash>.stamp) already uses to keep the two environments apart. Passing --no-cache would have silenced the symptom at the cost of the cache on every single run. The pre-existing .ruff_cache and .import_linter_cache are nobody-owned and cannot be removed without root; they are simply unused from now on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
64 lines
2.0 KiB
Python
64 lines
2.0 KiB
Python
"""Lint guard: import-linter architectural contracts MUST hold.
|
|
|
|
Background
|
|
==========
|
|
CodeQL ``py/unsafe-cyclic-import`` repeatedly flagged the dev/CI deploy
|
|
package ``cli.administration.deploy.development`` (compose <-> common <->
|
|
deps). Static linters (ruff) do not model the module-import graph, so
|
|
they cannot catch a re-introduced cycle. import-linter does.
|
|
|
|
The contracts live in ``[tool.importlinter]`` in ``pyproject.toml``; this
|
|
test runs them so a cycle regression fails CI rather than only surfacing
|
|
later in a CodeQL scan. Run them directly with ``lint-imports``.
|
|
|
|
Skip behaviour
|
|
==============
|
|
import-linter is a dev dependency (``pip install .[dev]`` /
|
|
``make install-python-dev``). Where it is absent the test skips rather
|
|
than fails, so a minimal runtime-only environment is not blocked; CI
|
|
installs the dev extra and therefore enforces the contracts.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import unittest
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
_LINT_IMPORTS = shutil.which("lint-imports")
|
|
|
|
|
|
class TestImportContracts(unittest.TestCase):
|
|
"""The ``[tool.importlinter]`` contracts in ``pyproject.toml`` hold."""
|
|
|
|
@unittest.skipUnless(
|
|
_LINT_IMPORTS,
|
|
"import-linter not installed; run `make install-python-dev`",
|
|
)
|
|
def test_import_linter_contracts_hold(self) -> None:
|
|
env = dict(os.environ)
|
|
env["PYTHONPATH"] = os.pathsep.join(
|
|
p for p in (str(PROJECT_ROOT), env.get("PYTHONPATH", "")) if p
|
|
)
|
|
cache_dir = PROJECT_ROOT / "build" / f"import-linter-cache-{os.getuid()}"
|
|
result = subprocess.run(
|
|
[_LINT_IMPORTS, "--cache-dir", str(cache_dir)],
|
|
cwd=str(PROJECT_ROOT),
|
|
env=env,
|
|
capture_output=True,
|
|
text=True,
|
|
check=False,
|
|
)
|
|
self.assertEqual(
|
|
result.returncode,
|
|
0,
|
|
msg="import-linter contracts broken:\n" + result.stdout + result.stderr,
|
|
)
|
|
|
|
|
|
if __name__ == "__main__": # pragma: no cover
|
|
unittest.main()
|