mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 19:56:53 +00:00
kevinveenbirkenbachandClaude Opus 5
f0c2f2fbbf
Every unit test for a shell script sat flat in tests/unit/scripts/ with the path encoded into the filename - test_worktree_lib.py, test_filesystem_resolve.py, test_swarm_diagnostics_routing.py. Finding the test for a script meant guessing which words of its path had made it into the name. Mirror the layout instead, the way tests/unit/utils/ already does: scripts/system/worktree/lib.sh is now tested by tests/unit/scripts/system/worktree/test_lib.py. The name prefixes that stood in for directories disappear with them. Pure relocation - 0 insertions, 0 deletions. All eight moves are recorded as renames, so git log --follow still reaches the history. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
109 lines
4.0 KiB
Python
109 lines
4.0 KiB
Python
"""Contract of the shared worktree metadata helpers.
|
|
|
|
``worktree_unregister`` is what lets a teardown succeed under the agent sandbox,
|
|
which pins some files inside ``.git/worktrees/<id>`` as read-only bind mounts so
|
|
the directory cannot be unlinked. Its three outcomes drive both callers: fully
|
|
removed, unregistered but pinned, and still registered. The last one is the only
|
|
state that keeps a branch claimed, so it must never be reported as success.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import stat
|
|
import subprocess
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from utils.cache.files import PROJECT_ROOT
|
|
|
|
LIB = PROJECT_ROOT / "scripts" / "system" / "worktree" / "lib.sh"
|
|
NEEDS_UNPRIVILEGED = "clearing the write bit does not restrain root"
|
|
|
|
|
|
def _call(func: str, *args: str) -> subprocess.CompletedProcess:
|
|
return subprocess.run(
|
|
["bash", "-c", f'source "$1"; shift; {func} "$@"', "bash", str(LIB), *args],
|
|
capture_output=True,
|
|
text=True,
|
|
check=False,
|
|
)
|
|
|
|
|
|
class TestWorktreeMetaDir(unittest.TestCase):
|
|
def test_reads_the_gitdir_pointer(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
(Path(tmp) / ".git").write_text("gitdir: /somewhere/.git/worktrees/feat\n")
|
|
result = _call("worktree_meta_dir", tmp)
|
|
self.assertEqual(result.stdout.strip(), "/somewhere/.git/worktrees/feat")
|
|
|
|
def test_missing_git_file_yields_nothing(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
result = _call("worktree_meta_dir", tmp)
|
|
self.assertEqual(result.stdout.strip(), "")
|
|
|
|
def test_directory_git_yields_nothing(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
(Path(tmp) / ".git").mkdir()
|
|
result = _call("worktree_meta_dir", tmp)
|
|
self.assertEqual(result.stdout.strip(), "")
|
|
|
|
|
|
class TestWorktreeUnregister(unittest.TestCase):
|
|
def _entry(self, tmp: str) -> Path:
|
|
entry = Path(tmp) / "feat"
|
|
entry.mkdir()
|
|
(entry / "gitdir").write_text("/checkout/.git\n")
|
|
(entry / "HEAD").write_text("ref: refs/heads/feat\n")
|
|
(entry / "commondir").write_text("../..\n")
|
|
return entry
|
|
|
|
def test_removes_the_whole_entry(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
entry = self._entry(tmp)
|
|
result = _call("worktree_unregister", str(entry))
|
|
self.assertEqual(result.returncode, 0)
|
|
self.assertFalse(entry.exists())
|
|
|
|
@unittest.skipIf(os.geteuid() == 0, NEEDS_UNPRIVILEGED)
|
|
def test_pinned_directory_still_unregisters(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
entry = self._entry(tmp)
|
|
tmp_path = Path(tmp)
|
|
parent_mode = tmp_path.stat().st_mode
|
|
(entry / "gitdir").unlink()
|
|
(entry / "HEAD").unlink()
|
|
tmp_path.chmod(parent_mode & ~stat.S_IWUSR)
|
|
try:
|
|
result = _call("worktree_unregister", str(entry))
|
|
finally:
|
|
tmp_path.chmod(parent_mode)
|
|
self.assertEqual(result.returncode, 1)
|
|
self.assertTrue(entry.exists())
|
|
|
|
@unittest.skipIf(os.geteuid() == 0, NEEDS_UNPRIVILEGED)
|
|
def test_undeletable_pointers_report_still_registered(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
entry = self._entry(tmp)
|
|
mode = entry.stat().st_mode
|
|
entry.chmod(mode & ~stat.S_IWUSR)
|
|
try:
|
|
result = _call("worktree_unregister", str(entry))
|
|
finally:
|
|
entry.chmod(mode)
|
|
self.assertEqual(result.returncode, 2)
|
|
self.assertTrue((entry / "gitdir").exists())
|
|
|
|
def test_is_idempotent_on_a_half_emptied_entry(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
entry = self._entry(tmp)
|
|
(entry / "HEAD").unlink()
|
|
result = _call("worktree_unregister", str(entry))
|
|
self.assertEqual(result.returncode, 0)
|
|
self.assertFalse(entry.exists())
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|