mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
136 lines
4.5 KiB
Python
136 lines
4.5 KiB
Python
from __future__ import annotations
|
|
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from cli.administration.deploy.dedicated import modes
|
|
|
|
|
|
class TestParseBoolLiteral(unittest.TestCase):
|
|
def test_true_values(self):
|
|
self.assertTrue(modes._parse_bool_literal("true"))
|
|
self.assertTrue(modes._parse_bool_literal("True"))
|
|
self.assertTrue(modes._parse_bool_literal(" yes "))
|
|
self.assertTrue(modes._parse_bool_literal("ON"))
|
|
|
|
def test_false_values(self):
|
|
self.assertFalse(modes._parse_bool_literal("false"))
|
|
self.assertFalse(modes._parse_bool_literal("False"))
|
|
self.assertFalse(modes._parse_bool_literal(" no "))
|
|
self.assertFalse(modes._parse_bool_literal("off"))
|
|
|
|
def test_unknown_value(self):
|
|
self.assertIsNone(modes._parse_bool_literal("maybe"))
|
|
self.assertIsNone(modes._parse_bool_literal(""))
|
|
self.assertIsNone(modes._parse_bool_literal(" "))
|
|
|
|
|
|
class TestLoadModesFromYaml(unittest.TestCase):
|
|
def test_load_modes_basic(self):
|
|
content = """\
|
|
MODE_CLEANUP: true # cleanup before deploy
|
|
MODE_DEBUG: false # debug output
|
|
MODE_ASSERT: null # inventory assertion
|
|
OTHER_KEY: true # should be ignored (no MODE_ prefix)
|
|
"""
|
|
|
|
with tempfile.NamedTemporaryFile("w+", delete=False, encoding="utf-8") as f:
|
|
path = f.name
|
|
f.write(content)
|
|
f.flush()
|
|
|
|
try:
|
|
parsed = modes.load_modes_from_yaml(path)
|
|
finally:
|
|
Path(path).unlink()
|
|
|
|
self.assertEqual(len(parsed), 3)
|
|
by_name = {m["name"]: m for m in parsed}
|
|
|
|
self.assertIn("MODE_CLEANUP", by_name)
|
|
self.assertIn("MODE_DEBUG", by_name)
|
|
self.assertIn("MODE_ASSERT", by_name)
|
|
|
|
self.assertEqual(by_name["MODE_CLEANUP"]["default"], True)
|
|
self.assertEqual(by_name["MODE_DEBUG"]["default"], False)
|
|
self.assertIsNone(by_name["MODE_ASSERT"]["default"])
|
|
self.assertEqual(by_name["MODE_CLEANUP"]["help"], "cleanup before deploy")
|
|
|
|
def test_load_modes_ignores_non_mode_keys(self):
|
|
content = """\
|
|
FOO: true
|
|
BAR: false
|
|
MODE_FOO: true
|
|
"""
|
|
|
|
with tempfile.NamedTemporaryFile("w+", delete=False, encoding="utf-8") as f:
|
|
path = f.name
|
|
f.write(content)
|
|
f.flush()
|
|
|
|
try:
|
|
parsed = modes.load_modes_from_yaml(path)
|
|
finally:
|
|
Path(path).unlink()
|
|
|
|
self.assertEqual(len(parsed), 1)
|
|
self.assertEqual(parsed[0]["name"], "MODE_FOO")
|
|
|
|
|
|
class TestDynamicModes(unittest.TestCase):
|
|
def setUp(self):
|
|
self.modes_meta = [
|
|
{"name": "MODE_CLEANUP", "default": True, "help": "Cleanup before run"},
|
|
{"name": "MODE_DEBUG", "default": False, "help": "Debug output"},
|
|
{"name": "MODE_ASSERT", "default": None, "help": "Inventory assertion"},
|
|
]
|
|
|
|
def test_add_dynamic_mode_args_and_build_modes_defaults(self):
|
|
from argparse import ArgumentParser
|
|
|
|
parser = ArgumentParser()
|
|
spec = modes.add_dynamic_mode_args(parser, self.modes_meta)
|
|
|
|
self.assertIn("MODE_CLEANUP", spec)
|
|
self.assertIn("MODE_DEBUG", spec)
|
|
self.assertIn("MODE_ASSERT", spec)
|
|
|
|
args = parser.parse_args([])
|
|
resolved = modes.build_modes_from_args(spec, args)
|
|
|
|
self.assertTrue(resolved["MODE_CLEANUP"]) # default True
|
|
self.assertFalse(resolved["MODE_DEBUG"]) # default False
|
|
self.assertNotIn("MODE_ASSERT", resolved) # explicit, not set
|
|
|
|
def test_add_dynamic_mode_args_and_build_modes_flags_true(self):
|
|
from argparse import ArgumentParser
|
|
|
|
parser = ArgumentParser()
|
|
spec = modes.add_dynamic_mode_args(parser, self.modes_meta)
|
|
|
|
args = parser.parse_args(["--skip-cleanup", "--debug", "--assert", "true"])
|
|
resolved = modes.build_modes_from_args(spec, args)
|
|
|
|
self.assertFalse(resolved["MODE_CLEANUP"])
|
|
self.assertTrue(resolved["MODE_DEBUG"])
|
|
self.assertTrue(resolved["MODE_ASSERT"])
|
|
|
|
def test_add_dynamic_mode_args_and_build_modes_flags_false_explicit(self):
|
|
from argparse import ArgumentParser
|
|
|
|
parser = ArgumentParser()
|
|
spec = modes.add_dynamic_mode_args(parser, self.modes_meta)
|
|
|
|
args = parser.parse_args(["--assert", "false"])
|
|
resolved = modes.build_modes_from_args(spec, args)
|
|
|
|
self.assertTrue(resolved["MODE_CLEANUP"])
|
|
self.assertFalse(resolved["MODE_DEBUG"])
|
|
self.assertIn("MODE_ASSERT", resolved)
|
|
self.assertFalse(resolved["MODE_ASSERT"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|