mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-11 21:26:44 +00:00
kevinveenbirkenbachandClaude Opus 5
4ee5802149
make quality failed on three ruff errors, all in the CI deploy-sequencing work: RUF007 twice in test_ci_deploy_sequencing.py and TID252 in tests/utils/ci/job_names.py. autoformat is chained ahead of test, so the whole test stage never ran while they stood. zip(CHAIN, CHAIN[1:], strict=False) becomes pairwise(CHAIN). Same two pairs over the three-element chain, but strict=False was switching off a length check that this call genuinely needs -- CHAIN[1:] is shorter by construction, so strict=True would raise. pairwise has no second sequence and cannot have the problem, so the suppression goes away with its reason. Both assertIn calls fit on one line again as a result; that reflow is ruff format's, not a hand-made edit. job_names.py was the only file reaching PROJECT_ROOT through a relative parent import; test_ci_deploy_sequencing.py:20 already spells it absolutely. Verified rather than assumed: make quality now green end to end (ruff in the ran list, all four targets green, 4030 + 299 passed). The sequencing file on its own reports the same 24 subtests as before the change, so pairwise yields the identical pair set and not merely a passing one. All four importers of job_names run green (60 passed), which is what rules out the absolute import resolving differently under another sys.path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>