mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 11:46:35 +00:00
kevinveenbirkenbachandClaude Opus 5
549d272884
Seven lookups read application_id out of the play's variables and every one of them has to template it, because sys-stk-full defines application_id from sys_stk_full_application_id and a dict read returns that unrendered. They did it in five spellings: a public resolve_var, two byte-identical private copies, and inline variants. Nothing named the rule, so it survived as folklore, and a lookup written without knowing it took down three jobs of one run. resolve_var now lives in utils/templating, which is where the six lookups that import it can reach it without pulling in a networking module for a concern that is not networking. utils/networks/lookup_context re-exports it under the alias form, so its own importers are untouched and autodoc still resolves one target. The two private copies go, and so does the fourth copy this branch added to webserver_resource a few commits ago. The private copies guarded value is not None and the public one did not. The canonical keeps the guard: it is narrower than every live caller, each of which passes a defaulted value, so no existing call can reach the branch. The helper had no test at all. Its six behaviours are characterised first, including that a templar raising on an undefined variable leaves the value alone rather than failing the play, which is what the suppression is for. Four inline copies stay. compose_volumes lets a template error propagate where this suppresses it, and mcp_servers only templates a str containing a template marker. Folding those in would change behaviour, which is not a refactor. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
45 lines
1.5 KiB
Python
45 lines
1.5 KiB
Python
import unittest
|
|
|
|
from utils.templating.vars import resolve_var
|
|
|
|
|
|
class _Templar:
|
|
def __init__(self, resolved=None, raises=False):
|
|
self._resolved = resolved or {}
|
|
self._raises = raises
|
|
|
|
def template(self, value):
|
|
if self._raises:
|
|
raise RuntimeError("undefined variable")
|
|
return self._resolved.get(value, value)
|
|
|
|
|
|
class TestResolveVar(unittest.TestCase):
|
|
def test_a_template_is_resolved(self):
|
|
templar = _Templar({"{{ stack_app }}": "web-app-docs"})
|
|
self.assertEqual(resolve_var(templar, "{{ stack_app }}"), "web-app-docs")
|
|
|
|
def test_a_plain_value_survives(self):
|
|
self.assertEqual(resolve_var(_Templar(), "web-app-docs"), "web-app-docs")
|
|
|
|
def test_without_a_templar_the_value_is_returned_as_is(self):
|
|
self.assertEqual(resolve_var(None, "{{ stack_app }}"), "{{ stack_app }}")
|
|
|
|
def test_none_is_returned_as_is(self):
|
|
self.assertIsNone(resolve_var(_Templar(), None))
|
|
|
|
def test_a_raising_templar_leaves_the_value_alone(self):
|
|
"""A lookup asks before the variable is necessarily defined, so a
|
|
failure to render must not take the play down here."""
|
|
self.assertEqual(
|
|
resolve_var(_Templar(raises=True), "{{ stack_app }}"), "{{ stack_app }}"
|
|
)
|
|
|
|
def test_a_non_string_is_passed_through_the_templar(self):
|
|
templar = _Templar()
|
|
self.assertEqual(resolve_var(templar, {"a": 1}), {"a": 1})
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|