mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-09 04:06:42 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
49 lines
1.6 KiB
Python
49 lines
1.6 KiB
Python
"""Contract between the swarm drill's completion marker and the roundtrip gate."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
import unittest
|
|
|
|
from utils.cache.files import PROJECT_ROOT, read_text
|
|
|
|
DRILL = (
|
|
PROJECT_ROOT / "scripts" / "tests" / "deploy" / "swarm" / "routine" / "00_one.sh"
|
|
)
|
|
GATE = PROJECT_ROOT / "scripts" / "tests" / "deploy" / "roundtrip.sh"
|
|
MARKER = "==> swarm drill complete: app="
|
|
|
|
|
|
class TestRoundtripMarker(unittest.TestCase):
|
|
def setUp(self) -> None:
|
|
self.drill = read_text(str(DRILL))
|
|
self.gate = read_text(str(GATE))
|
|
|
|
def test_the_drill_emits_the_marker(self) -> None:
|
|
self.assertIn(MARKER, self.drill)
|
|
|
|
def test_the_gate_looks_for_the_same_literal(self) -> None:
|
|
self.assertIn(MARKER, self.gate)
|
|
|
|
def test_the_marker_carries_the_app_id(self) -> None:
|
|
emitted = re.search(rf'echo "{re.escape(MARKER)}(\S+)', self.drill)
|
|
self.assertIsNotNone(emitted)
|
|
self.assertEqual(emitted.group(1), "${APP_ID}")
|
|
|
|
def test_the_app_id_is_guarded_against_being_empty(self) -> None:
|
|
self.assertIn(': "${APP_ID:?', self.drill)
|
|
|
|
def test_the_marker_is_emitted_after_the_state_assertion(self) -> None:
|
|
assertion = self.drill.index("07_assert_state.sh")
|
|
self.assertGreater(self.drill.index(MARKER), assertion)
|
|
|
|
def test_the_gate_matches_the_marker_as_a_fixed_string(self) -> None:
|
|
self.assertIn("grep -qF", self.gate)
|
|
|
|
def test_the_gate_no_longer_matches_a_workflow_step_name(self) -> None:
|
|
self.assertNotIn("provision/deploy/e2e/verify per round", self.gate)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|