mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
139 lines
4.6 KiB
Python
139 lines
4.6 KiB
Python
import unittest
|
|
|
|
from utils.storage.nfs import (
|
|
client_src,
|
|
fstype,
|
|
mount_opts,
|
|
state_path,
|
|
swarm_nfs_backed,
|
|
)
|
|
|
|
|
|
class TestNfsHelpers(unittest.TestCase):
|
|
def test_state_path(self):
|
|
self.assertEqual(
|
|
state_path("/srv/nfs", "infinito-state"), "/srv/nfs/infinito-state"
|
|
)
|
|
|
|
def test_fstype(self):
|
|
self.assertEqual(fstype(4), "nfs4")
|
|
self.assertEqual(fstype("4"), "nfs4")
|
|
self.assertEqual(fstype(3), "nfs")
|
|
|
|
def test_mount_opts_lab_runtimes_soft(self):
|
|
for rt in ("dev", "act", "github"):
|
|
self.assertEqual(mount_opts(4, rt), "vers=4,rw,soft,timeo=50,retrans=3")
|
|
|
|
def test_mount_opts_prod_hard(self):
|
|
self.assertEqual(mount_opts(4, "host"), "vers=4,rw,hard,timeo=600")
|
|
|
|
def test_mount_opts_v4_carries_no_v3_locking_token(self):
|
|
self.assertNotIn("local_lock", mount_opts(4, "host"))
|
|
self.assertNotIn("nolock", mount_opts(4, "host"))
|
|
|
|
def test_mount_opts_v3_still_disables_nlm(self):
|
|
self.assertEqual(mount_opts(3, "host"), "vers=3,rw,hard,timeo=600,nolock")
|
|
|
|
def test_client_src_kernel_v4_is_root(self):
|
|
self.assertEqual(
|
|
client_src("1.2.3.4", 4, "kernel", "/srv/nfs/infinito-state"), "1.2.3.4:/"
|
|
)
|
|
|
|
def test_client_src_ganesha_is_full_path(self):
|
|
self.assertEqual(
|
|
client_src("1.2.3.4", 4, "ganesha", "/srv/nfs/infinito-state"),
|
|
"1.2.3.4:/srv/nfs/infinito-state",
|
|
)
|
|
|
|
def test_client_src_v3_is_full_path(self):
|
|
self.assertEqual(
|
|
client_src("1.2.3.4", 3, "kernel", "/srv/nfs/infinito-state"),
|
|
"1.2.3.4:/srv/nfs/infinito-state",
|
|
)
|
|
|
|
|
|
class TestSwarmNfsBacked(unittest.TestCase):
|
|
"""The predicate mirrors the compose_volumes rewrite decision: swarm mode
|
|
with an nfs backend backs every volume of a non-manager-pinned role unless
|
|
the entry opts out with ``nfs: false``. web-app-nextcloud carries no
|
|
placement pin; web-app-seaweedfs is pinned to the manager on purpose."""
|
|
|
|
def test_backed_in_swarm_with_nfs(self):
|
|
self.assertTrue(
|
|
swarm_nfs_backed(
|
|
{"name": "nextcloud_data"},
|
|
application_id="web-app-nextcloud",
|
|
deployment_mode="swarm",
|
|
storage_backend="nfs",
|
|
)
|
|
)
|
|
|
|
def test_compose_mode_never_backs(self):
|
|
self.assertFalse(
|
|
swarm_nfs_backed(
|
|
{"name": "nextcloud_data"},
|
|
application_id="web-app-nextcloud",
|
|
deployment_mode="compose",
|
|
storage_backend="nfs",
|
|
)
|
|
)
|
|
|
|
def test_local_backend_never_backs(self):
|
|
self.assertFalse(
|
|
swarm_nfs_backed(
|
|
{"name": "nextcloud_data"},
|
|
application_id="web-app-nextcloud",
|
|
deployment_mode="swarm",
|
|
storage_backend="local",
|
|
)
|
|
)
|
|
|
|
def test_a_manager_pinned_role_stays_node_local(self):
|
|
self.assertFalse(
|
|
swarm_nfs_backed(
|
|
{"name": "seaweedfs_data"},
|
|
application_id="web-app-seaweedfs",
|
|
deployment_mode="swarm",
|
|
storage_backend="nfs",
|
|
)
|
|
)
|
|
|
|
def test_nfs_false_opts_out(self):
|
|
self.assertFalse(
|
|
swarm_nfs_backed(
|
|
{"name": "gitaly_repos", "nfs": False},
|
|
application_id="web-app-gitlab",
|
|
deployment_mode="swarm",
|
|
storage_backend="nfs",
|
|
)
|
|
)
|
|
|
|
def test_a_role_forcing_compose_is_not_backed(self):
|
|
"""web-app-bigbluebutton pins compose_mode_force: compose in its vars,
|
|
so the rewrite leaves its volumes node-local even in a swarm cluster."""
|
|
self.assertFalse(
|
|
swarm_nfs_backed(
|
|
{"name": "bigbluebutton_database"},
|
|
application_id="web-app-bigbluebutton",
|
|
deployment_mode="swarm",
|
|
storage_backend="nfs",
|
|
)
|
|
)
|
|
|
|
def test_an_unresolvable_force_expression_is_not_backed(self):
|
|
"""web-app-matrix computes compose_mode_force from a config lookup. A
|
|
mode this predicate cannot resolve statically must keep the volume in
|
|
the volume backup rather than drop it from both capture paths."""
|
|
self.assertFalse(
|
|
swarm_nfs_backed(
|
|
{"name": "matrix_mdad_matrix"},
|
|
application_id="web-app-matrix",
|
|
deployment_mode="swarm",
|
|
storage_backend="nfs",
|
|
)
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|