mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
119 lines
3.5 KiB
Python
119 lines
3.5 KiB
Python
"""Unit tests for the timeout lookup plugin.
|
|
|
|
Pins the scaling contract:
|
|
|
|
* factor unset -> identity (value-identical drop-in for the literal).
|
|
* TIMEOUT_FACTOR from play vars scales the base.
|
|
* an explicit ``factor=`` kwarg overrides the global.
|
|
* numeric strings are coerced; non-numeric / negative base or factor raises.
|
|
* exactly one positional term is required.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import unittest
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
|
|
def _load_lookup():
|
|
spec = importlib.util.spec_from_file_location(
|
|
"lookup_timeout", str(PROJECT_ROOT / "plugins/lookup/timeout.py")
|
|
)
|
|
mod = importlib.util.module_from_spec(spec)
|
|
assert spec and spec.loader
|
|
spec.loader.exec_module(mod)
|
|
return mod.LookupModule
|
|
|
|
|
|
class _DummyTemplar:
|
|
def __init__(self, available_variables=None):
|
|
self.available_variables = available_variables or {}
|
|
|
|
def template(self, value):
|
|
return value
|
|
|
|
|
|
class TestTimeoutLookup(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.LookupModule = _load_lookup()
|
|
|
|
def _make(self, variables):
|
|
lm = self.LookupModule()
|
|
lm._templar = _DummyTemplar(variables)
|
|
lm._loader = None
|
|
return lm
|
|
|
|
def test_factor_unset_is_identity(self):
|
|
lm = self._make({})
|
|
self.assertEqual(lm.run([3600], variables={}), [3600])
|
|
|
|
def test_factor_one_is_identity(self):
|
|
vars_ = {"TIMEOUT_FACTOR": 1}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([3600], variables=vars_), [3600])
|
|
|
|
def test_factor_two_doubles(self):
|
|
vars_ = {"TIMEOUT_FACTOR": 2}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([600], variables=vars_), [1200])
|
|
|
|
def test_fractional_factor_rounds(self):
|
|
vars_ = {"TIMEOUT_FACTOR": 1.5}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([100], variables=vars_), [150])
|
|
|
|
def test_string_base_coerced(self):
|
|
vars_ = {"TIMEOUT_FACTOR": 2}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run(["300"], variables=vars_), [600])
|
|
|
|
def test_string_factor_coerced(self):
|
|
vars_ = {"TIMEOUT_FACTOR": "2"}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([300], variables=vars_), [600])
|
|
|
|
def test_explicit_factor_kwarg_overrides_global(self):
|
|
vars_ = {"TIMEOUT_FACTOR": 5}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([100], variables=vars_, factor=3), [300])
|
|
|
|
def test_zero_base_stays_zero(self):
|
|
vars_ = {"TIMEOUT_FACTOR": 4}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([0], variables=vars_), [0])
|
|
|
|
def test_no_term_raises(self):
|
|
lm = self._make({})
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run([], variables={})
|
|
|
|
def test_too_many_terms_raises(self):
|
|
lm = self._make({})
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run([1, 2], variables={})
|
|
|
|
def test_non_numeric_base_raises(self):
|
|
lm = self._make({})
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run(["abc"], variables={})
|
|
|
|
def test_negative_factor_raises(self):
|
|
vars_ = {"TIMEOUT_FACTOR": -1}
|
|
lm = self._make(vars_)
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run([100], variables=vars_)
|
|
|
|
def test_none_terms_raises(self):
|
|
lm = self._make({})
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run(None, variables={})
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main(verbosity=2)
|