mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-07 03:15:56 +00:00
kevinveenbirkenbach
3222904232
test-unit-php and test-unit-ruby exited 0 whenever the interpreter or the vendor tree was missing, so both suites were silently absent from every gate. They now provision their toolchain through install-php/install-ruby and fail loudly when that is impossible. The three ensure_*_present helpers collapse into ensure_command_present in system_pkg, and the ruby runner rejects an empty suite because minitest reports success when nothing was required.
78 lines
2.7 KiB
Python
78 lines
2.7 KiB
Python
"""Unit tests for :mod:`utils.install.php`."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import subprocess
|
|
import unittest
|
|
import unittest.mock as mock
|
|
|
|
from utils.install import php as php_mod
|
|
|
|
|
|
class TestEnsurePhpPresent(unittest.TestCase):
|
|
def test_vendor_tree_present_skips_composer(self) -> None:
|
|
with (
|
|
mock.patch.object(php_mod, "ensure_command_present") as ensure,
|
|
mock.patch.object(php_mod, "_PHPUNIT") as phpunit,
|
|
mock.patch.object(php_mod.subprocess, "run") as run,
|
|
):
|
|
phpunit.is_file.return_value = True
|
|
php_mod.ensure_php_present()
|
|
self.assertEqual(
|
|
[c.args[0] for c in ensure.call_args_list], ["php", "composer"]
|
|
)
|
|
run.assert_not_called()
|
|
|
|
def test_missing_vendor_tree_runs_composer_install(self) -> None:
|
|
with (
|
|
mock.patch.object(php_mod, "ensure_command_present"),
|
|
mock.patch.object(php_mod, "_PHPUNIT") as phpunit,
|
|
mock.patch.object(php_mod.subprocess, "run") as run,
|
|
):
|
|
phpunit.is_file.side_effect = [False, True]
|
|
php_mod.ensure_php_present()
|
|
run.assert_called_once_with(
|
|
["composer", "install", "--no-interaction", "--no-progress"],
|
|
cwd=php_mod.PROJECT_ROOT,
|
|
check=True,
|
|
)
|
|
|
|
def test_raises_when_phpunit_still_missing(self) -> None:
|
|
with (
|
|
mock.patch.object(php_mod, "ensure_command_present"),
|
|
mock.patch.object(php_mod, "_PHPUNIT") as phpunit,
|
|
mock.patch.object(php_mod.subprocess, "run"),
|
|
self.assertRaises(RuntimeError),
|
|
):
|
|
phpunit.is_file.return_value = False
|
|
php_mod.ensure_php_present()
|
|
|
|
def test_propagates_a_failed_composer_install(self) -> None:
|
|
with (
|
|
mock.patch.object(php_mod, "ensure_command_present"),
|
|
mock.patch.object(php_mod, "_PHPUNIT") as phpunit,
|
|
mock.patch.object(
|
|
php_mod.subprocess,
|
|
"run",
|
|
side_effect=subprocess.CalledProcessError(1, "composer"),
|
|
),
|
|
self.assertRaises(subprocess.CalledProcessError),
|
|
):
|
|
phpunit.is_file.return_value = False
|
|
php_mod.ensure_php_present()
|
|
|
|
def test_missing_interpreter_fails_before_composer(self) -> None:
|
|
with (
|
|
mock.patch.object(
|
|
php_mod, "ensure_command_present", side_effect=RuntimeError("boom")
|
|
),
|
|
mock.patch.object(php_mod.subprocess, "run") as run,
|
|
self.assertRaises(RuntimeError),
|
|
):
|
|
php_mod.ensure_php_present()
|
|
run.assert_not_called()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|