mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
64 lines
2.1 KiB
Python
64 lines
2.1 KiB
Python
import unittest
|
|
import unittest.mock as mock
|
|
|
|
from utils.packages.outcome import aggregate, failure_message
|
|
|
|
|
|
class TestFailureMessage(unittest.TestCase):
|
|
def _msg(self, **result):
|
|
return failure_message({"module": "m", **result})
|
|
|
|
def test_msg_wins(self):
|
|
self.assertEqual(self._msg(msg="boom", exception="ex"), "m: boom")
|
|
|
|
def test_event_msg_carries_a_crash(self):
|
|
event = mock.Mock(msg="unhandled")
|
|
self.assertEqual(self._msg(exception=mock.Mock(event=event)), "m: unhandled")
|
|
|
|
def test_bare_exception_is_used_when_no_event(self):
|
|
self.assertEqual(
|
|
self._msg(exception="(traceback unavailable)"),
|
|
"m: (traceback unavailable)",
|
|
)
|
|
|
|
def test_module_stderr_is_the_next_rung(self):
|
|
self.assertEqual(self._msg(module_stderr=" oops "), "m: oops")
|
|
|
|
def test_stderr_is_the_last_rung(self):
|
|
self.assertEqual(self._msg(stderr="last"), "m: last")
|
|
|
|
def test_a_silent_failure_still_names_the_module(self):
|
|
self.assertIn("m", self._msg())
|
|
|
|
|
|
class TestAggregate(unittest.TestCase):
|
|
def test_all_skipped_reports_skip(self):
|
|
result = aggregate([], ["selinux-python-binding"], "debian")
|
|
self.assertTrue(result["skipped"])
|
|
self.assertFalse(result["changed"])
|
|
|
|
def test_changed_is_any_changed(self):
|
|
result = aggregate([{"changed": False}, {"changed": True}], [], "debian")
|
|
self.assertTrue(result["changed"])
|
|
|
|
def test_failure_propagates_with_its_module(self):
|
|
result = aggregate(
|
|
[
|
|
{"changed": False},
|
|
{"failed": True, "msg": "boom", "module": "ansible.builtin.package"},
|
|
],
|
|
[],
|
|
"debian",
|
|
)
|
|
self.assertTrue(result["failed"])
|
|
self.assertIn("boom", result["msg"])
|
|
self.assertIn("ansible.builtin.package", result["msg"])
|
|
|
|
def test_partial_skips_are_reported(self):
|
|
result = aggregate([{"changed": True}], ["libntirpc"], "debian")
|
|
self.assertEqual(result["skipped_ids"], ["libntirpc"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|