mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
140 lines
5.0 KiB
Python
140 lines
5.0 KiB
Python
from __future__ import annotations
|
|
|
|
import unittest
|
|
import unittest.mock as mock
|
|
|
|
from plugins.lookup.prometheus_integration_active import LookupModule
|
|
|
|
|
|
def _make_applications(
|
|
*app_ids: str,
|
|
prometheus_deps: tuple = (),
|
|
) -> dict:
|
|
"""Build a minimal applications dict.
|
|
|
|
Apps listed in *prometheus_deps* get services.prometheus.enabled: true.
|
|
"""
|
|
apps = {}
|
|
for app_id in app_ids:
|
|
if app_id in prometheus_deps:
|
|
apps[app_id] = {"services": {"prometheus": {"enabled": True}}}
|
|
else:
|
|
apps[app_id] = {}
|
|
return apps
|
|
|
|
|
|
def _run(applications: dict, application_id: str, group_names: list) -> bool:
|
|
lm = LookupModule()
|
|
lm._loader = mock.MagicMock()
|
|
with mock.patch(
|
|
"plugins.lookup.prometheus_integration_active.lookup_loader"
|
|
) as loader_mock:
|
|
loader_mock.get.return_value = mock.MagicMock(
|
|
run=lambda *_a, **_k: [applications]
|
|
)
|
|
return lm.run(
|
|
[],
|
|
variables={
|
|
"applications": applications,
|
|
"application_id": application_id,
|
|
"group_names": group_names,
|
|
},
|
|
)[0]
|
|
|
|
|
|
def _run_explicit(applications: dict, application_id: str, group_names: list) -> bool:
|
|
"""Invoke with application_id as explicit term 0 — the template usage pattern."""
|
|
lm = LookupModule()
|
|
lm._loader = mock.MagicMock()
|
|
with mock.patch(
|
|
"plugins.lookup.prometheus_integration_active.lookup_loader"
|
|
) as loader_mock:
|
|
loader_mock.get.return_value = mock.MagicMock(
|
|
run=lambda *_a, **_k: [applications]
|
|
)
|
|
return lm.run(
|
|
[application_id],
|
|
variables={
|
|
"applications": applications,
|
|
"group_names": group_names,
|
|
},
|
|
)[0]
|
|
|
|
|
|
class TestPrometheusIntegrationActiveDeploymentCheck(unittest.TestCase):
|
|
"""group_names gate — web-app-prometheus must be on this host."""
|
|
|
|
def test_false_when_prometheus_not_in_group_names(self):
|
|
apps = _make_applications("web-app-gitea", prometheus_deps=("web-app-gitea",))
|
|
result = _run(apps, "web-app-gitea", [])
|
|
self.assertFalse(result)
|
|
|
|
def test_false_when_prometheus_not_deployed_even_with_dep(self):
|
|
apps = _make_applications("web-app-gitea", prometheus_deps=("web-app-gitea",))
|
|
result = _run(apps, "web-app-gitea", ["web-app-gitea"])
|
|
self.assertFalse(result)
|
|
|
|
|
|
class TestPrometheusIntegrationActivePrometheusVhost(unittest.TestCase):
|
|
"""When the current app IS web-app-prometheus the result is always True."""
|
|
|
|
def test_true_for_prometheus_vhost_itself(self):
|
|
apps = _make_applications("web-app-prometheus")
|
|
result = _run(apps, "web-app-prometheus", ["web-app-prometheus"])
|
|
self.assertTrue(result)
|
|
|
|
def test_true_for_prometheus_vhost_even_without_service_dep(self):
|
|
apps = {"web-app-prometheus": {}}
|
|
result = _run(apps, "web-app-prometheus", ["web-app-prometheus"])
|
|
self.assertTrue(result)
|
|
|
|
|
|
class TestPrometheusIntegrationActiveServiceDep(unittest.TestCase):
|
|
"""services.prometheus.enabled gate for non-prometheus vhosts."""
|
|
|
|
def test_true_when_app_declares_prometheus_dep(self):
|
|
apps = _make_applications("web-app-gitea", prometheus_deps=("web-app-gitea",))
|
|
result = _run(apps, "web-app-gitea", ["web-app-prometheus", "web-app-gitea"])
|
|
self.assertTrue(result)
|
|
|
|
def test_false_when_app_has_no_prometheus_dep(self):
|
|
apps = _make_applications("web-app-gitea")
|
|
result = _run(apps, "web-app-gitea", ["web-app-prometheus", "web-app-gitea"])
|
|
self.assertFalse(result)
|
|
|
|
def test_false_when_prometheus_dep_disabled(self):
|
|
apps = {"web-app-gitea": {"services": {"prometheus": {"enabled": False}}}}
|
|
result = _run(apps, "web-app-gitea", ["web-app-prometheus", "web-app-gitea"])
|
|
self.assertFalse(result)
|
|
|
|
|
|
class TestPrometheusIntegrationActiveExplicitTerm(unittest.TestCase):
|
|
"""application_id passed as explicit term 0 — matches template invocation pattern.
|
|
|
|
Templates call lookup('prometheus_integration_active', application_id).
|
|
'applications' is read from available_variables.
|
|
"""
|
|
|
|
def test_true_when_app_declares_prometheus_dep_explicit(self):
|
|
apps = _make_applications("web-app-gitea", prometheus_deps=("web-app-gitea",))
|
|
result = _run_explicit(
|
|
apps, "web-app-gitea", ["web-app-prometheus", "web-app-gitea"]
|
|
)
|
|
self.assertTrue(result)
|
|
|
|
def test_false_when_app_has_no_prometheus_dep_explicit(self):
|
|
apps = _make_applications("web-app-gitea")
|
|
result = _run_explicit(
|
|
apps, "web-app-gitea", ["web-app-prometheus", "web-app-gitea"]
|
|
)
|
|
self.assertFalse(result)
|
|
|
|
def test_true_for_prometheus_vhost_explicit(self):
|
|
apps = _make_applications("web-app-prometheus")
|
|
result = _run_explicit(apps, "web-app-prometheus", ["web-app-prometheus"])
|
|
self.assertTrue(result)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|