mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 11:46:35 +00:00
DEPLOYMENT_MODE was compared against a quoted literal 219 times across 110
files. IS_COMPOSE_MODE and IS_SWARM_MODE say the same thing once, and
test_deployment_mode_booleans keeps it that way: only the file that defines
them may still compare.
Both are real booleans under this ansible, measured before the swap because
the alternative is silent: a variable that templates to the string "False" is
truthy in Jinja, which is why IS_STACK_HOST is written `| bool` at every use.
These need no filter.
What had to learn the names:
* utils/annotations/task_gate.py, which several lints ask whether a task is
compose-only gated;
* four compose-template lints that recognise their gate by matching the
expression;
* the fixtures that stand in for the play's variables. They derive the
booleans from the mode now instead of carrying them, or a test that
overrides DEPLOYMENT_MODE keeps the old pair and asserts the wrong
branch.
Each replacement was checked rather than trusted: the 206 conditions that
changed in place were evaluated old against new through the Templar under
compose, swarm and host, with no disagreement, and no changed line turned out
to be anything but a condition swap. `!= 'swarm'` became `not IS_SWARM_MODE`
rather than the shorter IS_COMPOSE_MODE, because only the literal translation
stays correct should the mode ever be host.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
177 lines
5.7 KiB
Python
177 lines
5.7 KiB
Python
"""Unit tests for the compose_replicas lookup plugin.
|
|
|
|
Pins the SPOT contract for swarm replica calculation:
|
|
|
|
* swarm mode: emits `replicas: N` where N defaults to
|
|
`len(groups[application_id])` or the override term.
|
|
* non-swarm mode: emits empty string.
|
|
* missing group / empty topology default: clamped to 1.
|
|
* an explicit override term is respected as-is, including 0 (lets a
|
|
service stay unscheduled until the role scales it up).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import unittest
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
|
|
def _load_lookup():
|
|
spec = importlib.util.spec_from_file_location(
|
|
"lookup_compose_replicas",
|
|
str(PROJECT_ROOT / "plugins/lookup/compose_replicas.py"),
|
|
)
|
|
mod = importlib.util.module_from_spec(spec)
|
|
assert spec and spec.loader
|
|
spec.loader.exec_module(mod)
|
|
return mod.LookupModule
|
|
|
|
|
|
class _DummyTemplar:
|
|
def __init__(self, available_variables=None):
|
|
self.available_variables = available_variables or {}
|
|
|
|
def template(self, value):
|
|
return value
|
|
|
|
|
|
class TestComposeReplicasLookup(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.LookupModule = _load_lookup()
|
|
|
|
def _make(self, variables):
|
|
lm = self.LookupModule()
|
|
lm._templar = _DummyTemplar(variables)
|
|
lm._loader = None
|
|
return lm
|
|
|
|
def test_compose_mode_no_arg_emits_empty(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "compose",
|
|
"IS_COMPOSE_MODE": True,
|
|
"IS_SWARM_MODE": False,
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["h1", "h2", "h3"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), [""])
|
|
|
|
def test_compose_mode_with_arg_emits_empty(self):
|
|
vars_ = {"DEPLOYMENT_MODE": "compose"}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([3], variables=vars_), [""])
|
|
|
|
def test_missing_deployment_mode_defaults_to_compose(self):
|
|
vars_ = {
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["h1", "h2"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), [""])
|
|
|
|
def test_swarm_mode_default_uses_group_length(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "swarm",
|
|
"IS_COMPOSE_MODE": False,
|
|
"IS_SWARM_MODE": True,
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["mgr-01", "wrk-01", "wrk-02"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), ["replicas: 3"])
|
|
|
|
def test_swarm_mode_single_host_yields_one(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "swarm",
|
|
"IS_COMPOSE_MODE": False,
|
|
"IS_SWARM_MODE": True,
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["h1"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), ["replicas: 1"])
|
|
|
|
def test_swarm_mode_empty_group_falls_back_to_one(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "swarm",
|
|
"IS_COMPOSE_MODE": False,
|
|
"IS_SWARM_MODE": True,
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": []},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), ["replicas: 1"])
|
|
|
|
def test_swarm_mode_missing_group_falls_back_to_one(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "swarm",
|
|
"IS_COMPOSE_MODE": False,
|
|
"IS_SWARM_MODE": True,
|
|
"application_id": "web-app-x",
|
|
"groups": {},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), ["replicas: 1"])
|
|
|
|
def test_swarm_mode_explicit_override(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "swarm",
|
|
"IS_COMPOSE_MODE": False,
|
|
"IS_SWARM_MODE": True,
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["h1", "h2", "h3"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([5], variables=vars_), ["replicas: 5"])
|
|
|
|
def test_swarm_mode_override_string_coerced(self):
|
|
vars_ = {"DEPLOYMENT_MODE": "swarm"}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run(["2"], variables=vars_), ["replicas: 2"])
|
|
|
|
def test_swarm_mode_override_zero_respected(self):
|
|
vars_ = {"DEPLOYMENT_MODE": "swarm"}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([0], variables=vars_), ["replicas: 0"])
|
|
|
|
def test_too_many_terms_raises(self):
|
|
vars_ = {"DEPLOYMENT_MODE": "swarm"}
|
|
lm = self._make(vars_)
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run([1, 2], variables=vars_)
|
|
|
|
def test_invalid_override_raises(self):
|
|
vars_ = {"DEPLOYMENT_MODE": "swarm"}
|
|
lm = self._make(vars_)
|
|
with self.assertRaises(AnsibleError):
|
|
lm.run(["not-a-number"], variables=vars_)
|
|
|
|
def test_swarm_mode_whitespace_in_mode_normalised(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": " swarm ",
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["h1", "h2"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run([], variables=vars_), ["replicas: 2"])
|
|
|
|
def test_none_terms_treated_as_no_args(self):
|
|
vars_ = {
|
|
"DEPLOYMENT_MODE": "swarm",
|
|
"IS_COMPOSE_MODE": False,
|
|
"IS_SWARM_MODE": True,
|
|
"application_id": "web-app-x",
|
|
"groups": {"web-app-x": ["a", "b"]},
|
|
}
|
|
lm = self._make(vars_)
|
|
self.assertEqual(lm.run(None, variables=vars_), ["replicas: 2"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main(verbosity=2)
|