Files
computer-playbook/tests/unit/python/cli/administration/deploy/development/test_exec.py
T
kevinveenbirkenbachandClaude Opus 5 575a5a87ac refactor(layout): sort shipped scripts by language and split the unit suite
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).

This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.

Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:

  * 7 `src:` values built from a role variable holding a bare filename
    (svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
    The variable doubles as the destination name inside the container, so the
    language segment belongs at the call site, not in the variable.
  * `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
    through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
    18 roles ship exactly that and have no template fallback: the play would
    have died on each.
  * `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
    interface now reads `files/javascript/javascript.js`.
  * `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
    path through `path_absolute(... 'files', ...)`.
  * 4 `ansible.builtin.script:` invocations naming a bare command
    (pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
  * `dev-python/files/shell/install.sh` pointed at a sibling role's script.

Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-22 01:31:09 +02:00

164 lines
5.1 KiB
Python

from __future__ import annotations
import argparse
import os
import unittest
import unittest.mock
from cli.administration.deploy.development import exec as exec_cmd
def _args(
*,
distro: str = "debian",
cmd: list[str] | None = None,
env: list[str] | None = None,
) -> argparse.Namespace:
return argparse.Namespace(
distro=distro,
cmd=cmd if cmd is not None else [],
env=env if env is not None else [],
)
class TestDevelopmentExec(unittest.TestCase):
def test_handler_forwards_services_disabled(self):
compose = unittest.mock.Mock()
compose.exec.return_value.returncode = 0
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
unittest.mock.patch.dict(os.environ, {"disable": "email"}, clear=False),
):
rc = exec_cmd.handler(_args(cmd=["--", "sh", "-lc", "true"]))
self.assertEqual(rc, 0)
compose.exec.assert_called_once_with(
["sh", "-lc", "true"],
check=False,
extra_env={"disable": "email"},
)
def test_handler_omits_extra_env_when_services_disabled_unset(self):
compose = unittest.mock.Mock()
compose.exec.return_value.returncode = 0
env = {**os.environ, "disable": ""}
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
unittest.mock.patch.dict(os.environ, env, clear=True),
):
rc = exec_cmd.handler(_args(cmd=["echo", "hi"]))
self.assertEqual(rc, 0)
compose.exec.assert_called_once_with(
["echo", "hi"], check=False, extra_env=None
)
def test_handler_requires_command(self):
with self.assertRaises(SystemExit):
exec_cmd.handler(_args(cmd=[]))
def test_env_pairs_are_injected_into_extra_env(self):
compose = unittest.mock.Mock()
compose.exec.return_value.returncode = 0
env = {**os.environ, "disable": ""}
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
unittest.mock.patch.dict(os.environ, env, clear=True),
):
rc = exec_cmd.handler(
_args(
cmd=["bash", "/opt/helper.sh"],
env=[
"INFINITO_INVENTORY_FILE=/srv/inv/devices.yml",
"apps=web-app-foo",
],
)
)
self.assertEqual(rc, 0)
compose.exec.assert_called_once_with(
["bash", "/opt/helper.sh"],
check=False,
extra_env={
"INFINITO_INVENTORY_FILE": "/srv/inv/devices.yml",
"apps": "web-app-foo",
},
)
def test_env_pair_with_equals_in_value_is_preserved(self):
compose = unittest.mock.Mock()
compose.exec.return_value.returncode = 0
env = {**os.environ, "disable": ""}
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
unittest.mock.patch.dict(os.environ, env, clear=True),
):
exec_cmd.handler(_args(cmd=["true"], env=["EXTRA_VARS=a=1 b=2"]))
compose.exec.assert_called_once_with(
["true"],
check=False,
extra_env={"EXTRA_VARS": "a=1 b=2"},
)
def test_env_pair_overrides_implicit_services_disabled(self):
compose = unittest.mock.Mock()
compose.exec.return_value.returncode = 0
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
unittest.mock.patch.dict(os.environ, {"disable": "from-env"}, clear=False),
):
exec_cmd.handler(_args(cmd=["true"], env=["disable=from-cli"]))
compose.exec.assert_called_once_with(
["true"],
check=False,
extra_env={"disable": "from-cli"},
)
def test_env_pair_without_equals_is_rejected(self):
compose = unittest.mock.Mock()
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
self.assertRaisesRegex(SystemExit, "expects KEY=VALUE"),
):
exec_cmd.handler(_args(cmd=["true"], env=["BARE"]))
def test_env_pair_with_empty_key_is_rejected(self):
compose = unittest.mock.Mock()
with (
unittest.mock.patch(
"cli.administration.deploy.development.exec.make_compose",
return_value=compose,
),
self.assertRaisesRegex(SystemExit, "KEY is empty"),
):
exec_cmd.handler(_args(cmd=["true"], env=["=value"]))
if __name__ == "__main__":
unittest.main()