Files
computer-playbook/tests/unit/python/utils
kevinveenbirkenbachandClaude Opus 5.5 260ebf7357 fix(backup): ask every rendered service for its stop decision
test_backup_stop_decision_declared looked a volume mount's `service` up
as a meta/services.yml key. A role whose compose service is renamed via
`proxy.service_key` slipped through: web-svc-xmpp mounts `ejabberd`, its
entry is `xmpp`, and the lint never asked it to decide.

- compose_service_names() in utils/roles/applications/mounts.py is the
  shared mapping from a meta key to the compose services it renders as
  (the key plus a literal proxy.service_key); the lint resolves each
  backed-up mount to its owning keys through it, and
  test_image_volumes_mounted uses it instead of its own copy.
- web-svc-xmpp stops before the copy (`/opt/ejabberd/database` is a
  Mnesia store spread over several files), which is what the missing
  marker already did. Its upload volume is no longer backed up: the
  ejabberd config enables no mod_http_upload, so nothing writes there.
- web-app-pretix deploys pretix_custom:3.13, the reference
  lookup('backup_image', 'stop_required', false) resolves, instead of
  overriding the tag with the source version. The override made the
  deployed image miss --images-no-stop-required, so baudolo stopped
  Pretix despite `stop_required: false`. The source version moves into
  the build args, which keeps a bump rebuilding through the build
  digest, and into an OCI version label on the image.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:41:45 +01:00
..