Files
computer-playbook/utils/annotations/summarize.py
T
kevinveenbirkenbachandClaude Opus 4.7 26ef3ff504 chore(ruff): enable strict ruleset (E/F/I/B/UP, py311) — 2819 → 0
Adds ``[tool.ruff.lint]`` with ``select = ["E", "F", "I", "B", "UP"]``
and ``target-version = "py311"``. ``E501`` is ignored because
``ruff format`` already reflows what it can; the remaining long lines
are unsplittable string literals / URLs.

Auto-fixed (2753 issues, behavior-preserving):
- UP006/UP035: ``List[X]`` → ``list[X]``, ``Dict[X]`` → ``dict[X]``,
  ``from typing import …`` redirected where superseded by builtins.
- UP045: ``Optional[X]`` → ``X | None``.
- UP010/UP009/UP015: dropped Python-2-era pragmas (``from __future__
  import absolute_import, division, print_function``,
  ``# -*- coding: utf-8 -*-``), redundant ``open(..., "r")`` mode.
- UP004: dropped implicit ``class X(object):``.
- UP022/UP008/UP032: stdlib idiom modernization (``capture_output``,
  super-call simplification, etc.).
- B905: ``zip(...)`` → ``zip(..., strict=False)`` (preserves prior
  behavior; switching to ``strict=True`` is a separate semantic
  choice not made here).
- I001: import-block ordering.

Hand-fixed (66 issues):
- B904 × 54: appended ``from <bound>`` (when the enclosing ``except``
  binds a name) or ``from None`` (when it doesn't) so chained
  exceptions stay distinguishable from errors-during-exception-
  handling. Applied via a small AST-aware script that walked back to
  the enclosing ``except`` clause and matched the binding.
- B017 × 4: narrowed broad ``assertRaises(Exception)`` to the actual
  ``AnsibleError`` / ``AnsibleFilterError`` raised by the code under
  test.
- B023 × 2: bound captured loop variables via default args
  (``def _record(name, *, _path_real=path_real, ...)``) so each
  closure gets its own snapshot.
- B007 × 2: unused loop control variables renamed to ``_`` /
  rewritten to ``.values()``.
- UP007 × 2: ``Union[X, Y]`` → ``X | Y`` (plus dropping the now-unused
  ``from typing import Union``).
- B018 × 1: Odoo addon manifests are bare dict expressions at module
  level by design — suppressed with an inline ``# noqa: B018`` and
  rationale comment.
- UP031 × 1: printf-style format → f-string.

The 65 ``# noqa: …`` markers introduced by the auto-fixer all carry
real ruff codes (``B018``, ``E402``, ``F401``, etc.), so
``test_noqa_only_ruff_codes`` stays green.

Verification
============
- ``ruff check .`` → All checks passed
- ``ruff format --check .`` → 894 files already formatted
- ``tests.lint.repository.{test_project_root_import,
  test_no_direct_yaml_calls, test_noqa_only_ruff_codes}`` and
  ``tests.unit.utils.annotations.test_suppress`` → 20 tests OK
- 1621 unit tests → all pass
- Integration suite: 44 failures (pre-existing baseline, none from
  this change), 1 skipped.

Going forward, the new rules block regressions on E (style), F
(pyflakes), I (import order), B (likely-bug patterns), and UP
(modernization to py311) for any new code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-07 16:57:20 +02:00

119 lines
3.5 KiB
Python

#!/usr/bin/env python3
"""Parse GHA annotation lines from a log file and write a Markdown summary
to $GITHUB_STEP_SUMMARY.
Usage:
python3 -m utils.annotations.summarize <logfile> [<title>]
Annotation format emitted by utils.annotations.message:
::warning title=<t>,file=<f>,line=<l>,col=<c>::<message>
::error title=<t>,...::<message>
::notice title=<t>,...::<message>
"""
from __future__ import annotations
import os
import re
import sys
from collections import defaultdict
from dataclasses import dataclass
from pathlib import Path
ANNOTATION_RE = re.compile(r"^::(warning|error|notice)(?:\s([^:]*))?::(.*)$")
PROP_RE = re.compile(r"(\w+)=([^,]*)")
ICONS = {"error": "🔴", "warning": "🟡", "notice": "🔵"}
HEADINGS = {"error": "Errors", "warning": "Warnings", "notice": "Notices"}
@dataclass
class Annotation:
level: str
message: str
title: str | None = None
file: str | None = None
line: int | None = None
col: int | None = None
def parse_props(props_str: str) -> dict[str, str]:
return {m.group(1): m.group(2) for m in PROP_RE.finditer(props_str or "")}
def parse_log(path: Path) -> list[Annotation]:
annotations: list[Annotation] = []
for raw in path.read_text(errors="replace").splitlines():
m = ANNOTATION_RE.match(raw.strip())
if not m:
continue
level, props_str, message = m.group(1), m.group(2) or "", m.group(3)
props = parse_props(props_str)
annotations.append(
Annotation(
level=level,
message=message,
title=props.get("title"),
file=props.get("file"),
line=int(props["line"]) if "line" in props else None,
col=int(props["col"]) if "col" in props else None,
)
)
return annotations
def render_markdown(annotations: list[Annotation], title: str) -> str:
if not annotations:
return f"## {title}\n\n✅ No annotations found.\n"
by_level: dict[str, list[Annotation]] = defaultdict(list)
for a in annotations:
by_level[a.level].append(a)
lines = [f"## {title}\n"]
for level in ("error", "warning", "notice"):
items = by_level.get(level, [])
if not items:
continue
icon = ICONS[level]
heading = HEADINGS[level]
lines.append(f"### {icon} {heading} ({len(items)})\n")
lines.append("| Title | File | Message |")
lines.append("|-------|------|---------|")
for a in items:
t = a.title or ""
loc = a.file or ""
if loc and a.line:
loc = f"{loc}:{a.line}"
msg = a.message.replace("|", "\\|")
lines.append(f"| {t} | {loc} | {msg} |")
lines.append("")
return "\n".join(lines)
def main() -> None:
if len(sys.argv) < 2:
print("Usage: summarize <logfile> [<title>]", file=sys.stderr)
sys.exit(1)
log_path = Path(sys.argv[1])
title = sys.argv[2] if len(sys.argv) > 2 else "Annotation Summary"
if not log_path.exists():
print(f"Log file not found, skipping summary: {log_path}", file=sys.stderr)
sys.exit(0)
annotations = parse_log(log_path)
markdown = render_markdown(annotations, title)
summary_file = os.environ.get("GITHUB_STEP_SUMMARY")
if summary_file:
with open(summary_file, "a") as f:
f.write(markdown + "\n")
else:
print(markdown)
if __name__ == "__main__":
main()